Skip to contentSkip to conversation

doc: Fix statements on case sensitivity for regulator prefix

PATCH In review Felix Brack 2 participants 2 messages Sep 22, 2017 – Oct 7, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: Fix statements on case sensitivity for regulator prefix

The regulator bindings state that regulator prefixes are allowd to be in upper or lower case. However pmic_bind_children from pmic_uclass uses strncmp to compare DT node name against prefix. This comparison is case sensitive hence the regulator driver prefix case matters.

---

 doc/device-tree-bindings/regulator/regulator.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
doc/device-tree-bindings/regulator/regulator.txt +2 -2
index 2cf4b9d..918711e 100644
@@ -10,10 +10,10 @@ pmic: drivers/power/pmic/max77686.c
 regulator: drivers/power/regulator/max77686.c
 
 For the node name e.g.: "prefix[:alpha:]num { ... }":
-- the driver prefix should be: "prefix" or "PREFIX" - case insensitive
+- the driver prefix should be: "prefix" - case sensitive
 - the node name's "num" is set as "dev->driver_data" on bind
 
-Example the prefix "ldo" will pass for: "ldo1", "ldo at 1", "LDO1", "LDOREG at 1"...
+Example the prefix "ldo" will pass for: "ldo1", "ldo at 1", "ldoreg at 1, ...
 
 Optional properties:
 - regulator-name: a string, required by the regulator uclass
Signature · 1 line
2.7.4
#1 lore raw
Quoted 6 lines · Felix Brack

The regulator bindings state that regulator prefixes are allowd to be in upper or lower case. However pmic_bind_children from pmic_uclass uses strncmp to compare DT node name against prefix. This comparison is case sensitive hence the regulator driver prefix case matters.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171007/95506a37/attachment.sig>