arch_topology: Fix section miss match warning due to free_raw_capacity()
Subsystems (2)
PATCH 1/1 arch_topology: Fix section miss match warning due to free_raw_capacity()
Remove the __init annotation from free_raw_capacity() to avoid the following warning.
The function init_cpu_capacity_callback() references the function __init free_raw_capacity().
WARNING: vmlinux.o(.text+0x425cc0): Section mismatch in reference from the function init_cpu_capacity_callback() to the function .init.text:free_raw_capacity().
--- drivers/base/arch_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/base/arch_topology.c +1 -1
@@ -96,7 +96,7 @@ static int register_cpu_capacity_sysctl(void)static u32 capacity_scale;static u32 *raw_capacity; -static int __init free_raw_capacity (void ) +static int free_raw_capacity (void ) {kfree (raw_capacity); raw_capacity =NULL ;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 19 lines · Prasad Sodagudi
Remove the
__initannotation fromfree_raw_capacity()to avoid the following warning.The function
init_cpu_capacity_callback()references the function__initfree_raw_capacity().
WARNING:vmlinux.o(.text+0x425cc0): Section mismatch in reference from the functioninit_cpu_capacity_callback()to the function .init.text:free_raw_capacity().Signed-off-by Prasad Sodagudi <[email protected]>--- drivers/base/arch_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/base/arch_topology.c +0
-0
drivers/base/arch_topology.c static int register_cpu_capacity_sysctl(void) · line 102
Quoted 8 lines
drivers/base/arch_topology.c +1
-1@@ -96,7 +96,7 @@ static int register_cpu_capacity_sysctl(void)static u32 capacity_scale;static u32 *raw_capacity; -static int __init free_raw_capacity (void ) +static int free_raw_capacity (void ) {kfree (raw_capacity); raw_capacity =NULL ;
So we need the __init thing only when cpufreq support isn't there in the kernel and I am not sure if we want to add more ifdef hackery in the declaration of free_raw_capacity().
Signature · 1 line
viresh
Quoted 33 lines · Viresh Kumar
Quoted 19 lines · Prasad Sodagudi
Remove the
__initannotation fromfree_raw_capacity()to avoid the following warning.The function
init_cpu_capacity_callback()references the function__initfree_raw_capacity().
WARNING:vmlinux.o(.text+0x425cc0): Section mismatch in reference from the functioninit_cpu_capacity_callback()to the function .init.text:free_raw_capacity().Signed-off-by Prasad Sodagudi <[email protected]>--- drivers/base/arch_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/base/arch_topology.c +0
-0drivers/base/arch_topology.c static int register_cpu_capacity_sysctl(void) · line 102
Quoted 8 lines
drivers/base/arch_topology.c +1
-1@@ -96,7 +96,7 @@ static int register_cpu_capacity_sysctl(void)static u32 capacity_scale;static u32 *raw_capacity; -static int __init free_raw_capacity (void ) +static int free_raw_capacity (void ) {kfree (raw_capacity); raw_capacity =NULL ;So we need the
__initthing only when cpufreq support isn't there in the kernel and I am not sure if we want to add more ifdef hackery in the declaration offree_raw_capacity().
Quoted 1 line
Acked-by Viresh Kumar <[email protected]>
Hi Greg,
Can you please consider this patch ?
-Thanks, Prasad
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, Linux Foundation Collaborative Project
PATCH 1/1 arch_topology: Fix section miss match warning due to free_raw_capacity()
In reply to Viresh KumarRemove the __init annotation from free_raw_capacity() to avoid the following warning.
The function init_cpu_capacity_callback() references the function __init free_raw_capacity().
WARNING: vmlinux.o(.text+0x425cc0): Section mismatch in reference from the function init_cpu_capacity_callback() to the function .init.text:free_raw_capacity().
--- drivers/base/arch_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/base/arch_topology.c +1 -1
@@ -96,7 +96,7 @@ static int register_cpu_capacity_sysctl(void)static u32 capacity_scale;static u32 *raw_capacity; -static int __init free_raw_capacity (void ) +static int free_raw_capacity (void ) {kfree (raw_capacity); raw_capacity =NULL ;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project