Skip to contentSkip to conversation

tpm: fix duplicate inline declaration specifier

PATCH Applied Ruben Roy 4 participants 5 messages Sep 26, 2017 – Oct 4, 2017 1 message not in the archive TPM device driver

lore
Share & tools
lore

Ruben Roy

author
#0 lore raw

PATCH 1/1 tpm: fix duplicate inline declaration specifier

This commit fixes the duplicate inline declaration specifier in tpm2_rc_value which caused a warning

Signed-off-by Ruben Roy <[email protected]>
---
 drivers/char/tpm/tpm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/tpm/tpm.h +1 -1
index 04fbff2..f4d0272 100644
@@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip)
 }
 #endif
 
-static inline inline u32 tpm2_rc_value(u32 rc)
+static inline u32 tpm2_rc_value(u32 rc)
 {
 	return (rc & BIT(7)) ? rc & 0xff : rc;
 }
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 24 lines · Ruben Roy

This commit fixes the duplicate inline declaration specifier in tpm2_rc_value which caused a warning

Signed-off-by Ruben Roy <[email protected]>
---
 drivers/char/tpm/tpm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/tpm/tpm.h +1 -1
index 04fbff2..f4d0272 100644
@@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip)
 }
 #endif
 
-static inline inline u32 tpm2_rc_value(u32 rc)
+static inline u32 tpm2_rc_value(u32 rc)
 {
 	return (rc & BIT(7)) ? rc & 0xff : rc;
 }
Signature · 1 line
1.8.3.1
Reviewed-by Jarkko Sakkinen <[email protected]>

/Jarkko

#2 lore raw

Thanks! This fixes a warning I was seeing with Clang:

drivers/char/tpm/tpm.h:560:15: warning: duplicate 'inline' declaration specifier [-Wduplicate-decl-specifier]

Quoted 29 lines · Jarkko Sakkinen
Quoted 22 lines · Ruben Roy

This commit fixes the duplicate inline declaration specifier in tpm2_rc_value which caused a warning

Signed-off-by Ruben Roy <[email protected]>
---
 drivers/char/tpm/tpm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/tpm/tpm.h +1 -2
index 04fbff2..f4d0272 100644
@@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip)
 }
 #endif
 
-static inline inline u32 tpm2_rc_value(u32 rc)
+static inline u32 tpm2_rc_value(u32 rc)
 {
      return (rc & BIT(7)) ? rc & 0xff : rc;
 }
--
Quoted 2 lines

1.8.3.1

Reviewed-by Jarkko Sakkinen <[email protected]>

/Jarkko

Applied
#3 lore raw
In reply to Jarkko Sakkinen
Quoted 28 lines · Jarkko Sakkinen
Quoted 24 lines · Ruben Roy

This commit fixes the duplicate inline declaration specifier in tpm2_rc_value which caused a warning

Signed-off-by Ruben Roy <[email protected]>
---
 drivers/char/tpm/tpm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/tpm/tpm.h +1 -1
index 04fbff2..f4d0272 100644
@@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip)
 }
 #endif
 
-static inline inline u32 tpm2_rc_value(u32 rc)
+static inline u32 tpm2_rc_value(u32 rc)
 {
 	return (rc & BIT(7)) ? rc & 0xff : rc;
 }
Signature · 1 line
1.8.3.1
Reviewed-by Jarkko Sakkinen <[email protected]>
Quoted 1 line

/Jarkko

Applied.

/Jarkko

A message that is not in the archive (sent off-list or not yet received): 20171004113112.u5jnf3ims7vcxo7b-VuQAYsv1563Yd54FQh9/[email protected]

#5 lore raw

Thank you, Jarkko

Quoted 30 lines · Jarkko Sakkinen
Quoted 9 lines · Jarkko Sakkinen
Quoted 8 lines · Ruben Roy

This commit fixes the duplicate inline declaration specifier in tpm2_rc_value which caused a warning

Signed-off-by Ruben Roy <[email protected]>
---
 drivers/char/tpm/tpm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines

drivers/char/tpm/tpm.h static inline void tpm_add_ppi(struct tpm_chip

Quoted 5 lines
drivers/char/tpm/tpm.h +0 -0
index 04fbff2..f4d0272 100644
@@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip

*chip)

Quoted 14 lines
Quoted 11 lines
drivers/char/tpm/tpm.h +1 -2
 }
 #endif
 
-static inline inline u32 tpm2_rc_value(u32 rc)
+static inline u32 tpm2_rc_value(u32 rc)
 {
    return (rc & BIT(7)) ? rc & 0xff : rc;
 }
--

1.8.3.1

Reviewed-by Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/[email protected]>
Quoted 6 lines
Quoted 1 line

/Jarkko

Applied.

/Jarkko

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
tpmdd-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel