GEM/GuC Suspend/Resume/Reset fixes and restructuring
Subsystems (2)
v11 cover GEM/GuC Suspend/Resume/Reset fixes and restructuring
Older series can be found at
https://patchwork.freedesktop.org/series/30715/
https://patchwork.freedesktop.org/series/30502/
https://patchwork.freedesktop.org/series/30351/
v1-v8: Part of above three series.
v9:
Fixed patch 1 based on review inputs from Michal Winiarski. Rebased all patches. Updated ordering of cc, s-o-b, r-b tags for all patches.
v10: Added new patch (6th). Addressed reviews on v9.
v11: Created separate patch for i915_gem_restore_fences change. Added changes to disable/destroy GuC without dependency on enable_guc_loading and enable_guc_submission. Rebased other patches.
Sagar Arun Kamble (11):
drm/i915: Create GEM runtime resume helper and handle GEM
suspend/resume errors
drm/i915: Update GEM suspend/resume flows with GuC suspend/resume
functions
drm/i915: Move i915_gem_restore_fences to i915_gem_resume drm/i915: Create uC runtime and system suspend/resume helpers drm/i915/guc: Introduce intel_uc_sanitize
drm/i915/guc: Make GuC related disable/destroy functions not depend on
i915.enable_guc_submission
drm/i915/guc: Update i915.enable_guc_loading check in intel_uc_fini_hw drm/i915/guc: Update GuC ggtt.invalidate/interrupts/communication
across RPM suspend/resume
drm/i915/guc: Update GuC suspend functionality in intel_uc_suspend drm/i915/guc: Disable GuC submission and suspend it prior to i915
reset
drm/i915/guc: Fix GuC cleanup in unload path
drivers/gpu/drm/i915/i915_drv.c | 48 +++++++----- drivers/gpu/drm/i915/i915_drv.h | 5 +- drivers/gpu/drm/i915/i915_gem.c | 46 ++++++++++-- drivers/gpu/drm/i915/i915_guc_submission.c | 29 +++----- drivers/gpu/drm/i915/i915_irq.c | 6 ++ drivers/gpu/drm/i915/i915_suspend.c | 2 - drivers/gpu/drm/i915/intel_guc_log.c | 6 +- drivers/gpu/drm/i915/intel_uc.c | 116 ++++++++++++++++++++++++++--- drivers/gpu/drm/i915/intel_uc.h | 10 ++- drivers/gpu/drm/i915/intel_uncore.c | 3 + 10 files changed, 206 insertions(+), 65 deletions(-)
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 1/11 drm/i915: Create GEM runtime resume helper and handle GEM suspend/resume errors
These changes are preparation to handle GuC suspend/resume. Prepared helper i915_gem_runtime_resume to reinitialize suspended gem setup. Returning status from i915_gem_runtime_suspend and i915_gem_resume. This will be placeholder for handling any errors from uC suspend/resume in upcoming patches. Restructured the suspend/resume routines w.r.t setup creation and rollback order.
This also fixes issue of ordering of i915_gem_runtime_resume with intel_runtime_pm_enable_interrupts.
v2: Fixed return from intel_runtime_resume. (Michał Winiarski)
v3: Not returning status from gem_runtime_resume. (Chris)
v4: Refined return from i915_gem_runtime_suspend. (Michal Wajdeczko)
--- drivers/gpu/drm/i915/i915_drv.c | 33 +++++++++++++++++++-------------- drivers/gpu/drm/i915/i915_drv.h | 5 +++-- drivers/gpu/drm/i915/i915_gem.c | 18 ++++++++++++++++-- 3 files changed, 38 insertions(+), 18 deletions(-)
drivers/gpu/drm/i915/i915_drv.c +19 -14
@@ -1655,6 +1655,7 @@ static int i915_suspend_switcheroo(struct drm_device *dev, pm_message_t state)static int i915_drm_resume (struct drm_device *dev) {struct drm_i915_private *dev_priv =to_i915 (dev); +struct pci_dev *pdev = dev_priv->drm.pdev;int ret;disable_rpm_wakeref_asserts (dev_priv);
@@ -1666,7 +1667,9 @@ static int i915_drm_resume(struct drm_device *dev)intel_csr_ucode_resume (dev_priv); -i915_gem_resume (dev_priv); + ret =i915_gem_resume (dev_priv); +if (ret) +dev_err (&pdev->dev,"GEM resume failed\n" );i915_restore_state (dev_priv);intel_pps_unlock_regs_wa (dev_priv);
@@ -2495,7 +2498,9 @@ static int intel_runtime_suspend(struct device *kdev)* We are safe here against re-faults, since the fault handler takes * an RPM reference. */ -i915_gem_runtime_suspend (dev_priv); + ret =i915_gem_runtime_suspend (dev_priv); +if (ret) + goto err_gem_suspend;intel_guc_suspend (dev_priv);
@@ -2513,11 +2518,7 @@ static int intel_runtime_suspend(struct device *kdev)if (ret) {DRM_ERROR ("Runtime suspend failed, disabling it (%d)\n" , ret); -intel_runtime_pm_enable_interrupts (dev_priv); - -enable_rpm_wakeref_asserts (dev_priv); - -return ret; + goto err_suspend_complete; }intel_uncore_suspend (dev_priv);
@@ -2560,6 +2561,15 @@ static int intel_runtime_suspend(struct device *kdev)DRM_DEBUG_KMS ("Device suspended\n" );return 0 ; + +err_suspend_complete: +intel_runtime_pm_enable_interrupts (dev_priv); +intel_guc_resume (dev_priv); +i915_gem_runtime_resume (dev_priv); + +err_gem_suspend: +enable_rpm_wakeref_asserts (dev_priv); +return ret; }static int intel_runtime_resume (struct device *kdev)
@@ -2596,13 +2606,6 @@ static int intel_runtime_resume(struct device *kdev) ret =vlv_resume_prepare (dev_priv, true); } -/* -* No point of rolling back things in case of an error, as the best -* we can do is to hope that things will still work (and disable RPM). -*/ -i915_gem_init_swizzling (dev_priv); -i915_gem_restore_fences (dev_priv); -intel_runtime_pm_enable_interrupts (dev_priv);/*
@@ -2615,6 +2618,8 @@ static int intel_runtime_resume(struct device *kdev)intel_enable_ipc (dev_priv); +i915_gem_runtime_resume (dev_priv); +enable_rpm_wakeref_asserts (dev_priv);if (ret)
drivers/gpu/drm/i915/i915_drv.h +3 -2
@@ -3479,7 +3479,8 @@ struct i915_vma * __must_checkint i915_gem_object_unbind (struct drm_i915_gem_object *obj);void i915_gem_release_mmap (struct drm_i915_gem_object *obj); -void i915_gem_runtime_suspend (struct drm_i915_private *dev_priv); +int i915_gem_runtime_suspend (struct drm_i915_private *dev_priv); +void i915_gem_runtime_resume (struct drm_i915_private *dev_priv);static inline int __sg_page_count (const struct scatterlist *sg) {
@@ -3682,7 +3683,7 @@ void i915_gem_reset_engine(struct intel_engine_cs *engine,int i915_gem_wait_for_idle (struct drm_i915_private *dev_priv,unsigned int flags);int __must_check i915_gem_suspend (struct drm_i915_private *dev_priv); -void i915_gem_resume (struct drm_i915_private *dev_priv); +int i915_gem_resume (struct drm_i915_private *dev_priv);int i915_gem_fault (struct vm_fault *vmf); int i915_gem_object_wait(struct drm_i915_gem_object *obj, unsigned int flags,
drivers/gpu/drm/i915/i915_gem.c +16 -2
@@ -2022,7 +2022,7 @@ int i915_gem_fault(struct vm_fault *vmf)intel_runtime_pm_put (i915); } -void i915_gem_runtime_suspend (struct drm_i915_private *dev_priv) +int i915_gem_runtime_suspend (struct drm_i915_private *dev_priv) {struct drm_i915_gem_object *obj, *on;int i;
@@ -2065,6 +2065,18 @@ void i915_gem_runtime_suspend(struct drm_i915_private *dev_priv)GEM_BUG_ON (!list_empty (®->vma->obj->userfault_link)); reg->dirty = true; } + +return 0 ; +} + +void i915_gem_runtime_resume (struct drm_i915_private *dev_priv) +{ +/* +* No point of rolling back things in case of an error, as the best +* we can do is to hope that things will still work (and disable RPM). +*/ +i915_gem_init_swizzling (dev_priv); +i915_gem_restore_fences (dev_priv); }static int i915_gem_object_create_mmap_offset (struct drm_i915_gem_object *obj)
@@ -4587,7 +4599,7 @@ int i915_gem_suspend(struct drm_i915_private *dev_priv)return ret; } -void i915_gem_resume (struct drm_i915_private *dev_priv) +int i915_gem_resume (struct drm_i915_private *dev_priv) {struct drm_device *dev = &dev_priv->drm;
@@ -4603,6 +4615,8 @@ void i915_gem_resume(struct drm_i915_private *dev_priv) dev_priv->gt.resume (dev_priv);mutex_unlock (&dev->struct_mutex); + +return 0 ; }void i915_gem_init_swizzling (struct drm_i915_private *dev_priv)
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 2/11 drm/i915: Update GEM suspend/resume flows with GuC suspend/resume functions
In reply to Sagar Arun KambleThis patch moves GuC suspend/resume handlers to corresponding GEM handlers and orders them properly in the runtime and system suspend/resume flows.
v2: Removed documentation of suspend/resume handlers as those are not interfaces and are just hooks. (Chris)
v3: Rebase. Removed i915_gem_restore_fences change from this patch. (Michal Wajdeczko)
--- drivers/gpu/drm/i915/i915_drv.c | 7 ------- drivers/gpu/drm/i915/i915_gem.c | 9 +++++++-- 2 files changed, 7 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/i915_drv.c +0 -7
@@ -1698,8 +1698,6 @@ static int i915_drm_resume(struct drm_device *dev) }mutex_unlock (&dev->struct_mutex); -intel_guc_resume (dev_priv); -intel_modeset_init_hw (dev);spin_lock_irq (&dev_priv->irq_lock);
@@ -2502,8 +2500,6 @@ static int intel_runtime_suspend(struct device *kdev)if (ret) goto err_gem_suspend; -intel_guc_suspend (dev_priv); -intel_runtime_pm_disable_interrupts (dev_priv); ret =0 ;
@@ -2564,7 +2560,6 @@ static int intel_runtime_suspend(struct device *kdev) err_suspend_complete:intel_runtime_pm_enable_interrupts (dev_priv); -intel_guc_resume (dev_priv);i915_gem_runtime_resume (dev_priv); err_gem_suspend:
@@ -2592,8 +2587,6 @@ static int intel_runtime_resume(struct device *kdev)if (intel_uncore_unclaimed_mmio (dev_priv))DRM_DEBUG_DRIVER ("Unclaimed access during suspend, bios?\n" ); -intel_guc_resume (dev_priv); -if (IS_GEN9_LP (dev_priv)) {bxt_disable_dc9 (dev_priv);bxt_display_core_init (dev_priv, true);
drivers/gpu/drm/i915/i915_gem.c +7 -2
@@ -2027,6 +2027,8 @@ int i915_gem_runtime_suspend(struct drm_i915_private *dev_priv)struct drm_i915_gem_object *obj, *on;int i; +intel_guc_suspend (dev_priv); +/* * Only called during RPM suspend. All users of the userfault_list * must be holding an RPM wakeref to ensure that this can not
@@ -2077,6 +2079,8 @@ void i915_gem_runtime_resume(struct drm_i915_private *dev_priv)*/ i915_gem_init_swizzling (dev_priv);i915_gem_restore_fences (dev_priv); + +intel_guc_resume (dev_priv); }static int i915_gem_object_create_mmap_offset (struct drm_i915_gem_object *obj)
@@ -4551,8 +4555,6 @@ int i915_gem_suspend(struct drm_i915_private *dev_priv)i915_gem_contexts_lost (dev_priv);mutex_unlock (&dev->struct_mutex); -intel_guc_suspend (dev_priv); -cancel_delayed_work_sync (&dev_priv->gpu_error.hangcheck_work);cancel_delayed_work_sync (&dev_priv->gt.retire_work);
@@ -4569,6 +4571,8 @@ int i915_gem_suspend(struct drm_i915_private *dev_priv)if (WARN_ON (!intel_engines_are_idle (dev_priv)))i915_gem_set_wedged (dev_priv);/* no hope, discard everything */ +intel_guc_suspend (dev_priv); +/* * Neither the BIOS, ourselves or any other kernel * expects the system to be in execlists mode on startup,
@@ -4614,6 +4618,7 @@ int i915_gem_resume(struct drm_i915_private *dev_priv)*/ dev_priv->gt.resume (dev_priv); +intel_guc_resume (dev_priv);mutex_unlock (&dev->struct_mutex);return 0 ;
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 3/11 drm/i915: Move i915_gem_restore_fences to i915_gem_resume
In reply to Sagar Arun Kamblei915_gem_restore_fences is GEM resumption task hence it is moved to i915_gem_resume from i915_restore_state.
--- drivers/gpu/drm/i915/i915_gem.c | 1 + drivers/gpu/drm/i915/i915_suspend.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +1 -0
@@ -4611,6 +4611,7 @@ int i915_gem_resume(struct drm_i915_private *dev_priv)mutex_lock (&dev->struct_mutex);i915_gem_restore_gtt_mappings (dev_priv); +i915_gem_restore_fences (dev_priv);/* As we didn't flush the kernel context before suspend, we cannot * guarantee that the context image is complete. So let's just reset
drivers/gpu/drm/i915/i915_suspend.c +0 -2
@@ -108,8 +108,6 @@ int i915_restore_state(struct drm_i915_private *dev_priv)mutex_lock (&dev_priv->drm.struct_mutex); -i915_gem_restore_fences (dev_priv); -if (IS_GEN4 (dev_priv))pci_write_config_word (pdev,GCDGMBUS , dev_priv->regfile.saveGCDGMBUS);
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 4/11 drm/i915: Create uC runtime and system suspend/resume helpers
In reply to Sagar Arun KamblePrepared generic helpers intel_uc_suspend, intel_uc_resume, intel_uc_runtime_suspend, intel_uc_runtime_resume. These are called from respective GEM functions.
Only exception is intel_uc_resume that needs to be called w/ or w/o GuC loaded in i915_drm_resume path. Changes to add WOPCM condition check to load GuC during resume will be added in later patches.
v2: Rebase w.r.t removal of GuC code restructuring.
v3: Calling intel_uc_resume from i915_gem_resume post resuming i915 gem setup. This is symmetrical with i915_gem_suspend. Removed error messages from i915 suspend/resume routines as uC suspend/resume routines will have those. (Michal Wajdeczko) Declare wedged on uc_suspend failure and uc_resume failure. (Michał Winiarski)
Keeping the uC suspend/resume function definitions close to other uC functions.
v4: Added implementation to intel_uc_resume as GuC resume is needed to be triggered post reloading the firmware as well. Added comments about semantics of GuC resume with the firmware reload.
v5: Updated return from i915_gem_runtime_suspend. Moved the comment about GuC reload optimization to intel_uc_init_hw. (Michal Wajdeczko) Updated FIXME correctly for these comments.
--- drivers/gpu/drm/i915/i915_drv.c | 10 ++++++++++ drivers/gpu/drm/i915/i915_gem.c | 24 +++++++++++++++++++----- drivers/gpu/drm/i915/intel_uc.c | 27 +++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_uc.h | 4 ++++ 4 files changed, 60 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/i915_drv.c +10 -0
@@ -1698,6 +1698,16 @@ static int i915_drm_resume(struct drm_device *dev) }mutex_unlock (&dev->struct_mutex); +/* +* NB: Currently we know that at the end of suspend we have done Full +* GPU reset and GuC is loaded again during i915_gem_init_hw. +* Now, send action to GuC to resume back again as earlier call to +* intel_uc_resume from i915_gem_resume would have done nothing. +*/ + ret =intel_uc_resume (dev_priv); +if (ret) +i915_gem_set_wedged (dev_priv); +intel_modeset_init_hw (dev);spin_lock_irq (&dev_priv->irq_lock);
drivers/gpu/drm/i915/i915_gem.c +19 -5
@@ -2025,9 +2025,11 @@ int i915_gem_fault(struct vm_fault *vmf)int i915_gem_runtime_suspend (struct drm_i915_private *dev_priv) {struct drm_i915_gem_object *obj, *on; -int i; +int i, ret; -intel_guc_suspend (dev_priv); + ret =intel_uc_runtime_suspend (dev_priv); +if (ret) +return ret;/* * Only called during RPM suspend. All users of the userfault_list
@@ -2080,7 +2082,7 @@ void i915_gem_runtime_resume(struct drm_i915_private *dev_priv)i915_gem_init_swizzling (dev_priv);i915_gem_restore_fences (dev_priv); -intel_guc_resume (dev_priv); +intel_uc_runtime_resume (dev_priv); }static int i915_gem_object_create_mmap_offset (struct drm_i915_gem_object *obj)
@@ -4571,7 +4573,9 @@ int i915_gem_suspend(struct drm_i915_private *dev_priv)if (WARN_ON (!intel_engines_are_idle (dev_priv)))i915_gem_set_wedged (dev_priv);/* no hope, discard everything */ -intel_guc_suspend (dev_priv); + ret =intel_uc_suspend (dev_priv); +if (ret) +i915_gem_set_wedged (dev_priv);/* no hope, discard everything */ /* * Neither the BIOS, ourselves or any other kernel
@@ -4606,6 +4610,7 @@ int i915_gem_suspend(struct drm_i915_private *dev_priv)int i915_gem_resume (struct drm_i915_private *dev_priv) {struct drm_device *dev = &dev_priv->drm; +int ret;WARN_ON (dev_priv->gt.awake);
@@ -4619,7 +4624,16 @@ int i915_gem_resume(struct drm_i915_private *dev_priv)*/ dev_priv->gt.resume (dev_priv); -intel_guc_resume (dev_priv); +/* +* FIXME: At the end of suspend, Full GPU reset is done which unloads +* the GuC firmware. If reset is avoided there, we can check the WOPCM +* status here to see if GuC is still loaded and just do GuC resume +* without reloading the firmware back. +*/ + ret =intel_uc_resume (dev_priv); +if (ret) +i915_gem_set_wedged (dev_priv); +mutex_unlock (&dev->struct_mutex);return 0 ;
drivers/gpu/drm/i915/intel_uc.c +27 -0
@@ -373,6 +373,13 @@ int intel_uc_init_hw(struct drm_i915_private *dev_priv) goto err_guc; } +/* +* FIXME: Currently, GuC is loaded unconditionally without checking +* if it is already available in WOPCM (generally available after resume +* from sleep state). We can skip the load based on WOPCM status (To be +* decided based on bit 0 of GUC_WOPCM_SIZE). +*/ +/* init WOPCM */ I915_WRITE (GUC_WOPCM_SIZE ,intel_guc_wopcm_size (dev_priv)); I915_WRITE(DMA_GUC_WOPCM_OFFSET,
@@ -481,6 +488,26 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv)i915_ggtt_disable_guc (dev_priv); } +int intel_uc_runtime_suspend (struct drm_i915_private *dev_priv) +{ +return intel_guc_suspend (dev_priv); +} + +int intel_uc_runtime_resume (struct drm_i915_private *dev_priv) +{ +return intel_guc_resume (dev_priv); +} + +int intel_uc_suspend (struct drm_i915_private *dev_priv) +{ +return intel_guc_suspend (dev_priv); +} + +int intel_uc_resume (struct drm_i915_private *dev_priv) +{ +return intel_guc_resume (dev_priv); +} +int intel_guc_send_nop (struct intel_guc *guc,const u32 *action,u32 len) {WARN (1 ,"Unexpected send: action=%#x\n" , *action);
drivers/gpu/drm/i915/intel_uc.h +4 -0
@@ -208,6 +208,10 @@ struct intel_huc {void intel_uc_fini_fw (struct drm_i915_private *dev_priv);int intel_uc_init_hw (struct drm_i915_private *dev_priv);void intel_uc_fini_hw (struct drm_i915_private *dev_priv); +int intel_uc_runtime_suspend (struct drm_i915_private *dev_priv); +int intel_uc_runtime_resume (struct drm_i915_private *dev_priv); +int intel_uc_suspend (struct drm_i915_private *dev_priv); +int intel_uc_resume (struct drm_i915_private *dev_priv);int intel_guc_sample_forcewake (struct intel_guc *guc);int intel_guc_send_nop (struct intel_guc *guc,const u32 *action,u32 len);int intel_guc_send_mmio (struct intel_guc *guc,const u32 *action,u32 len);
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 5/11 drm/i915/guc: Introduce intel_uc_sanitize
In reply to Sagar Arun KambleCurrently GPU is reset at the end of suspend via i915_gem_sanitize. On resume, GuC will not be loaded until intel_uc_init_hw happens during GEM resume flow but action to exit sleep can be sent to GuC considering the FW load status. To make sure we don't invoke that action update GuC FW load status at the end of GPU reset as NONE. load_status indicates HW state and it is sanitized through this new function intel_uc_sanitize.
v2: Rebase.
v3: Removed intel_guc_sanitize. Marking load status as NONE at the GPU reset point. (Chris/Michal)
v4: Reinstated the uC function intel_uc_sanitize. (Michal Wajdeczko)
--- drivers/gpu/drm/i915/intel_uc.c | 12 ++++++++++++ drivers/gpu/drm/i915/intel_uc.h | 1 + drivers/gpu/drm/i915/intel_uncore.c | 3 +++ 3 files changed, 16 insertions(+)
drivers/gpu/drm/i915/intel_uc.c +12 -0
@@ -508,6 +508,18 @@ int intel_uc_resume(struct drm_i915_private *dev_priv)return intel_guc_resume (dev_priv); } +void intel_uc_sanitize (struct drm_i915_private *dev_priv) +{ +/* +* FIXME: intel_uc_resume currently depends on load_status to resume +* GuC. Since we are resetting Full GPU at the end of suspend, let us +* mark the load status as NONE. Once intel_uc_resume is updated to take +* into consideration GuC load state based on WOPCM, we can skip this +* state update. +*/ + dev_priv->guc.fw.load_status =INTEL_UC_FIRMWARE_NONE ; +} +int intel_guc_send_nop (struct intel_guc *guc,const u32 *action,u32 len) {WARN (1 ,"Unexpected send: action=%#x\n" , *action);
drivers/gpu/drm/i915/intel_uc.h +1 -0
@@ -212,6 +212,7 @@ struct intel_huc {int intel_uc_runtime_resume (struct drm_i915_private *dev_priv);int intel_uc_suspend (struct drm_i915_private *dev_priv);int intel_uc_resume (struct drm_i915_private *dev_priv); +void intel_uc_sanitize (struct drm_i915_private *dev_priv);int intel_guc_sample_forcewake (struct intel_guc *guc);int intel_guc_send_nop (struct intel_guc *guc,const u32 *action,u32 len);int intel_guc_send_mmio (struct intel_guc *guc,const u32 *action,u32 len);
drivers/gpu/drm/i915/intel_uncore.c +3 -0
@@ -1763,6 +1763,9 @@ int intel_gpu_reset(struct drm_i915_private *dev_priv, unsigned engine_mask) }intel_uncore_forcewake_put (dev_priv,FORCEWAKE_ALL ); +if (engine_mask ==ALL_ENGINES ) +intel_uc_sanitize (dev_priv); +return ret; }
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 6/11 drm/i915/guc: Make GuC related disable/destroy functions not depend on i915.enable_guc_submission
In reply to Sagar Arun KambleDuring GuC load/enable, state is setup by driver that can be looked at while disabling. So remove the check for i915.enable_guc_submission parameter in those functions.
--- drivers/gpu/drm/i915/i915_guc_submission.c | 13 ++++++++++--- drivers/gpu/drm/i915/i915_irq.c | 6 ++++++ drivers/gpu/drm/i915/intel_guc_log.c | 6 ++---- drivers/gpu/drm/i915/intel_uc.c | 12 ++++-------- 4 files changed, 22 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/i915_guc_submission.c +10 -3
@@ -1002,7 +1002,8 @@ static int guc_ads_create(struct intel_guc *guc)static void guc_ads_destroy (struct intel_guc *guc) { -i915_vma_unpin_and_release (&guc->ads_vma); +if (guc->ads_vma) +i915_vma_unpin_and_release (&guc->ads_vma); }/*
@@ -1060,11 +1061,14 @@ void i915_guc_submission_fini(struct drm_i915_private *dev_priv) {struct intel_guc *guc = &dev_priv->guc; +WARN_ON_ONCE (!ida_is_empty (&guc->stage_ids));ida_destroy (&guc->stage_ids);guc_ads_destroy (guc);intel_guc_log_destroy (guc); -i915_gem_object_unpin_map (guc->stage_desc_pool->obj); -i915_vma_unpin_and_release (&guc->stage_desc_pool); +if (guc->stage_desc_pool) { +i915_gem_object_unpin_map (guc->stage_desc_pool->obj); +i915_vma_unpin_and_release (&guc->stage_desc_pool); + } }static void guc_interrupts_capture (struct drm_i915_private *dev_priv)
@@ -1204,6 +1208,9 @@ void i915_guc_submission_disable(struct drm_i915_private *dev_priv) {struct intel_guc *guc = &dev_priv->guc; +if (!guc->execbuf_client) +return ; +guc_interrupts_release (dev_priv);/* Revert back to manual ELSP submission */
drivers/gpu/drm/i915/i915_irq.c +6 -0
@@ -455,6 +455,9 @@ void gen9_reset_guc_interrupts(struct drm_i915_private *dev_priv)void gen9_enable_guc_interrupts (struct drm_i915_private *dev_priv) { +if (READ_ONCE (dev_priv->guc.interrupts_enabled)) +return ; +spin_lock_irq (&dev_priv->irq_lock);if (!dev_priv->guc.interrupts_enabled) { WARN_ON_ONCE(I915_READ(gen6_pm_iir(dev_priv)) &
@@ -467,6 +470,9 @@ void gen9_enable_guc_interrupts(struct drm_i915_private *dev_priv)void gen9_disable_guc_interrupts (struct drm_i915_private *dev_priv) { +if (!READ_ONCE (dev_priv->guc.interrupts_enabled)) +return ; +spin_lock_irq (&dev_priv->irq_lock); dev_priv->guc.interrupts_enabled = false;
drivers/gpu/drm/i915/intel_guc_log.c +2 -4
@@ -584,7 +584,8 @@ int intel_guc_log_create(struct intel_guc *guc)void intel_guc_log_destroy (struct intel_guc *guc) {guc_log_runtime_destroy (guc); -i915_vma_unpin_and_release (&guc->log.vma); +if (guc->log.vma) +i915_vma_unpin_and_release (&guc->log.vma); }int i915_guc_log_control (struct drm_i915_private *dev_priv,u64 control_val)
@@ -653,9 +654,6 @@ void i915_guc_log_register(struct drm_i915_private *dev_priv)void i915_guc_log_unregister (struct drm_i915_private *dev_priv) { -if (!i915_modparams.enable_guc_submission) -return ; -mutex_lock (&dev_priv->drm.struct_mutex);/* GuC logging is currently the only user of Guc2Host interrupts */ gen9_disable_guc_interrupts (dev_priv);
drivers/gpu/drm/i915/intel_uc.c +4 -8
@@ -445,8 +445,7 @@ int intel_uc_init_hw(struct drm_i915_private *dev_priv) err_log_capture:guc_capture_load_err_log (guc); err_submission: -if (i915_modparams.enable_guc_submission) -i915_guc_submission_fini (dev_priv); +i915_guc_submission_fini (dev_priv); err_guc:i915_ggtt_disable_guc (dev_priv);
@@ -475,15 +474,12 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv)if (!i915_modparams.enable_guc_loading)return ; -if (i915_modparams.enable_guc_submission) -i915_guc_submission_disable (dev_priv); +i915_guc_submission_disable (dev_priv);guc_disable_communication (&dev_priv->guc); -if (i915_modparams.enable_guc_submission) { -gen9_disable_guc_interrupts (dev_priv); -i915_guc_submission_fini (dev_priv); - } +gen9_disable_guc_interrupts (dev_priv); +i915_guc_submission_fini (dev_priv);i915_ggtt_disable_guc (dev_priv); }
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 7/11 drm/i915/guc: Update i915.enable_guc_loading check in intel_uc_fini_hw
In reply to Sagar Arun KambleWith most of the GuC disabling now separated from enable_guc_submission parameter, only function that needs GuC parameter check is i915_disable_guc_ggtt as that is enabled based on GuC kernel parameters. Hence i915_disable_guc_ggtt is being called when enable_guc_loading is set.
--- drivers/gpu/drm/i915/intel_uc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_uc.c +2 -4
@@ -471,9 +471,6 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv) {guc_free_load_err_log (&dev_priv->guc); -if (!i915_modparams.enable_guc_loading) -return ; -i915_guc_submission_disable (dev_priv);guc_disable_communication (&dev_priv->guc);
@@ -481,7 +478,8 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv)gen9_disable_guc_interrupts (dev_priv);i915_guc_submission_fini (dev_priv); -i915_ggtt_disable_guc (dev_priv); +if (i915_modparams.enable_guc_loading) +i915_ggtt_disable_guc (dev_priv); }int intel_uc_runtime_suspend (struct drm_i915_private *dev_priv)
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 8/11 drm/i915/guc: Update GuC ggtt.invalidate/interrupts/communication across RPM suspend/resume
In reply to Sagar Arun KambleApart from configuring interrupts, we need to update the ggtt invalidate interface and GuC communication on suspend/resume. This functionality can be reused for other suspend and reset paths.
v2: Rebase w.r.t removal of GuC code restructuring.
v3: Removed GuC specific helpers as tasks other than send H2G for sleep/resume are to be done from uc generic functions. (Michal Wajdeczko)
v4: Simplified/Unified the error messaging in uc_runtime_suspend/resume. (Michal Wajdeczko). Rebase w.r.t i915_modparams change. Added documentation to intel_uc_runtime_suspend/resume.
v5: Removed enable_guc_loading based check from intel_uc_runtime_suspend and intel_uc_runtime_resume and pulled FW load_status based checks from intel_guc_suspend/resume into these functions. (Michal Wajdeczko)
--- drivers/gpu/drm/i915/i915_guc_submission.c | 11 ------ drivers/gpu/drm/i915/intel_uc.c | 60 +++++++++++++++++++++++++++++- 2 files changed, 58 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/i915_guc_submission.c +0 -11
@@ -1230,11 +1230,6 @@ int intel_guc_suspend(struct drm_i915_private *dev_priv)struct i915_gem_context *ctx;u32 data[3 ]; -if (guc->fw.load_status !=INTEL_UC_FIRMWARE_SUCCESS ) -return 0 ; - -gen9_disable_guc_interrupts (dev_priv); - ctx = dev_priv->kernel_context; data[0 ] =INTEL_GUC_ACTION_ENTER_S_STATE ;
@@ -1256,12 +1251,6 @@ int intel_guc_resume(struct drm_i915_private *dev_priv)struct i915_gem_context *ctx;u32 data[3 ]; -if (guc->fw.load_status !=INTEL_UC_FIRMWARE_SUCCESS ) -return 0 ; - -if (i915_modparams.guc_log_level >=0 ) -gen9_enable_guc_interrupts (dev_priv); - ctx = dev_priv->kernel_context; data[0 ] =INTEL_GUC_ACTION_EXIT_S_STATE ;
drivers/gpu/drm/i915/intel_uc.c +58 -2
72 lines not on this page · raw message
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 9/11 drm/i915/guc: Update GuC suspend functionality in intel_uc_suspend
In reply to Sagar Arun KambleWith this patch we disable GuC submission in i915_drm_suspend path. This will destroy the client which will be setup back again. We also reuse the complete sanitization done via intel_uc_runtime_suspend in this path. Post i915_drm_resume, this state is recreated by intel_uc_init_hw hence we need not have similar reuse for intel_uc_resume. This also fixes issue where intel_uc_fini_hw was being called after GPU reset happening in i915_gem_suspend during i915_driver_unload.
v2: Rebase w.r.t removal of GuC code restructuring. Added struct_mutex protection for i915_guc_submission_disable.
v3: Rebase w.r.t updated GuC suspend function name.
v4: Added lockdep assert in i915_guc_submission_enable/disable. Refined intel_uc_suspend to remove unnecessary locals and simplify return. (Michal Winiarski)
Removed comment in guc_client_free about ignoring failure for destroy_doorbell. (Oscar)
Rebase w.r.t i915_modparams change.
v5: Removed lockdep assert as mutex is needed by internal functions which already have the asserts. (Chris)
Removed enable_guc_submission check for disabling GuC submission. (Chris)
v6: Rebase with enable_guc_submission related change done in earlier newly introduced patches.
--- drivers/gpu/drm/i915/i915_guc_submission.c | 3 --- drivers/gpu/drm/i915/intel_uc.c | 8 +++++--- 2 files changed, 5 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/i915_guc_submission.c +0 -3
@@ -885,9 +885,6 @@ static void guc_client_free(struct i915_guc_client *client)* Be sure to drop any locks */ -/* FIXME: in many cases, by the time we get here the GuC has been -* reset, so we cannot destroy the doorbell properly. Ignore the -* error message for now */ destroy_doorbell (client);guc_stage_desc_fini (client->guc, client);i915_gem_object_unpin_map (client->vma->obj);
drivers/gpu/drm/i915/intel_uc.c +5 -3
@@ -471,8 +471,6 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv) {guc_free_load_err_log (&dev_priv->guc); -i915_guc_submission_disable (dev_priv); -guc_disable_communication (&dev_priv->guc);gen9_disable_guc_interrupts (dev_priv);
@@ -550,7 +548,11 @@ int intel_uc_runtime_resume(struct drm_i915_private *dev_priv)int intel_uc_suspend (struct drm_i915_private *dev_priv) { -return intel_guc_suspend (dev_priv); +mutex_lock (&dev_priv->drm.struct_mutex); +i915_guc_submission_disable (dev_priv); +mutex_unlock (&dev_priv->drm.struct_mutex); + +return intel_uc_runtime_suspend (dev_priv); }int intel_uc_resume (struct drm_i915_private *dev_priv)
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 10/11 drm/i915/guc: Disable GuC submission and suspend it prior to i915 reset
In reply to Sagar Arun KambleBefore i915 reset, we need to disable GuC submission and suspend GuC operations as it is recreated during intel_uc_init_hw. We can't reuse the intel_uc_suspend functionality as reset path already holds struct_mutex.
v2: Rebase w.r.t removal of GuC code restructuring. Updated reset_prepare function as struct_mutex is not needed.
v3: Fixed typo in commit message. Made return from intel_uc_reset_prepare simpler. (Michal)
Rebase w.r.t i915_modparams change.
v4: Rebase. Removed enable_guc_submission check for disabling GuC submission. (Chris)
v5: Rebase.
--- drivers/gpu/drm/i915/i915_gem.c | 2 ++ drivers/gpu/drm/i915/intel_uc.c | 7 +++++++ drivers/gpu/drm/i915/intel_uc.h | 1 + 3 files changed, 10 insertions(+)
drivers/gpu/drm/i915/i915_gem.c +2 -0
@@ -2865,6 +2865,8 @@ int i915_gem_reset_prepare(struct drm_i915_private *dev_priv)i915_gem_revoke_fences (dev_priv); +intel_uc_reset_prepare (dev_priv); +return err; }
drivers/gpu/drm/i915/intel_uc.c +7 -0
@@ -572,6 +572,13 @@ void intel_uc_sanitize(struct drm_i915_private *dev_priv) dev_priv->guc.fw.load_status =INTEL_UC_FIRMWARE_NONE ; } +int intel_uc_reset_prepare (struct drm_i915_private *dev_priv) +{ +i915_guc_submission_disable (dev_priv); + +return intel_uc_runtime_suspend (dev_priv); +} +int intel_guc_send_nop (struct intel_guc *guc,const u32 *action,u32 len) {WARN (1 ,"Unexpected send: action=%#x\n" , *action);
drivers/gpu/drm/i915/intel_uc.h +1 -0
@@ -212,6 +212,7 @@ struct intel_huc {int intel_uc_runtime_resume (struct drm_i915_private *dev_priv);int intel_uc_suspend (struct drm_i915_private *dev_priv);int intel_uc_resume (struct drm_i915_private *dev_priv); +int intel_uc_reset_prepare (struct drm_i915_private *dev_priv);void intel_uc_sanitize (struct drm_i915_private *dev_priv);int intel_guc_sample_forcewake (struct intel_guc *guc);int intel_guc_send_nop (struct intel_guc *guc,const u32 *action,u32 len);
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 11/11 drm/i915/guc: Fix GuC cleanup in unload path
In reply to Sagar Arun KambleWe ensure that GuC is completely suspended and client is destroyed in i915_gem_suspend during i915_driver_unload. So now intel_uc_fini_hw should just take care of cleanup,
hence s/intel_uc_fini_hw/intel_uc_cleanup. Correspondingly
we also updated as s/i915_guc_submission_fini/i915_guc_submission_cleanup Other functionality to disable communication, disable interrupts and update of ggtt.invalidate is taken care by intel_uc_suspend.
v2: Rebase w.r.t removal of GuC code restructuring.
v3: Removed intel_guc_cleanup. (Michal Wajdeczko)
v4: guc_free_load_err_log() needs to be called without checking i915.enable_guc_loading as this param is cleared on GuC load failure. (Michal Wajdeczko)
v5. Rebase.
--- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_guc_submission.c | 2 +- drivers/gpu/drm/i915/intel_uc.c | 12 +++--------- drivers/gpu/drm/i915/intel_uc.h | 4 ++-- 4 files changed, 7 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/i915_drv.c +1 -1
@@ -603,7 +603,7 @@ static void i915_gem_fini(struct drm_i915_private *dev_priv)i915_gem_drain_workqueue (dev_priv);mutex_lock (&dev_priv->drm.struct_mutex); -intel_uc_fini_hw (dev_priv); +intel_uc_cleanup (dev_priv);i915_gem_cleanup_engines (dev_priv);i915_gem_contexts_fini (dev_priv);i915_gem_cleanup_userptr (dev_priv);
drivers/gpu/drm/i915/i915_guc_submission.c +1 -1
@@ -1054,7 +1054,7 @@ int i915_guc_submission_init(struct drm_i915_private *dev_priv)return ret; } -void i915_guc_submission_fini (struct drm_i915_private *dev_priv) +void i915_guc_submission_cleanup (struct drm_i915_private *dev_priv) {struct intel_guc *guc = &dev_priv->guc;
drivers/gpu/drm/i915/intel_uc.c +3 -9
@@ -445,7 +445,7 @@ int intel_uc_init_hw(struct drm_i915_private *dev_priv) err_log_capture:guc_capture_load_err_log (guc); err_submission: -i915_guc_submission_fini (dev_priv); +i915_guc_submission_cleanup (dev_priv); err_guc:i915_ggtt_disable_guc (dev_priv);
@@ -467,17 +467,11 @@ int intel_uc_init_hw(struct drm_i915_private *dev_priv)return ret; } -void intel_uc_fini_hw (struct drm_i915_private *dev_priv) +void intel_uc_cleanup (struct drm_i915_private *dev_priv) {guc_free_load_err_log (&dev_priv->guc); -guc_disable_communication (&dev_priv->guc); - -gen9_disable_guc_interrupts (dev_priv); -i915_guc_submission_fini (dev_priv); - -if (i915_modparams.enable_guc_loading) -i915_ggtt_disable_guc (dev_priv); +i915_guc_submission_cleanup (dev_priv); }/**
drivers/gpu/drm/i915/intel_uc.h +2 -2
@@ -207,7 +207,7 @@ struct intel_huc {void intel_uc_init_fw (struct drm_i915_private *dev_priv);void intel_uc_fini_fw (struct drm_i915_private *dev_priv);int intel_uc_init_hw (struct drm_i915_private *dev_priv); -void intel_uc_fini_hw (struct drm_i915_private *dev_priv); +void intel_uc_cleanup (struct drm_i915_private *dev_priv);int intel_uc_runtime_suspend (struct drm_i915_private *dev_priv);int intel_uc_runtime_resume (struct drm_i915_private *dev_priv);int intel_uc_suspend (struct drm_i915_private *dev_priv);
@@ -240,7 +240,7 @@ static inline void intel_guc_notify(struct intel_guc *guc)int i915_guc_submission_init (struct drm_i915_private *dev_priv);int i915_guc_submission_enable (struct drm_i915_private *dev_priv);void i915_guc_submission_disable (struct drm_i915_private *dev_priv); -void i915_guc_submission_fini (struct drm_i915_private *dev_priv); +void i915_guc_submission_cleanup (struct drm_i915_private *dev_priv);struct i915_vma *intel_guc_allocate_vma (struct intel_guc *guc,u32 size);/* intel_guc_log.c */
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for GEM/GuC Suspend/Resume/Reset fixes and restructuring (rev4)
In reply to Sagar Arun Kamble== Series Details ==
== Series Details ==
Series: GEM/GuC Suspend/Resume/Reset fixes and restructuring (rev4)
URL : https://patchwork.freedesktop.org/series/30802/
State : failure
== Summary ==
Series 30802v4 GEM/GuC Suspend/Resume/Reset fixes and restructuring
https://patchwork.freedesktop.org/api/1.0/series/30802/revisions/4/mbox/
Test chamelium:
Subgroup dp-crc-fast:
pass -> FAIL (fi-kbl-7500u) fdo#102514
Subgroup common-hpd-after-suspend:
pass -> INCOMPLETE (fi-skl-6700k)
dmesg-warn -> INCOMPLETE (fi-kbl-7500u) fdo#102505
Test gem_exec_suspend:
Subgroup basic-s3:
pass -> INCOMPLETE (fi-blb-e6850)
pass -> INCOMPLETE (fi-pnv-d510)
pass -> INCOMPLETE (fi-elk-e7500)
pass -> INCOMPLETE (fi-ilk-650)
pass -> SKIP (fi-snb-2520m)
pass -> SKIP (fi-snb-2600) fdo#102365
pass -> SKIP (fi-ivb-3520m)
pass -> SKIP (fi-ivb-3770)
pass -> SKIP (fi-byt-j1900)
pass -> SKIP (fi-hsw-4770)
pass -> SKIP (fi-hsw-4770r)
pass -> INCOMPLETE (fi-bdw-5557u)
pass -> INCOMPLETE (fi-bdw-gvtdvm)
pass -> SKIP (fi-bsw-n3050)
pass -> INCOMPLETE (fi-skl-6260u)
pass -> INCOMPLETE (fi-skl-6770hq)
pass -> INCOMPLETE (fi-skl-gvtdvm)
pass -> INCOMPLETE (fi-bxt-j4205)
pass -> INCOMPLETE (fi-kbl-7560u)
pass -> INCOMPLETE (fi-kbl-r) fdo#102850
pass -> INCOMPLETE (fi-glk-1)
pass -> INCOMPLETE (fi-cfl-s)
Subgroup basic-s4-devices:
pass -> SKIP (fi-snb-2520m)
pass -> SKIP (fi-snb-2600)
pass -> SKIP (fi-ivb-3520m)
pass -> SKIP (fi-ivb-3770)
pass -> SKIP (fi-byt-j1900)
pass -> SKIP (fi-hsw-4770)
pass -> SKIP (fi-hsw-4770r)
pass -> SKIP (fi-bsw-n3050)
Test gem_linear_blits:
Subgroup basic:
pass -> SKIP (fi-snb-2520m)
pass -> SKIP (fi-snb-2600)
pass -> SKIP (fi-ivb-3520m)
pass -> SKIP (fi-ivb-3770)
pass -> SKIP (fi-byt-j1900)
pass -> SKIP (fi-hsw-4770)
pass -> SKIP (fi-hsw-4770r)
pass -> SKIP (fi-bsw-n3050)
Test gem_render_linear_blits:
Subgroup basic:
pass -> SKIP (fi-snb-2520m)
pass -> SKIP (fi-snb-2600)
pass -> SKIP (fi-ivb-3520m)
pass -> SKIP (fi-ivb-3770)
pass -> SKIP (fi-byt-j1900)
pass -> SKIP (fi-hsw-4770)
pass -> SKIP (fi-hsw-4770r)
pass -> SKIP (fi-bsw-n3050)
Test gem_render_tiled_blits:
Subgroup basic:
pass -> SKIP (fi-snb-2520m)
pass -> SKIP (fi-snb-2600)
pass -> SKIP (fi-ivb-3520m)
pass -> SKIP (fi-ivb-3770)
pass -> SKIP (fi-byt-j1900)
pass -> SKIP (fi-hsw-4770)
pass -> SKIP (fi-hsw-4770r)
pass -> SKIP (fi-bsw-n3050)
Test gem_ringfill:
Subgroup basic-default:
pass -> SKIP (fi-snb-2520m)
pass -> SKIP (fi-snb-2600)
pass -> SKIP (fi-ivb-3520m)
pass -> SKIP (fi-ivb-3770)
pass -> SKIP (fi-byt-j1900)
pass -> SKIP (fi-hsw-4770)
pass -> SKIP (fi-hsw-4770r)
pass -> SKIP (fi-bsw-n3050)
Subgroup basic-default-interruptible:
pass -> SKIP (fi-snb-2520m)
pass -> SKIP (fi-snb-2600)
pass -> SKIP (fi-ivb-3520m)
pass -> SKIP (fi-ivb-3770)
pass -> SKIP (fi-byt-j1900)
pass -> SKIP (fi-hsw-4770)
pass -> SKIP (fi-hsw-4770r)
pass -> SKIP (fi-bsw-n3050)
Subgroup basic-default-forked:
pass -> SKIP (fi-snb-2520m)
pass -> SKIP (fi-snb-2600)
pass -> SKIP (fi-ivb-3520m)
pass -> SKIP (fi-ivb-3770)
pass -> SKIP (fi-byt-j1900)
pass -> SKIP (fi-hsw-4770)
pass -> SKIP (fi-hsw-4770r)
pass -> SKIP (fi-bsw-n3050)WARNING: Long output truncated
7f93222785e4887c083c85b76fcbb391bb1991d9 drm-tip: 2017y-09m-27d-20h-05m-25s UTC integration manifest defe659da3ab drm/i915/guc: Fix GuC cleanup in unload path38870ed3e95e drm/i915/guc: Disable GuC submission and suspend it prior to i915 reset 1cda0765dbb3 drm/i915/guc: Update GuC suspend functionality in intel_uc_suspendeb3707100725 drm/i915/guc: Update GuC ggtt.invalidate/interrupts/communication across RPM suspend/resume 708a4eba0a88 drm/i915/guc: Update i915.enable_guc_loading check in intel_uc_fini_hw 2d86b722fb51 drm/i915/guc: Make GuC related disable/destroy functions not depend on i915.enable_guc_submission 0022e560a7a4 drm/i915/guc: Introduce intel_uc_sanitizeb5932c2a46c1 drm/i915: Create uC runtime and system suspend/resume helpersa3755907a5be drm/i915: Move i915_gem_restore_fences to i915_gem_resumea8cc88acc89e drm/i915: Update GEM suspend/resume flows with GuC suspend/resume functions 131832f3ede6 drm/i915: Create GEM runtime resume helper and handle GEM suspend/resume errors
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5842/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx