Skip to contentSkip to conversation

default-configs: Enable CONFIG_VMXNET3_PCI only on x86

PATCH In review Thomas Huth 2 participants 2 messages Sep 28, 2017

lore
Share & tools
lore

Thomas Huth

author
#0 lore raw

PATCH 1/1 default-configs: Enable CONFIG_VMXNET3_PCI only on x86

The device can not be instantiated on many non-x86 and just prints some error messages, e.g.:

$ qemu-system-ppc64 -device vmxnet3 -M g3beige
[vmxnet3][WR][vmxnet3_init_msix]: Failed to initialize MSI-X, error -95
[vmxnet3][WR][vmxnet3_pci_realize]: Failed to initialize MSI-X, configuration is inconsistent.

Since vmxnet3 is a para-virtualized device that is only useful on x86, it should also only be enabled on the x86 targets.

Signed-off-by Thomas Huth <[email protected]>
---
 default-configs/i386-softmmu.mak   | 1 +
 default-configs/pci.mak            | 1 -
 default-configs/x86_64-softmmu.mak | 1 +
 3 files changed, 2 insertions(+), 1 deletion(-)
default-configs/i386-softmmu.mak +1 -0
index d2ab2f6..a685c43 100644
@@ -7,6 +7,7 @@ CONFIG_QXL=$(CONFIG_SPICE)
 CONFIG_VGA_ISA=y
 CONFIG_VGA_CIRRUS=y
 CONFIG_VMWARE_VGA=y
+CONFIG_VMXNET3_PCI=y
 CONFIG_VIRTIO_VGA=y
 CONFIG_VMMOUSE=y
 CONFIG_IPMI=y
default-configs/pci.mak +0 -1
index 187e438..e514bde 100644
@@ -22,7 +22,6 @@ CONFIG_MPTSAS_SCSI_PCI=y
 CONFIG_RTL8139_PCI=y
 CONFIG_E1000_PCI=y
 CONFIG_E1000E_PCI=y
-CONFIG_VMXNET3_PCI=y
 CONFIG_IDE_CORE=y
 CONFIG_IDE_QDEV=y
 CONFIG_IDE_PCI=y
default-configs/x86_64-softmmu.mak +1 -0
index 9bde2f1..ea69e82 100644
@@ -7,6 +7,7 @@ CONFIG_QXL=$(CONFIG_SPICE)
 CONFIG_VGA_ISA=y
 CONFIG_VGA_CIRRUS=y
 CONFIG_VMWARE_VGA=y
+CONFIG_VMXNET3_PCI=y
 CONFIG_VIRTIO_VGA=y
 CONFIG_VMMOUSE=y
 CONFIG_IPMI=y
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Thomas Huth

The device can not be instantiated on many non-x86 and just prints some error messages, e.g.:

Quoted 7 lines
$ qemu-system-ppc64 -device vmxnet3 -M g3beige
[vmxnet3][WR][vmxnet3_init_msix]: Failed to initialize MSI-X, error -95
[vmxnet3][WR][vmxnet3_pci_realize]: Failed to initialize MSI-X, configuration is inconsistent.

Since vmxnet3 is a para-virtualized device that is only useful on x86, it should also only be enabled on the x86 targets.

Reviewed-by Dmitry Fleytman <[email protected]>
Quoted 46 lines
Signed-off-by Thomas Huth <[email protected]>

---

default-configs/i386-softmmu.mak   | 1 +
default-configs/pci.mak            | 1 -
default-configs/x86_64-softmmu.mak | 1 +
3 files changed, 2 insertions(+), 1 deletion(-)
default-configs/i386-softmmu.mak +0 -0
index d2ab2f6..a685c43 100644
@@ -7,6 +7,7 @@ CONFIG_QXL=$(CONFIG_SPICE)

CONFIG_VGA_ISA=y
CONFIG_VGA_CIRRUS=y
CONFIG_VMWARE_VGA=y
+CONFIG_VMXNET3_PCI=y
CONFIG_VIRTIO_VGA=y
CONFIG_VMMOUSE=y
CONFIG_IPMI=y

default-configs/pci.mak +0 -0
index 187e438..e514bde 100644
@@ -22,7 +22,6 @@ CONFIG_MPTSAS_SCSI_PCI=y

CONFIG_RTL8139_PCI=y
CONFIG_E1000_PCI=y
CONFIG_E1000E_PCI=y
-CONFIG_VMXNET3_PCI=y
CONFIG_IDE_CORE=y
CONFIG_IDE_QDEV=y
CONFIG_IDE_PCI=y

default-configs/x86_64-softmmu.mak +0 -0
index 9bde2f1..ea69e82 100644
@@ -7,6 +7,7 @@ CONFIG_QXL=$(CONFIG_SPICE)

CONFIG_VGA_ISA=y
CONFIG_VGA_CIRRUS=y
CONFIG_VMWARE_VGA=y
+CONFIG_VMXNET3_PCI=y
CONFIG_VIRTIO_VGA=y
CONFIG_VMMOUSE=y
CONFIG_IPMI=y

Signature · 1 line
1.8.3.1