Skip to contentSkip to conversation

Patch "cifs: release cifs root_cred after exit_cifs" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Sep 28, 2017 Stable branch

lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

cifs: release cifs root_cred after exit_cifs

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
cifs-release-cifs-root_cred-after-exit_cifs.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 94183331e815617246b1baa97e0916f358c794bb Mon Sep 17 00:00:00 2001

From: Shu Wang <[email protected]>
Date: Thu, 7 Sep 2017 16:03:27 +0800
Subject: cifs: release cifs root_cred after exit_cifs

From: Shu Wang <[email protected]>

commit 94183331e815617246b1baa97e0916f358c794bb upstream.

memory leak was found by kmemleak. exit_cifs_spnego should be called before cifs module removed, or cifs root_cred will not be released.

kmemleak report:
unreferenced object 0xffff880070a3ce40 (size 192):
backtrace:

     kmemleak_alloc+0x4a/0xa0
     kmem_cache_alloc+0xc7/0x1d0
     prepare_kernel_cred+0x20/0x120
     init_cifs_spnego+0x2d/0x170 [cifs]
     0xffffffffc07801f3
     do_one_initcall+0x51/0x1b0
     do_init_module+0x60/0x1fd
     load_module+0x161e/0x1b60
     SYSC_finit_module+0xa9/0x100
     SyS_finit_module+0xe/0x10
---
 fs/cifs/cifsfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/cifs/cifsfs.c +1 -1
@@ -1360,7 +1360,7 @@ exit_cifs(void)
 	exit_cifs_idmap();
 #endif
 #ifdef CONFIG_CIFS_UPCALL
-	unregister_key_type(&cifs_spnego_key_type);
+	exit_cifs_spnego();
 #endif
 	cifs_destroy_request_bufs();
 	cifs_destroy_mids();

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/cifs-release-cifs-root_cred-after-exit_cifs.patch queue-4.9/cifs-release-auth_key.response-for-reconnect.patch