Skip to contentSkip to conversation

Add python pandas recipes

PATCH In review Guy Morand 3 participants 4 messages Sep 29, 2017 – Oct 3, 2017

lore
Share & tools
lore

Guy Morand

author
#0 lore raw

PATCH 1/1 Add python pandas recipes

---
 .../recipes-devtools/python/python-pandas.inc       | 21 +++++++++++++++++++++
 .../recipes-devtools/python/python-pandas_0.20.3.bb | 10 ++++++++++
 .../python/python3-pandas_0.20.3.bb                 |  5 +++++
 3 files changed, 36 insertions(+)
 create mode 100644 meta-python/recipes-devtools/python/python-pandas.inc
 create mode 100644 meta-python/recipes-devtools/python/python-pandas_0.20.3.bb
 create mode 100644 meta-python/recipes-devtools/python/python3-pandas_0.20.3.bb
meta-python/recipes-devtools/python/python-pandas.inc new file +21 -0
new file mode 100644
index 0000000..9ca3806
@@ -0,0 +1,21 @@
+SUMMARY  = "pandas library for high-performance data analysis tools"
+DESCRIPTION = "pandas is an open source, BSD-licensed library providing \
+high-performance, easy-to-use data structures and data analysis tools for \
+the Python programming language."
+HOMEPAGE = "http://pandas.pydata.org/"
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=66017d3134349017409386be85176145"
+
+PYPI_PACKAGE = "pandas"
+
+inherit pypi
+
+DEPENDS += " \
+  ${PYTHON_PN}-numpy-native \
+  "
+
+RDEPENDS_${PN} += " \
+  ${PYTHON_PN}-numpy \
+  ${PYTHON_PN}-dateutil \
+  ${PYTHON_PN}-pytz \
+  "
meta-python/recipes-devtools/python/python-pandas_0.20.3.bb new file +10 -0
new file mode 100644
index 0000000..f4c486b
@@ -0,0 +1,10 @@
+inherit setuptools
+require python-pandas.inc
+
+RDEPENDS_${PN} += " \
+  ${PYTHON_PN}-json \
+  ${PYTHON_PN}-importlib \
+  "
+
+SRC_URI[md5sum] = "4df858f28b4bf4fa07d9fbb7f2568173"
+SRC_URI[sha256sum] = "a777e07633d83d546c55706420179551c8e01075b53c497dcf8ae4036766bc66"
meta-python/recipes-devtools/python/python3-pandas_0.20.3.bb new file +5 -0
new file mode 100644
index 0000000..81dd360
@@ -0,0 +1,5 @@
+inherit setuptools3
+require python-pandas.inc
+
+SRC_URI[md5sum] = "4df858f28b4bf4fa07d9fbb7f2568173"
+SRC_URI[sha256sum] = "a777e07633d83d546c55706420179551c8e01075b53c497dcf8ae4036766bc66"
Signature · 1 line
2.7.4
#1 lore raw
Quoted 11 lines · Guy Morand

—
<snip>

meta-python/recipes-devtools/python/python-pandas_0.20.3.bb new file +0 -0
new file mode 100644
index 0000000..f4c486b

meta-python/recipes-devtools/python/python-pandas_0.20.3.bb line 10

Quoted 10 lines
meta-python/recipes-devtools/python/python-pandas_0.20.3.bb new file +10 -0
@@ -0,0 +1,10 @@
+inherit setuptools
+require python-pandas.inc
+
+RDEPENDS_${PN} += " \
+  ${PYTHON_PN}-json \
+  ${PYTHON_PN}-importlib \
+  "
+
+SRC_URI[md5sum] = "4df858f28b4bf4fa07d9fbb7f2568173"
+SRC_URI[sha256sum] = “a777e07633d83d546c55706420179551c8e01075b53c497dcf8ae4036766bc66"

These SRC_URI checksum lines should go in the python-pandas.inc file, rather than duplicate them in both the python-pandas and python3-pandas files.

It is quite common now for the “version specific” files to only be the “inherit” line and the “require foo.inc” line.

DRY and KISS.

Quoted 19 lines
meta-python/recipes-devtools/python/python3-pandas_0.20.3.bb new file +5 -0
new file mode 100644
index 0000000..81dd360
@@ -0,0 +1,5 @@
+inherit setuptools3
+require python-pandas.inc
+
+SRC_URI[md5sum] = "4df858f28b4bf4fa07d9fbb7f2568173"
+SRC_URI[sha256sum] = "a777e07633d83d546c55706420179551c8e01075b53c497dcf8ae4036766bc66"
Signature · 7 lines
2.7.4

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
#2 lore raw

Also missing Signed-off-by line.

Quoted 62 lines · Tim Orling

Review

Quoted 6 lines · Guy Morand

—
<snip>

(quoted diff) +0 -0

b/meta-python/recipes-devtools/python/python-pandas_0.20.3.bb

Quoted 5 lines

new file mode 100644
index 0000000..f4c486b

meta-python/recipes-devtools/python/python-pandas_0.20.3.bb line 10

Quoted 10 lines
meta-python/recipes-devtools/python/python-pandas_0.20.3.bb new file +10 -0
@@ -0,0 +1,10 @@
+inherit setuptools
+require python-pandas.inc
+
+RDEPENDS_${PN} += " \
+  ${PYTHON_PN}-json \
+  ${PYTHON_PN}-importlib \
+  "
+
+SRC_URI[md5sum] = "4df858f28b4bf4fa07d9fbb7f2568173"
+SRC_URI[sha256sum] = “a777e07633d83d546c557064201795

51c8e01075b53c497dcf8ae4036766bc66"

These SRC_URI checksum lines should go in the python-pandas.inc file, rather than duplicate them in both the python-pandas and python3-pandas files.

It is quite common now for the “version specific” files to only be the “inherit” line and the “require foo.inc” line.

DRY and KISS.

Review

Quoted 1 line
(quoted diff) +0 -0

pandas_0.20.3.bb b/meta-python/recipes-devtools/python/python3- pandas_0.20.3.bb

meta-python/recipes-devtools/python/python3-pandas_0.20.3.bb line 5

Quoted 10 lines

new file mode 100644
index 0000000..81dd360

meta-python/recipes-devtools/python/python3-pandas_0.20.3.bb new file +5 -0
@@ -0,0 +1,5 @@
+inherit setuptools3
+require python-pandas.inc
+
+SRC_URI[md5sum] = "4df858f28b4bf4fa07d9fbb7f2568173"
+SRC_URI[sha256sum] = "a777e07633d83d546c557064201795

51c8e01075b53c497dcf8ae4036766bc66"

Quoted 8 lines

--
2.7.4

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

author
#3 lore raw

Hi,

Thanks for reviwing my patch, almost there! still learning community conventions :p!

My arguments for md5sums was if the PV changes, I guess both recipes will have to be updated. Since it's DRYer and other recipes are made this way, I will fix it!

"-s" never hurts!

I hope the third attempt will be the good one!

Regards,

Guy

Quoted 77 lines · Martin Jansa

Also missing Signed-off-by line.

On Fri, Sep 29, 2017 at 7:37 PM, Tim Orling <[email protected] <mailto:[email protected]>> wrote:

     > On Sep 29, 2017, at 1:26 AM, Guy Morand <[email protected]
    <mailto:[email protected]>> wrote:
     >
     > —
     > <snip>
    > diff --git a/meta-python/recipes-devtools/python/python-pandas_0.20.3.bb
    <http://python-pandas_0.20.3.bb>
    b/meta-python/recipes-devtools/python/python-pandas_0.20.3.bb
    <http://python-pandas_0.20.3.bb>
    > new file mode 100644
    > index 0000000..f4c486b
    > --- /dev/null
    > +++ b/meta-python/recipes-devtools/python/python-pandas_0.20.3.bb <http://python-pandas_0.20.3.bb>
    > @@ -0,0 +1,10 @@
    > +inherit setuptools
    > +require python-pandas.inc
    > +
    > +RDEPENDS_${PN} += " \
    > +  ${PYTHON_PN}-json \
    > +  ${PYTHON_PN}-importlib \
    > +  "
    > +
    > +SRC_URI[md5sum] = "4df858f28b4bf4fa07d9fbb7f2568173"
    > +SRC_URI[sha256sum] = “a777e07633d83d546c55706420179551c8e01075b53c497dcf8ae4036766bc66"

    These SRC_URI checksum lines should go in the python-pandas.inc
    file, rather than duplicate them in both the python-pandas and
    python3-pandas files.

    It is quite common now for the “version specific” files to only be
    the “inherit” line and the “require foo.inc” line.

    DRY and KISS.

     > diff --git
    a/meta-python/recipes-devtools/python/python3-pandas_0.20.3.bb
    <http://python3-pandas_0.20.3.bb>
    b/meta-python/recipes-devtools/python/python3-pandas_0.20.3.bb
    <http://python3-pandas_0.20.3.bb>
     > new file mode 100644
     > index 0000000..81dd360
     > --- /dev/null
     > +++
    b/meta-python/recipes-devtools/python/python3-pandas_0.20.3.bb
    <http://python3-pandas_0.20.3.bb>
     > @@ -0,0 +1,5 @@
     > +inherit setuptools3
     > +require python-pandas.inc
     > +
     > +SRC_URI[md5sum] = "4df858f28b4bf4fa07d9fbb7f2568173"
     > +SRC_URI[sha256sum] =
    "a777e07633d83d546c55706420179551c8e01075b53c497dcf8ae4036766bc66"
     > --
     > 2.7.4
     >
     > --
     > _______________________________________________
     > Openembedded-devel mailing list
     > [email protected]
    <mailto:[email protected]>
     > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
    <http://lists.openembedded.org/mailman/listinfo/openembedded-devel>

    --
    _______________________________________________
    Openembedded-devel mailing list
    [email protected]
    <mailto:[email protected]>
    http://lists.openembedded.org/mailman/listinfo/openembedded-devel
    <http://lists.openembedded.org/mailman/listinfo/openembedded-devel>