Skip to contentSkip to conversation

drm/amdgpu: clear build warning

PATCH In review James Zhu 2 participants 2 messages Oct 4, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

James Zhu

author
#0 lore raw

PATCH 1/1 drm/amdgpu: clear build warning

Clear build warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wparentheses]. Introduced by commits:
bc0123e4f0d8d072a3144e7662846c5221245dc3

---
 drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c +2 -1
index c217062..60af731 100644
@@ -525,11 +525,12 @@ static int uvd_v6_0_hw_init(void *handle)
 	}
 
 done:
-	if (!r)
+	if (!r) {
 		if (uvd_v6_0_enc_support(adev))
 			DRM_INFO("UVD and UVD ENC initialized successfully.\n");
 		else
 			DRM_INFO("UVD initialized successfully.\n");
+	}
 
 	return r;
 }
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1507116865-15334-1-git-send-email-James.Zhu-5C7GfCeVMHo@public.gmane.org

Reviewed-by Alex Deucher
#2 lore raw
Quoted 7 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of James Zhu
Sent: Wednesday, October 04, 2017 7:34 AM
To: [email protected]
Subject: [PATCH] drm/amdgpu: clear build warning

Quoted 5 lines

Clear build warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wparentheses]. Introduced by commits:
bc0123e4f0d8d072a3144e7662846c5221245dc3

Quoted 27 lines
---
 drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c +2 -1
index c217062..60af731 100644
@@ -525,11 +525,12 @@ static int uvd_v6_0_hw_init(void *handle)
 	}
 
 done:
-	if (!r)
+	if (!r) {
 		if (uvd_v6_0_enc_support(adev))
 			DRM_INFO("UVD and UVD ENC initialized
 successfully.\n");
 		else
 			DRM_INFO("UVD initialized successfully.\n");
+	}
 
 	return r;

}
--
2.7.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx