Staging: rtl8188eu: core: Use list_for_each_entry_safe
PATCH 1/1 Staging: rtl8188eu: core: Use list_for_each_entry_safe
Use list_for_each_entry_safe to make the code more compact. Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
expression e;
identifier m, list_del_init, f;
type T1;
T1* pos;
iterator name list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(&pos->m)
...+>
}
...+>
}
Signed-off-by Srishti Sharma <[email protected]>
--- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c +3 -5
@@ -5446,6 +5446,7 @@ u8 mlme_evt_hdl(struct adapter *padapter, unsigned char *pbuf)u8 tx_beacon_hdl (struct adapter *padapter,unsigned char *pbuf) { +struct xmit_frame *tmp;if (send_beacon (padapter) == _FAIL) {DBG_88E ("issue_beacon, fail!\n" );return H2C_PARAMETERS_ERROR ;
@@ -5469,11 +5470,8 @@ u8 tx_beacon_hdl(struct adapter *padapter, unsigned char *pbuf) xmitframe_phead =get_list_head (&psta_bmc->sleep_q); xmitframe_plist = xmitframe_phead->next; -while (xmitframe_phead != xmitframe_plist) { - pxmitframe = container_of(xmitframe_plist, struct xmit_frame, list); - - xmitframe_plist = xmitframe_plist->next; - +list_for_each_entry_safe (pxmitframe, tmp, + xmitframe_plist, list) {list_del_init (&pxmitframe->list); psta_bmc->sleepq_len--;
Signature · 1 line
2.7.4