Staging: rtl8723bs: Externs should be avoided in .C file
PATCH 1/2 Staging: rtl8723bs: Externs should be avoided in .C file
Removed all unnecessary externs warnings in rtl8723bs
Signed-off-by Srinivasan Shanmugam <[email protected]>
--- drivers/staging/rtl8723bs/core/rtw_efuse.c | 7 +------ drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 1 - drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 -- drivers/staging/rtl8723bs/core/rtw_recv.c | 8 ++++---- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 3 --- drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 2 ++ 6 files changed, 7 insertions(+), 16 deletions(-)
drivers/staging/rtl8723bs/core/rtw_efuse.c +1 -6
@@ -43,12 +43,7 @@#define EFUSE_CTRL REG_EFUSE_CTRL/* E-Fuse Control. */ /* */ -bool -Efuse_Read1ByteFromFakeContent ( -struct adapter *padapter, -u16 Offset, -u8 *Value); -bool +static bool Efuse_Read1ByteFromFakeContent( struct adapter *padapter, u16 Offset,
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +0 -1
@@ -63,7 +63,6 @@ u8 rtw_validate_ssid(struct ndis_802_11_ssid *ssid)return ret; } -u8 rtw_do_join (struct adapter *padapter);u8 rtw_do_join (struct adapter *padapter) {struct list_head *plist, *phead;
drivers/staging/rtl8723bs/core/rtw_mlme.c +0 -2
@@ -18,8 +18,6 @@#include <rtw_debug.h> #include <linux/jiffies.h> -extern u8 rtw_do_join (struct adapter *padapter); -sint _rtw_init_mlme_priv (struct adapter *padapter) {sint i;
drivers/staging/rtl8723bs/core/rtw_recv.c +4 -4
@@ -26,7 +26,7 @@/* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */ u8 rtw_bridge_tunnel_header[] = {0xaa ,0xaa ,0x03 ,0x00 ,0x00 ,0xf8 }; -void rtw_signal_stat_timer_hdl (RTW_TIMER_HDL_ARGS ); +static void rtw_signal_stat_timer_hdl (RTW_TIMER_HDL_ARGS );void _rtw_init_sta_recv_priv (struct sta_recv_priv *psta_recvpriv) {
@@ -1225,8 +1225,8 @@ sint validate_recv_ctrl_frame(struct adapter *padapter, union recv_frame *precv_ }union recv_frame *recvframe_chk_defrag (struct adapter *padapter,union recv_frame *precv_frame); -sint validate_recv_mgnt_frame (struct adapter *padapter,union recv_frame *precv_frame); -sint validate_recv_mgnt_frame (struct adapter *padapter,union recv_frame *precv_frame) + +static sint validate_recv_mgnt_frame (struct adapter *padapter,union recv_frame *precv_frame) {/* struct mlme_priv *pmlmepriv = &adapter->mlmepriv; */
@@ -2597,7 +2597,7 @@ s32 rtw_recv_entry(union recv_frame *precvframe)return ret; } -void rtw_signal_stat_timer_hdl (RTW_TIMER_HDL_ARGS ) +static void rtw_signal_stat_timer_hdl (RTW_TIMER_HDL_ARGS ) {struct adapter *adapter = (struct adapter *)FunctionContext;struct recv_priv *recvpriv = &adapter->recvpriv;
drivers/staging/rtl8723bs/core/rtw_wlan_util.c +0 -3
@@ -37,9 +37,6 @@static unsigned char RSN_TKIP_CIPHER [4 ] = {0x00 ,0x0f ,0xac ,0x02 };static unsigned char WPA_TKIP_CIPHER [4 ] = {0x00 ,0x50 ,0xf2 ,0x02 }; -extern unsigned char RTW_WPA_OUI []; -extern unsigned char WPA_TKIP_CIPHER [4 ]; -#define R2T_PHY_DELAY (0)/* define WAIT_FOR_BCN_TO_MIN (3000) */
drivers/staging/rtl8723bs/include/rtw_ioctl_set.h +2 -0
@@ -37,5 +37,7 @@u8 rtw_validate_ssid (struct ndis_802_11_ssid *ssid);u16 rtw_get_cur_max_rate (struct adapter *adapter); +u8 rtw_do_join (struct adapter *padapter); +#endif
Signature · 1 line
1.9.1