Skip to contentSkip to conversation

Staging: rtl8723bs: Externs should be avoided in .C file

PATCH In review Srinivasan Shanmugam 2 participants 2 messages Oct 4, 2017 – Oct 5, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 Staging: rtl8723bs: Externs should be avoided in .C file

Removed all the unnecessary extern from rtl8723bs

---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_recv.c +2 -1
index c0b501e..6b5e48c 100644
@@ -1226,7 +1226,8 @@ sint validate_recv_ctrl_frame(struct adapter *padapter, union recv_frame *precv_
 
 union recv_frame *recvframe_chk_defrag(struct adapter *padapter, union recv_frame *precv_frame);
 
-static sint validate_recv_mgnt_frame(struct adapter *padapter, union recv_frame *precv_frame)
+static int validate_recv_mgnt_frame(struct adapter *padapter,
+				    union recv_frame *precv_frame)
 {
 	/* struct mlme_priv *pmlmepriv = &adapter->mlmepriv; */
 
Signature · 1 line
1.9.1
#1 lore raw
Quoted 2 lines · Srinivasan Shanmugam

Removed all the unnecessary extern from rtl8723bs

The patch is good but doesn't match the description.

regards,
dan carpenter