Skip to contentSkip to conversation

Patch "MIPS: kexec: Do not reserve invalid crashkernel memory on boot" has been added to the 3.18-stable tree

PATCH [email protected] 1 participant 1 message Oct 5, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

MIPS: kexec: Do not reserve invalid crashkernel memory on boot

to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mips-kexec-do-not-reserve-invalid-crashkernel-memory-on-boot.patch
and it can be found in the queue-3.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Thu Oct 5 10:58:04 CEST 2017

From: Marcin Nowakowski <[email protected]>
Date: Wed, 23 Nov 2016 14:43:50 +0100
Subject: MIPS: kexec: Do not reserve invalid crashkernel memory on boot

From: Marcin Nowakowski <[email protected]>

[ Upstream commit a8f108d70c74d83574c157648383eb2e4285a190 ]

Do not reserve memory for the crashkernel if the commandline argument points to a wrong location. This can happen if the location is specified wrong or if the same commandline is reused when starting the crashkernel
- in the latter case the reserved memory would point to the location from which the crashkernel is executing.

Patchwork: https://patchwork.linux-mips.org/patch/14612/

---
 arch/mips/kernel/setup.c |    5 +++++
 1 file changed, 5 insertions(+)
arch/mips/kernel/setup.c +5 -0
@@ -585,6 +585,11 @@ static void __init mips_parse_crashkerne
 	if (ret != 0 || crash_size <= 0)
 		return;
 
+	if (!memory_region_available(crash_base, crash_size)) {
+		pr_warn("Invalid memory region reserved for crash kernel\n");
+		return;
+	}
+
 	crashk_res.start = crash_base;
 	crashk_res.end	 = crash_base + crash_size - 1;
 }

Patches currently in stable-queue which might be from [email protected] are

queue-3.18/mips-kexec-do-not-reserve-invalid-crashkernel-memory-on-boot.patch