Patch "ARM: remove duplicate 'const' annotations'" has been added to the 4.9-stable tree
Subsystems (8)
This is a note to let you know that I've just added the patch titled
ARM: remove duplicate 'const' annotations'
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
arm-remove-duplicate-const-annotations.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
0527873b29b077fc8e656acd63e1866b429fef55Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <[email protected]>
Date: Thu, 11 May 2017 13:50:16 +0200
Subject: ARM: remove duplicate 'const' annotations'
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Arnd Bergmann <[email protected]>
commit 0527873b29b077fc8e656acd63e1866b429fef55 upstream.
gcc-7 warns about some declarations that are more 'const' than necessary:
arch/arm/mach-at91/pm.c:338:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
static const struct of_device_id const ramc_ids[] __initconst = {arch/arm/mach-bcm/bcm_kona_smc.c:36:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
static const struct of_device_id const bcm_kona_smc_ids[] __initconst = {arch/arm/mach-spear/time.c:207:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
static const struct of_device_id const timer_of_match[] __initconst = {arch/arm/mach-omap2/prm_common.c:714:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
static const struct of_device_id const omap_prcm_dt_match_table[] __initconst = {arch/arm/mach-omap2/vc.c:562:35: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
static const struct i2c_init_data const omap4_i2c_timing_data[] __initconst = {
The ones in arch/arm were apparently all introduced accidentally by one commit that correctly marked a lot of variables as __initconst.
--- arch/arm/mach-at91/pm.c | 2 +- arch/arm/mach-bcm/bcm_kona_smc.c | 2 +- arch/arm/mach-cns3xxx/core.c | 2 +- arch/arm/mach-omap2/prm_common.c | 2 +- arch/arm/mach-omap2/vc.c | 2 +- arch/arm/mach-spear/time.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)
arch/arm/mach-at91/pm.c +1 -1
@@ -335,7 +335,7 @@ static void at91sam9_sdram_standby(void)at91_ramc_write (1 ,AT91_SDRAMC_LPR , saved_lpr1); } -static const struct of_device_id const ramc_ids[]__initconst = { +static const struct of_device_id ramc_ids[]__initconst = { { .compatible ="atmel,at91rm9200-sdramc" , .data = at91rm9200_standby }, { .compatible ="atmel,at91sam9260-sdramc" , .data = at91sam9_sdram_standby }, { .compatible ="atmel,at91sam9g45-ddramc" , .data = at91_ddr_standby },
arch/arm/mach-bcm/bcm_kona_smc.c +1 -1
@@ -33,7 +33,7 @@ struct bcm_kona_smc_data {unsigned result; }; -static const struct of_device_id const bcm_kona_smc_ids[]__initconst = { +static const struct of_device_id bcm_kona_smc_ids[]__initconst = { {.compatible ="brcm,kona-smc" }, {.compatible ="bcm,kona-smc" },/* deprecated name */ {},
arch/arm/mach-cns3xxx/core.c +1 -1
@@ -346,7 +346,7 @@ static struct usb_ohci_pdata cns3xxx_usb .power_off = csn3xxx_usb_power_off, }; -static const struct of_dev_auxdata const cns3xxx_auxdata[]__initconst = { +static const struct of_dev_auxdata cns3xxx_auxdata[]__initconst = { {"intel,usb-ehci" ,CNS3XXX_USB_BASE ,"ehci-platform" , &cns3xxx_usb_ehci_pdata }, {"intel,usb-ohci" ,CNS3XXX_USB_OHCI_BASE ,"ohci-platform" , &cns3xxx_usb_ohci_pdata }, {"cavium,cns3420-ahci" ,CNS3XXX_SATA2_BASE ,"ahci" ,NULL },
arch/arm/mach-omap2/prm_common.c +1 -1
@@ -713,7 +713,7 @@ static struct omap_prcm_init_data scrm_d };#endif -static const struct of_device_id const omap_prcm_dt_match_table[]__initconst = { +static const struct of_device_id omap_prcm_dt_match_table[]__initconst = { #ifdef CONFIG_SOC_AM33XX { .compatible ="ti,am3-prcm" , .data = &am3_prm_data }, #endif
arch/arm/mach-omap2/vc.c +1 -1
@@ -559,7 +559,7 @@ struct i2c_init_data {u8 hsscll_12; }; -static const struct i2c_init_data const omap4_i2c_timing_data[]__initconst = { +static const struct i2c_init_data omap4_i2c_timing_data[]__initconst = { { .load =50 , .loadbits =0x3 ,
arch/arm/mach-spear/time.c +1 -1
@@ -204,7 +204,7 @@ static void __init spear_clockevent_initsetup_irq (irq, &spear_timer_irq); } -static const struct of_device_id const timer_of_match[]__initconst = { +static const struct of_device_id timer_of_match[]__initconst = { { .compatible ="st,spear-timer" , }, { }, };
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/arm-remove-duplicate-const-annotations.patch queue-4.9/ttpci-address-stringop-overflow-warning.patch queue-4.9/ib-qib-fix-false-postive-maybe-uninitialized-warning.patch queue-4.9/asoc-rt5514-fix-gcc-7-warning.patch queue-4.9/mips-lantiq-fix-another-request_mem_region-return-code-check.patch queue-4.9/alsa-au88x0-avoid-theoretical-uninitialized-access.patch queue-4.9/asoc-rt5659-drop-double-const.patch