OpenBMC helper scripts repositories
Hello,
I've noticed that we've grown several helper script repositories, with a mix of intents.
So far we have:
https://github.com/williamspatrick/openbmc-events
and the seemingly more active fork:
https://github.com/geissonator/openbmc-events
Along with something Joel cooked up a while back:
https://github.com/shenki/obmc-ctrl
and some scripts that I've written:
https://github.com/amboar/obmc-scripts/
Is it worth consolidating these efforts? If we do I think the result should be low friction wrt merging changes, and some hacking should always be expected if you're going to use the repository. Consolidating might help avoid duplicate effort.
Cheers,
Andrew
Mine too... https://github.com/causten/openbmc-tutorials
"openbmc" <[email protected]> wrote on 10/05/2017 08:55:40 PM:
Quoted 35 lines
From: Andrew Jeffery <[email protected]>
To: OpenBMC <[email protected]>
Date: 10/05/2017 08:56 PM
Subject: OpenBMC helper scripts repositories
Sent by: "openbmc" <[email protected]>Hello,
I've noticed that we've grown several helper script repositories, with a mix of intents.
So far we have:
https://github.com/williamspatrick/openbmc-events
and the seemingly more active fork:
https://github.com/geissonator/openbmc-events
Along with something Joel cooked up a while back:
https://github.com/shenki/obmc-ctrl
and some scripts that I've written:
https://github.com/amboar/obmc-scripts/
Is it worth consolidating these efforts? If we do I think the result should be low friction wrt merging changes, and some hacking should always be expected if you're going to use the repository. Consolidating might help avoid duplicate effort.
Cheers,
Andrew[attachment "signature.asc" deleted by Chris Austen/Austin/IBM]
Quoted 2 lines · Chris Austen
Mine too... https://github.com/causten/openbmc-tutorials
That's some handy content! Probably not quite what I'd expect for a random utils repository, but we should work out what to do with this as well. Certainly could feature on a website when we get one...
A message that is not in the archive (sent off-list or not yet received): OFDFEB18C7.4CBB979B-ON002581B1.000FD8A2@LocalDomain
https://github.com/causten/tools/tree/master/obmc I've also got those files. things have evolved and I not kept the error logging or code update refreshed to any of the new xyz paths. However, leds.py still can toggle the LEDS on a system and obmcrequests.py (my library for bmc communication) can work offline if the data has been captured.
"openbmc" <[email protected]> wrote on 10/05/2017 09:52:43 PM:
Quoted 7 lines
From: "Chris Austen" <[email protected]>
To: Andrew Jeffery <[email protected]>
Cc: OpenBMC <[email protected]>
Date: 10/05/2017 09:53 PM
Subject: Re: OpenBMC helper scripts repositories
Sent by: "openbmc" <[email protected]>
Quoted 11 lines
Mine too... https://github.com/causten/openbmc-tutorials
"openbmc" <[email protected]> wrote on 10/05/2017 08:55:40 PM:
Quoted 5 lines
From: Andrew Jeffery <[email protected]>
To: OpenBMC <[email protected]>
Date: 10/05/2017 08:56 PM
Subject: OpenBMC helper scripts repositories
Sent by: "openbmc" <openbmc-bounces
Quoted 30 lines
Quoted 30 lines
Hello,
I've noticed that we've grown several helper script repositories, with a mix of intents.
So far we have:
https://github.com/williamspatrick/openbmc-events
and the seemingly more active fork:
https://github.com/geissonator/openbmc-events
Along with something Joel cooked up a while back:
https://github.com/shenki/obmc-ctrl
and some scripts that I've written:
https://github.com/amboar/obmc-scripts/
Is it worth consolidating these efforts? If we do I think the result should be low friction wrt merging changes, and some hacking should always be expected if you're going to use the repository. Consolidating might help avoid duplicate effort.
Cheers,
Andrew[attachment "signature.asc" deleted by Chris Austen/Austin/IBM]
Brad, Patrick, and I were also tossing around a misc tools repo under the openbmc umbrella a few weeks back.
I definitely vote for one! I think the main concern was support, it would def be a "use at your own risk" and "patches preferred over bug reports" type repo.
I know George also has a collection of tools he uses for REST operations as well.
With https://github.com/geissonator/openbmc-events, I was looking to build a bunch of small tools, that had similar command line interfaces to interact with the different REST api's in openbmc.
Andrew
Quoted 59 lines · Chris Austen
https://github.com/causten/tools/tree/master/obmc I've also got those files. things have evolved and I not kept the error logging or code update refreshed to any of the new xyz paths. However,
leds.pystill can toggle the LEDS on a system andobmcrequests.py(my library for bmc communication) can work offline if the data has been captured."openbmc" <[email protected]> wrote on 10/05/2017 09:52:43 PM:
Quoted 49 lines
From: "Chris Austen" <[email protected]>
To: Andrew Jeffery <[email protected]>
Cc: OpenBMC <[email protected]>
Date: 10/05/2017 09:53 PM
Subject: Re: OpenBMC helper scripts repositories
Sent by: "openbmc" <[email protected]>Mine too... https://github.com/causten/openbmc-tutorials
"openbmc" <[email protected]> wrote on 10/05/2017 08:55:40 PM:
Quoted 36 lines
From: Andrew Jeffery <[email protected]>
To: OpenBMC <[email protected]>
Date: 10/05/2017 08:56 PM
Subject: OpenBMC helper scripts repositories
Sent by: "openbmc" <[email protected]>Hello,
I've noticed that we've grown several helper script repositories, with a mix of intents.
So far we have:
https://github.com/williamspatrick/openbmc-events
and the seemingly more active fork:
https://github.com/geissonator/openbmc-events
Along with something Joel cooked up a while back:
https://github.com/shenki/obmc-ctrl
and some scripts that I've written:
https://github.com/amboar/obmc-scripts/
Is it worth consolidating these efforts? If we do I think the result should be low friction wrt merging changes, and some hacking should always be expected if you're going to use the repository. Consolidating might help avoid duplicate effort.
Cheers,
Andrew[attachment "signature.asc" deleted by Chris Austen/Austin/IBM]
Vote+1
I always wanted such a repo to put common/shared scripts together.
And even more, what about a repo that collects the common/shared code (C/C++)?
Quite a lot of repos are having the same/similar functions like getting a service
via mapper call.
Is it better to collect such code, make sure they are well-tested, and put them in a shared repo (e.g. in SDK)?
--
BRs,
Lei YU
Quoted 76 lines · Andrew Geissler
Brad, Patrick, and I were also tossing around a misc tools repo under the openbmc umbrella a few weeks back.
I definitely vote for one! I think the main concern was support, it would def be a "use at your own risk" and "patches preferred over bug reports" type repo.
I know George also has a collection of tools he uses for REST operations as well.
With https://github.com/geissonator/openbmc-events, I was looking to build a bunch of small tools, that had similar command line interfaces to interact with the different REST api's in openbmc.
Andrew
Quoted 59 lines · Chris Austen
https://github.com/causten/tools/tree/master/obmc I've also got those files. things have evolved and I not kept the error logging or code update refreshed to any of the new xyz paths. However,
leds.pystill can toggle the LEDS on a system andobmcrequests.py(my library for bmc communication) can work offline if the data has been captured."openbmc" <[email protected]> wrote on 10/05/2017 09:52:43 PM:
Quoted 49 lines
From: "Chris Austen" <[email protected]>
To: Andrew Jeffery <[email protected]>
Cc: OpenBMC <[email protected]>
Date: 10/05/2017 09:53 PM
Subject: Re: OpenBMC helper scripts repositories
Sent by: "openbmc" <[email protected]>Mine too... https://github.com/causten/openbmc-tutorials
"openbmc" <[email protected]> wrote on 10/05/2017 08:55:40 PM:
Quoted 36 lines
From: Andrew Jeffery <[email protected]>
To: OpenBMC <[email protected]>
Date: 10/05/2017 08:56 PM
Subject: OpenBMC helper scripts repositories
Sent by: "openbmc" <[email protected]>Hello,
I've noticed that we've grown several helper script repositories, with a mix of intents.
So far we have:
https://github.com/williamspatrick/openbmc-events
and the seemingly more active fork:
https://github.com/geissonator/openbmc-events
Along with something Joel cooked up a while back:
https://github.com/shenki/obmc-ctrl
and some scripts that I've written:
https://github.com/amboar/obmc-scripts/
Is it worth consolidating these efforts? If we do I think the result should be low friction wrt merging changes, and some hacking should always be expected if you're going to use the repository. Consolidating might help avoid duplicate effort.
Cheers,
Andrew[attachment "signature.asc" deleted by Chris Austen/Austin/IBM]
Quoted 3 lines · Lei YU
Vote+1
I always wanted such a repo to put common/shared scripts together.
Great, it seems there's a fair bit of consensus on this. Did you have any scripts of your own that we could pull in?
Quoted 3 lines
And even more, what about a repo that collects the common/shared code (C/C++)?
I feel this is a different undertaking, something that should be addressed separately from what I'm proposing. My move-fast-and-break- things model doesn't really gel with developing the low-level libraries you're talking about here.
Cheers,
Andrew
Quoted 7 lines · Andrew Jeffery
Quoted 3 lines · Lei YU
Vote+1
I always wanted such a repo to put common/shared scripts together.
Great, it seems there's a fair bit of consensus on this. Did you have any scripts of your own that we could pull in?
Yup, I have "upload_and_update.py" that do the code upload/update. Though it only works on non-ubi-fs systems.
https://gist.github.com/mine260309/21ceff0f69b42df0ef12a85c83ec01c3
Quoted 9 lines
Quoted 4 lines
And even more, what about a repo that collects the common/shared code (C/C++)?
I feel this is a different undertaking, something that should be addressed separately from what I'm proposing. My move-fast-and-break- things model doesn't really gel with developing the low-level libraries you're talking about here.
Sure, let's focus on the scripts for now.
Quoted 4 lines
Cheers,
Andrew
Lets do this! Any proposal on the repo name Andrew J? openbmc-tools?
Andrew
Quoted 29 lines · Lei YU
Quoted 7 lines · Andrew Jeffery
Quoted 3 lines · Lei YU
Vote+1
I always wanted such a repo to put common/shared scripts together.
Great, it seems there's a fair bit of consensus on this. Did you have any scripts of your own that we could pull in?
Yup, I have "
upload_and_update.py" that do the code upload/update. Though it only works on non-ubi-fs systems.
https://gist.github.com/mine260309/21ceff0f69b42df0ef12a85c83ec01c3Quoted 9 lines
Quoted 4 lines
And even more, what about a repo that collects the common/shared code (C/C++)?
I feel this is a different undertaking, something that should be addressed separately from what I'm proposing. My move-fast-and-break- things model doesn't really gel with developing the low-level libraries you're talking about here.
Sure, let's focus on the scripts for now.
Quoted 4 lines
Cheers,
Andrew
Quoted 1 line · Andrew Geissler
Lets do this! Any proposal on the repo name Andrew J? openbmc-tools?
Sounds reasonable to me, can you create it?
Cheers,
Andrew
Quoted 8 lines · Andrew Jeffery
Quoted 1 line · Andrew Geissler
Lets do this! Any proposal on the repo name Andrew J? openbmc-tools?
Sounds reasonable to me, can you create it?
Cheers,
Andrew
https://github.com/openbmc/openbmc-tools created.
Thanks Andrew J!
Quoted 8 lines · Lei YU
Quoted 6 lines · Andrew Jeffery
Quoted 4 lines · Lei YU
Vote+1
I always wanted such a repo to put common/shared scripts together.
Quoted 7 lines
Quoted 3 lines
Great, it seems there's a fair bit of consensus on this. Did you have
any scripts of your own that we could pull in?Yup, I have "
upload_and_update.py" that do the code upload/update. Though it only works on non-ubi-fs systems.
https://gist.github.com/mine260309/21ceff0f69b42df0ef12a85c83ec01c3
Can you please license this under Apache 2.0 and submit it to
https://github.com/openbmc/openbmc-tools ?
Cheers,
Andrew
Quoted 13 lines · Andrew Jeffery
Quoted 12 lines · Lei YU
Quoted 9 lines · Andrew Jeffery
Quoted 4 lines · Lei YU
Vote+1
I always wanted such a repo to put common/shared scripts together.
Great, it seems there's a fair bit of consensus on this. Did you have
any scripts of your own that we could pull in?
Quoted 6 lines
Quoted 3 lines
Yup, I have "
upload_and_update.py" that do the code upload/update. Though it only works on non-ubi-fs systems.
https://gist.github.com/mine260309/21ceff0f69b42df0ef12a85c83ec01c3Can you please license this under Apache 2.0 and submit it to
https://github.com/openbmc/openbmc-tools ?
Created pull request.
Thanks!
Quoted 4 lines
Cheers,
Andrew
Quoted 2 lines · Andrew Geissler
Brad, Patrick, and I were also tossing around a misc tools repo under the openbmc umbrella a few weeks back.
Interesting, glad to hear it's already got some attention.
Quoted 4 lines
I definitely vote for one! I think the main concern was support, it would def be a "use at your own risk" and "patches preferred over bug reports" type repo.
Yeah, absolutely. This is what I was looking for as well, as a means to merge code as quickly as possible to minimise the fragmentation. This means things will probably be broken, but maybe we can look at hardening the process against breakage after we've got something in place (and are sick of it breaking).
Quoted 3 lines
I know George also has a collection of tools he uses for REST operations as well.
Right, these would be good to include.
Quoted 4 lines
Quoted 2 lines
With https://github.com/geissonator/openbmc-events, I was looking to
build a bunch of small tools, that had similar command line interfaces to interact with the different REST api's in openbmc.
Consistency is good (especially with respect to the REST API) if it's easy to achieve, but I think we shouldn't get too hung up about it in general (i.e. for tools operating outside the REST context).
What if we git-subtree the existing repos into mine? I'm happy to maintain it.
Thanks for your thoughts!
Andrew
Quoted 3 lines · Andrew Geissler
With https://github.com/geissonator/openbmc-events, I was looking to build a bunch of small tools, that had similar command line interfaces to interact with the different REST api's in openbmc.
I've pulled this into openbmc/openbmc-tools.
Cheers,
Andrew
Hey Chris,
Quoted 7 lines · Chris Austen
https://github.com/causten/tools/tree/master/obmc I've also got those files. things have evolved and I not kept the error logging or code update refreshed to any of the new xyz paths. However,
leds.pystill can toggle the LEDS on a system andobmcrequests.py(my library for bmc communication) can work offline if the data has been captured.
I took a quick look at the history of the repository and I'm hesitant to pull it in right away. We need to sort out Signed-off-by tags for it and fix your name (to be your actual name and not 'causten') in the commits. Once that's done though I'll pull it in.
Cheers,
Andrew