Skip to contentSkip to conversation

drm/i915: Don't use BIT() in UAPI section

PATCH In review Joonas Lahtinen 3 participants 4 messages Oct 6, 2017

Subsystems (3)
lore
Share & tools
lore

Joonas Lahtinen

author maintainer
#0 lore raw

PATCH 1/1 drm/i915: Don't use BIT() in UAPI section

Lets not introduce BIT() macro requirement for UAPI for now.

Fixes 3fd3a6ffe279 ("drm/i915: Simplify i915_reg_read_ioctl")
Cc Chris Wilson <[email protected]>
---
 include/uapi/drm/i915_drm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/drm/i915_drm.h +1 -1
index 7266b53191ee..125bde7d9504 100644
@@ -1318,7 +1318,7 @@ struct drm_i915_reg_read {
 	 * be specified
 	 */
 	__u64 offset;
-#define I915_REG_READ_8B_WA BIT(0)
+#define I915_REG_READ_8B_WA (1ul << 0)
 
 	__u64 val; /* Return value */
 };
Signature · 6 lines
2.13.6

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw

Quoting Joonas Lahtinen (2017-10-06 11:45:59)

Quoted 5 lines

Lets not introduce BIT() macro requirement for UAPI for now.

Fixes 3fd3a6ffe279 ("drm/i915: Simplify i915_reg_read_ioctl")
Cc Chris Wilson <[email protected]>

Yes, this is the simplest solution for now. I mistakenly thought we would be able to use BIT in uapi, but is not exported yet and the first one who does has the challene of conflicts. :|

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author maintainer
#2 lore raw
Quoted 7 lines · Chris Wilson

Quoting Joonas Lahtinen (2017-10-06 11:45:59)

Quoted 5 lines

Lets not introduce BIT() macro requirement for UAPI for now.

Fixes 3fd3a6ffe279 ("drm/i915: Simplify i915_reg_read_ioctl")
Cc Chris Wilson <[email protected]>
Quoted 5 lines

Yes, this is the simplest solution for now. I mistakenly thought we would be able to use BIT in uapi, but is not exported yet and the first one who does has the challene of conflicts. :|

Thanks for the quick review, pushed the patch.

Regards, Joonas

Signature · 7 lines
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

✗ Fi.CI.BAT: failure for drm/i915: Don't use BIT() in UAPI section

In reply to Joonas Lahtinen
== Series Details ==

== Series Details ==

Series: drm/i915: Don't use BIT() in UAPI section
URL : https://patchwork.freedesktop.org/series/31482/
State : failure

== Summary ==

Series 31482 revision 1 was fully merged or fully failed: no git log

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx