Skip to contentSkip to conversation

iommu/vt-d: Delete unnecessary check

PATCH Applied Christos Gkekas 2 participants 2 messages Oct 8, 2017 – Oct 10, 2017 IOMMU

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iommu/vt-d: Delete unnecessary check

Variable did_old is unsigned so checking whether it is greater or equal to zero is not necessary.

---
 drivers/iommu/intel-iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/intel-iommu.c +1 -1
index ebb4835..cb7ce99 100644
@@ -2054,7 +2054,7 @@ static int domain_context_mapping_one(struct dmar_domain *domain,
 	if (context_copied(context)) {
 		u16 did_old = context_domain_id(context);
 
-		if (did_old >= 0 && did_old < cap_ndoms(iommu->cap)) {
+		if (did_old < cap_ndoms(iommu->cap)) {
 			iommu->flush.flush_context(iommu, did_old,
 						   (((u16)bus) << 8) | devfn,
 						   DMA_CCMD_MASK_NOBIT,
Signature · 1 line
2.7.4
maintainer Applied
#1 lore raw
Quoted 7 lines · Christos Gkekas

Variable did_old is unsigned so checking whether it is greater or equal to zero is not necessary.

---
 drivers/iommu/intel-iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.