Skip to contentSkip to conversation

Patch "iio: adc: stm32: fix bad error check on max_channels" has been added to the 4.13-stable tree

PATCH [email protected] 1 participant 1 message Oct 9, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iio: adc: stm32: fix bad error check on max_channels

to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
iio-adc-stm32-fix-bad-error-check-on-max_channels.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 4fb840c95f82652cece7352be9080884cafb92a0 Mon Sep 17 00:00:00 2001

From: Fabrice Gasnier <[email protected]>
Date: Mon, 18 Sep 2017 18:24:15 +0200
Subject: iio: adc: stm32: fix bad error check on max_channels

From: Fabrice Gasnier <[email protected]>

commit 4fb840c95f82652cece7352be9080884cafb92a0 upstream.

Fix a bad error check when counting 'st,adc-channels' array elements. This is seen when all channels are in use simultaneously.

Fixes 64ad7f643 ("iio: adc: stm32: introduce compatible data cfg")
---
 drivers/iio/adc/stm32-adc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/stm32-adc.c +1 -1
@@ -1543,7 +1543,7 @@ static int stm32_adc_chan_of_init(struct
 
 	num_channels = of_property_count_u32_elems(node, "st,adc-channels");
 	if (num_channels < 0 ||
-	    num_channels >= adc_info->max_channels) {
+	    num_channels > adc_info->max_channels) {
 		dev_err(&indio_dev->dev, "Bad st,adc-channels?\n");
 		return num_channels < 0 ? num_channels : -EINVAL;
 	}

Patches currently in stable-queue which might be from [email protected] are

queue-4.13/iio-adc-stm32-fix-bad-error-check-on-max_channels.patch queue-4.13/iio-trigger-stm32-timer-preset-shouldn-t-be-buffered.patch queue-4.13/iio-trigger-stm32-timer-fix-a-corner-case-to-write-preset.patch