Skip to contentSkip to conversation

Patch "HID: wacom: generic: Clear ABS_MISC when tool leaves proximity" has been added to the 4.13-stable tree

PATCH [email protected] 1 participant 1 message Oct 10, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

HID: wacom: generic: Clear ABS_MISC when tool leaves proximity

to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
hid-wacom-generic-clear-abs_misc-when-tool-leaves-proximity.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 92380b572d95caf48f8424746aeee63c5a2b1922 Mon Sep 17 00:00:00 2001

From: Jason Gerecke <[email protected]>
Date: Thu, 7 Sep 2017 17:47:38 -0700
Subject: HID: wacom: generic: Clear ABS_MISC when tool leaves proximity

From: Jason Gerecke <[email protected]>

commit 92380b572d95caf48f8424746aeee63c5a2b1922 upstream.

The tool ID information sent in ABS_MISC is expected to be reset to 0 when a tool leaves proximity. Not doing this can cause problems if a tool is removed and then re-introduced. Kernel event filtering will prevent the (identical) ABS_MISC event from being sent when the tool re-enters proxmity. This can cause userspace to not properly set the tool ID.

Fixes f85c9dc678 ("HID: wacom: generic: Support tool ID and additional tool types")
---
 drivers/hid/wacom_wac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/wacom_wac.c +1 -1
@@ -2272,7 +2272,7 @@ static void wacom_wac_pen_report(struct
 		input_report_key(input, wacom_wac->tool[0], prox);
 		if (wacom_wac->serial[0]) {
 			input_event(input, EV_MSC, MSC_SERIAL, wacom_wac->serial[0]);
-			input_report_abs(input, ABS_MISC, id);
+			input_report_abs(input, ABS_MISC, prox ? id : 0);
 		}
 
 		wacom_wac->hid_data.tipswitch = false;

Patches currently in stable-queue which might be from [email protected] are

queue-4.13/hid-wacom-always-increment-hdev-refcount-within-wacom_get_hdev_data.patch queue-4.13/hid-wacom-correct-coordinate-system-of-touchring-and-pen-twist.patch queue-4.13/hid-wacom-properly-report-negative-values-from-intuos-pro-2-bluetooth.patch queue-4.13/hid-wacom-bits-shifted-too-much-for-9th-and-10th-buttons.patch queue-4.13/hid-wacom-generic-send-msc_serial-and-abs_misc-when-leaving-prox.patch queue-4.13/hid-wacom-generic-clear-abs_misc-when-tool-leaves-proximity.patch