Skip to contentSkip to conversation

Patch "HID: wacom: leds: Don't try to control the EKR's read-only LEDs" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Oct 10, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

HID: wacom: leds: Don't try to control the EKR's read-only LEDs

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
hid-wacom-leds-don-t-try-to-control-the-ekr-s-read-only-leds.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 74aebed6dc13425233f2224668353cff7a112776 Mon Sep 17 00:00:00 2001

From: Aaron Armstrong Skomra <[email protected]>
Date: Mon, 28 Aug 2017 14:15:39 -0700
Subject: HID: wacom: leds: Don't try to control the EKR's read-only LEDs

From: Aaron Armstrong Skomra <[email protected]>

commit 74aebed6dc13425233f2224668353cff7a112776 upstream.

Commit a50aac7193f1 introduces 'led.groups' and adds EKR support for these groups. However, unlike the other devices with LEDs, the EKR's LEDs are read-only and we shouldn't attempt to control them in wacom_led_control().

See bug: https://sourceforge.net/p/linuxwacom/bugs/342/

Fixes a50aac7193f1 ("HID: wacom: leds: dynamically allocate LED groups")
---
 drivers/hid/wacom_sys.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/hid/wacom_sys.c +3 -0
@@ -712,6 +712,9 @@ static int wacom_led_control(struct waco
 	if (!wacom->led.groups)
 		return -ENOTSUPP;
 
+	if (wacom->wacom_wac.features.type == REMOTE)
+		return -ENOTSUPP;
+
 	if (wacom->wacom_wac.pid) { /* wireless connected */
 		report_id = WAC_CMD_WL_LED_CONTROL;
 		buf_size = 13;

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/hid-wacom-leds-don-t-try-to-control-the-ekr-s-read-only-leds.patch