Patch "scsi: sd: Do not override max_sectors_kb sysfs setting" has been added to the 4.13-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
scsi: sd: Do not override max_sectors_kb sysfs setting
to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
scsi-sd-do-not-override-max_sectors_kb-sysfs-setting.patch
and it can be found in the queue-4.13 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
77082ca503bed061f7fbda7cfd7c93beda967a41Mon Sep 17 00:00:00 2001
From: "Martin K. Petersen" <[email protected]>
Date: Wed, 27 Sep 2017 21:38:59 -0400
Subject: scsi: sd: Do not override max_sectors_kb sysfs setting
From: Martin K. Petersen <[email protected]>
commit 77082ca503bed061f7fbda7cfd7c93beda967a41 upstream.
A user may lower the max_sectors_kb setting in sysfs to accommodate certain workloads. Previously we would always set the max I/O size to either the block layer default or the optional preferred I/O size reported by the device.
Keep the current heuristics for the initial setting of max_sectors_kb. For subsequent invocations, only update the current queue limit if it exceeds the capabilities of the hardware.
--- drivers/scsi/sd.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-)
drivers/scsi/sd.c +14 -5
@@ -3109,8 +3109,6 @@ static int sd_revalidate_disk(struct gensd_read_security (sdkp, buffer); } - sdkp->first_scan =0 ; -/* * We now have all cache related info, determine how we deal * with flush requests.
@@ -3125,7 +3123,7 @@ static int sd_revalidate_disk(struct gen q->limits.max_dev_sectors =logical_to_sectors (sdp, dev_max);/* -* Use the device's preferred I/O size for reads and writes +* Determine the device's preferred I/O size for reads and writes * unless the reported value is unreasonably small, large, or * garbage. */
@@ -3139,8 +3137,19 @@ static int sd_revalidate_disk(struct gen rw_max =min_not_zero (logical_to_sectors (sdp, dev_max), (sector_t )BLK_DEF_MAX_SECTORS ); -/* Combine with controller limits */ - q->limits.max_sectors =min (rw_max,queue_max_hw_sectors (q)); +/* Do not exceed controller limit */ + rw_max =min (rw_max,queue_max_hw_sectors (q)); + +/* +* Only update max_sectors if previously unset or if the current value +* exceeds the capabilities of the hardware. +*/ +if (sdkp->first_scan || + q->limits.max_sectors > q->limits.max_dev_sectors || + q->limits.max_sectors > q->limits.max_hw_sectors) + q->limits.max_sectors = rw_max; + + sdkp->first_scan =0 ;set_capacity (disk,logical_to_sectors (sdp, sdkp->capacity));sd_config_write_same (sdkp);
Patches currently in stable-queue which might be from [email protected] are
queue-4.13/scsi-sd-do-not-override-max_sectors_kb-sysfs-setting.patch queue-4.13/scsi-sd-implement-blacklist-option-for-write-same-w-unmap.patch