tests: Drop gem_bad_length as redundant
From: Daniele Ceraolo Spurio <[email protected]>
Most of the gem_bad_length code is compiled out because creating a zero-length object is not allowed anymore by i915 and thus it is not possible to execute it. The remaining part checks that creation of a zero-length object does indeed fail, which is also checked by gem_create/create-invalid-size.
The only difference between the 2 tests is that gem_bad_length checks specifically for EINVAL while create-invalid-size only looks for failure, so after adding the EINVAL check to create-invalid-size it is safe to drop gem_bad_length.
v2 (Joonas):
- Clarify header line, split the patch, fix Meson build and add Cc:
--- tests/Makefile.sources | 1 - tests/gem_bad_length.c | 133 ------------------------------------------------- tests/meson.build | 1 - 3 files changed, 135 deletions(-) delete mode 100644 tests/gem_bad_length.c
tests/Makefile.sources +0 -1
@@ -40,7 +40,6 @@ TESTS_progs = \ drv_module_reload \ drv_selftest \ drv_suspend \ - gem_bad_length \ gem_bad_reloc \ gem_basic \ gem_busy \
tests/gem_bad_length.c deleted +0 -133
133 lines not on this page · raw message
tests/meson.build +0 -1
@@ -20,7 +20,6 @@ test_progs = [ 'drv_module_reload', 'drv_selftest', 'drv_suspend', - 'gem_bad_length', 'gem_bad_reloc', 'gem_basic', 'gem_busy',
Signature · 6 lines
2.13.6 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for tests: Drop gem_bad_length as redundant
== Series Details ==
== Series Details ==
Series: tests: Drop gem_bad_length as redundant
URL : https://patchwork.freedesktop.org/series/31655/
State : success
== Summary ==
IGT patchset tested on top of latest successful build d7c88290ab6a8393dc341b30c7fb5e27d2952901 syncobj: Add a test for SYNCOBJ_CREATE_SIGNALED
with latest DRM-Tip kernel build CI_DRM_3206cc58e6d2bc38 drm-tip: 2017y-10m-10d-15h-40m-22s UTC integration manifest
Testlist changes:
-igt@gem_bad_length
Test chamelium:
Subgroup dp-crc-fast:
fail -> PASS (fi-kbl-7500u) fdo#102514
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
incomplete -> PASS (fi-kbl-7560u) fdo#102846fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#102846 https://bugs.freedesktop.org/show_bug.cgi?id=102846
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:455s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:472s fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:393s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:581s fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:286s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:526s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:523s fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:542s fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:517s fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:562s fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:633s fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:431s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:599s fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:436s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:425s fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:465s fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:507s fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:476s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:505s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:582s fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:492s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:596s fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:663s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:472s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:661s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:535s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:508s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:474s fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:583s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:433s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_313/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: warning for tests: Drop gem_bad_length as redundant
In reply to Joonas Lahtinen== Series Details ==
== Series Details ==
Series: tests: Drop gem_bad_length as redundant
URL : https://patchwork.freedesktop.org/series/31655/
State : warning
== Summary ==
Test gem_eio:
Subgroup wait:
pass -> DMESG-WARN (shard-hsw) fdo#102886 +4
Test kms_universal_plane:
Subgroup cursor-fb-leak-pipe-A:
pass -> SKIP (shard-hsw)
Test kms_flip:
Subgroup modeset-vs-vblank-race:
pass -> FAIL (shard-hsw) fdo#102919
Test kms_plane:
Subgroup plane-position-hole-pipe-C-planes:
pass -> DMESG-WARN (shard-hsw)fdo#102886 https://bugs.freedesktop.org/show_bug.cgi?id=102886
fdo#102919 https://bugs.freedesktop.org/show_bug.cgi?id=102919
shard-hsw total:2551 pass:1428 dwarn:5 dfail:0 fail:14 skip:1104 time:9567s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_313/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 12 lines · Joonas Lahtinen
From: Daniele Ceraolo Spurio <[email protected]>
Most of the
gem_bad_lengthcode is compiled out because creating a zero-length object is not allowed anymore by i915 and thus it is not possible to execute it. The remaining part checks that creation of a zero-length object does indeed fail, which is also checked by gem_create/create-invalid-size.
The only difference between the 2 tests is thatgem_bad_lengthchecks specifically for EINVAL while create-invalid-size only looks for failure, so after adding the EINVAL check to create-invalid-size it is safe to dropgem_bad_length.
Quoted 7 lines
v2 (Joonas):
- Clarify header line, split the patch, fix Meson build and add Cc:Signed-off-by Daniele Ceraolo Spurio <[email protected]>Signed-off-by Joonas Lahtinen <[email protected]>Cc Chris Wilson <[email protected]>Reviewed-by Chris Wilson <[email protected]>
Merged the patch.
Regards, Joonas
Signature · 7 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx