Skip to contentSkip to conversation

Patch "ext4: in ext4_seek_{hole,data}, return -ENXIO for negative offsets" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Oct 12, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ext4: in ext4_seek_{hole,data}, return -ENXIO for negative offsets

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ext4-in-ext4_seek_-hole-data-return-enxio-for-negative-offsets.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 1bd8d6cd3e413d64e543ec3e69ff43e75a1cf1ea Mon Sep 17 00:00:00 2001

From: "Darrick J. Wong" <[email protected]>
Date: Thu, 24 Aug 2017 13:22:06 -0400
Subject: ext4: in ext4_seek_{hole,data}, return -ENXIO for negative offsets

From: Darrick J. Wong <[email protected]>

commit 1bd8d6cd3e413d64e543ec3e69ff43e75a1cf1ea upstream.

In the ext4 implementations of SEEK_HOLE and SEEK_DATA, make sure we return -ENXIO for negative offsets instead of banging around inside the extent code and returning -EFSCORRUPTED.

---
 fs/ext4/file.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ext4/file.c +2 -2
@@ -559,7 +559,7 @@ static loff_t ext4_seek_data(struct file
 	mutex_lock(&inode->i_mutex);
 
 	isize = i_size_read(inode);
-	if (offset >= isize) {
+	if (offset < 0 || offset >= isize) {
 		mutex_unlock(&inode->i_mutex);
 		return -ENXIO;
 	}
@@ -632,7 +632,7 @@ static loff_t ext4_seek_hole(struct file
 	mutex_lock(&inode->i_mutex);
 
 	isize = i_size_read(inode);
-	if (offset >= isize) {
+	if (offset < 0 || offset >= isize) {
 		mutex_unlock(&inode->i_mutex);
 		return -ENXIO;
 	}

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/ext4-in-ext4_seek_-hole-data-return-enxio-for-negative-offsets.patch