Skip to contentSkip to conversation

ARC: HSDK: introduce CREG GPIO driver

PATCH Superseded Eugeniy Paltsev 3 participants 6 messages Oct 13, 2017 – Oct 16, 2017 GPIO

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Eugeniy Paltsev

author
#0 lore raw

PATCH 1/1 ARC: HSDK: introduce CREG GPIO driver

The HSDK can manage some pins via CREG registers block.

Signed-off-by Eugeniy Paltsev <[email protected]>
---
 MAINTAINERS                   |   6 +++
 drivers/gpio/Kconfig          |   7 +++
 drivers/gpio/Makefile         |   1 +
 drivers/gpio/hsdk-creg-gpio.c | 109 ++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 123 insertions(+)
 create mode 100644 drivers/gpio/hsdk-creg-gpio.c
MAINTAINERS +6 -0
index 04acf2b..df662aa 100644
@@ -59,6 +59,12 @@ S:	Maintained
 T:	git git://git.denx.de/u-boot-arc.git
 F:	arch/arc/
 
+ARC HSDK CREG GPIO
+M:	Eugeniy Paltsev <[email protected]>
+S:	Maintained
+L:	uboot-snps-arc at synopsys.com
+F:	drivers/gpio/hsdk-creg-gpio.c
+
 ARM
 M:	Albert Aribaud <[email protected]>
 S:	Maintained
drivers/gpio/Kconfig +7 -0
index ffeda94..9928911 100644
@@ -80,6 +80,13 @@ config IMX_RGPIO2P
 	help
 	  This driver supports i.MX7ULP Rapid GPIO2P controller.
 
+config HSDK_CREG_GPIO
+	bool "HSDK CREG GPIO griver"
+	depends on DM
+	default n
+	help
+	  This driver supports CREG GPIOs on Synopsys HSDK SOC.
+
 config LPC32XX_GPIO
 	bool "LPC32XX GPIO driver"
 	depends on DM
drivers/gpio/Makefile +1 -0
index 1396467..c7efc4c 100644
@@ -53,6 +53,7 @@ obj-$(CONFIG_GPIO_UNIPHIER)	+= gpio-uniphier.o
 obj-$(CONFIG_ZYNQ_GPIO)		+= zynq_gpio.o
 obj-$(CONFIG_VYBRID_GPIO)	+= vybrid_gpio.o
 obj-$(CONFIG_HIKEY_GPIO)	+= hi6220_gpio.o
+obj-$(CONFIG_HSDK_CREG_GPIO)	+= hsdk-creg-gpio.o
 obj-$(CONFIG_IMX_RGPIO2P)	+= imx_rgpio2p.o
 obj-$(CONFIG_PIC32_GPIO)	+= pic32_gpio.o
 obj-$(CONFIG_MVEBU_GPIO)	+= mvebu_gpio.o
drivers/gpio/hsdk-creg-gpio.c new file +109 -0

109 lines not on this page · raw message

Signature · 1 line
2.9.3
#1 lore raw

PATCH 1/1 ARC: HSDK: introduce CREG GPIO driver

Hi Tom,

Quoted 10 lines · Eugeniy Paltsev

The HSDK can manage some pins via CREG registers block.

Signed-off-by Eugeniy Paltsev <[email protected]>

---
 MAINTAINERS                   |   6 +++
 drivers/gpio/Kconfig          |   7 +++
 drivers/gpio/Makefile         |   1 + drivers/gpio/hsdk-creg-gpio.c | 109 ++++++++++++++++++++++++++++++++++++++++++

 4 files changed, 123 insertions(+)

 create mode 100644 drivers/gpio/hsdk-creg-gpio.c

I'm wondering if this one should go through my tree as this is for one of our Synopsys ARC devboards or GPIO stuff usually goes through some other tree?

-Alexey

#2 lore raw

PATCH 1/1 ARC: HSDK: introduce CREG GPIO driver

Quoted 14 lines · Alexey Brodkin

Hi Tom,

Quoted 10 lines · Eugeniy Paltsev

The HSDK can manage some pins via CREG registers block.

Signed-off-by Eugeniy Paltsev <[email protected]>

---
 MAINTAINERS                   |   6 +++
 drivers/gpio/Kconfig          |   7 +++
 drivers/gpio/Makefile         |   1 + drivers/gpio/hsdk-creg-gpio.c | 109 ++++++++++++++++++++++++++++++++++++++++++

 4 files changed, 123 insertions(+)

 create mode 100644 drivers/gpio/hsdk-creg-gpio.c

Quoted 3 lines

I'm wondering if this one should go through my tree as this is for one of our Synopsys ARC devboards or GPIO stuff usually goes through some other tree?

The ARC tree is fine, but it's a bit late posting for this release. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171013/24123748/attachment.sig>
#3 lore raw

PATCH 1/1 ARC: HSDK: introduce CREG GPIO driver

Hi Tom,

Quoted 17 lines · Tom Rini
Quoted 16 lines · Alexey Brodkin

Hi Tom,

Quoted 11 lines · Eugeniy Paltsev

The HSDK can manage some pins via CREG registers block.

Signed-off-by Eugeniy Paltsev <[email protected]>

---
 MAINTAINERS                   |   6 +++
 drivers/gpio/Kconfig          |   7 +++
 drivers/gpio/Makefile         |   1 + drivers/gpio/hsdk-creg-gpio.c | 109 ++++++++++++++++++++++++++++++++++++++++++

 4 files changed, 123 insertions(+)

 create mode 100644 drivers/gpio/hsdk-creg-gpio.c

Quoted 5 lines
Quoted 3 lines

I'm wondering if this one should go through my tree as this is for one of our Synopsys ARC devboards or GPIO stuff usually goes through some other tree?

The ARC tree is fine, but it's a bit late posting for this release.

So should I keep this one in "next" branch of my tree before v2017.11 gets cut?

-Alexey

#4 lore raw

PATCH 1/1 ARC: HSDK: introduce CREG GPIO driver

Quoted 20 lines · Alexey Brodkin

Hi Tom,

Quoted 17 lines · Tom Rini
Quoted 16 lines · Alexey Brodkin

Hi Tom,

Quoted 11 lines · Eugeniy Paltsev

The HSDK can manage some pins via CREG registers block.

Signed-off-by Eugeniy Paltsev <[email protected]>

---
 MAINTAINERS                   |   6 +++
 drivers/gpio/Kconfig          |   7 +++
 drivers/gpio/Makefile         |   1 + drivers/gpio/hsdk-creg-gpio.c | 109 ++++++++++++++++++++++++++++++++++++++++++

 4 files changed, 123 insertions(+)

 create mode 100644 drivers/gpio/hsdk-creg-gpio.c

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

I'm wondering if this one should go through my tree as this is for one of our Synopsys ARC devboards or GPIO stuff usually goes through some other tree?

The ARC tree is fine, but it's a bit late posting for this release.

So should I keep this one in "next" branch of my tree before v2017.11 gets cut?

Yes, thanks.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171013/5cc2ff52/attachment.sig>
#5 lore raw

PATCH 1/1 ARC: HSDK: introduce CREG GPIO driver

In reply to Eugeniy Paltsev

Hi Eugeniy,

Quoted 10 lines · Eugeniy Paltsev

The HSDK can manage some pins via CREG registers block.

Signed-off-by Eugeniy Paltsev <[email protected]>

---
 MAINTAINERS                   |   6 +++
 drivers/gpio/Kconfig          |   7 +++
 drivers/gpio/Makefile         |   1 + drivers/gpio/hsdk-creg-gpio.c | 109 ++++++++++++++++++++++++++++++++++++++++++

 4 files changed, 123 insertions(+)

 create mode 100644 drivers/gpio/hsdk-creg-gpio.c

I've got this one applied on top of today's upstream master and with
enabled HSDK GPIO driver I'm seeing this build failure:
------------------------------>8-----------------------------
  LD      cmd/built-in.o
drivers/gpio/hsdk-creg-gpio.c: In function ‘hsdk_creg_gpio_direction_input’:
drivers/gpio/hsdk-creg-gpio.c:55:2: warning: implicit declaration of function ‘error’ [-Wimplicit-function-declaration] error("hsdk-creg-gpio can't be used as input!\n");
  ^~~~~
  LD      drivers/gpio/built-in.o
  LD      common/built-in.o
make[2]: 'arch/arc/dts/hsdk.dtb' is up to date.
  CC      lib/display_options.o
  LD      lib/built-in.o
  LD      u-boot
drivers/gpio/built-in.o: In function `hsdk_creg_gpio_direction_input':
.../u-boot/drivers/gpio/hsdk-creg-gpio.c:55: undefined reference to error' .../u-boot/drivers/gpio/hsdk-creg-gpio.c:55: undefined reference to error'
Makefile:1256: recipe for target 'u-boot' failed ------------------------------>8-----------------------------

Could you please check what's wrong there and fix it.

-Alexey