Skip to contentSkip to conversation

wandboard: Remove cpu type check prior to setup_sata()

PATCH New Fabio Estevam 2 participants 4 messages Oct 15, 2017 – Oct 18, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 wandboard: Remove cpu type check prior to setup_sata()

From: Fabio Estevam <[email protected]>

Inside setup_sata() there is a cpu type check, so there is no need to do this check in the board file.

This also brings the benefit to allowing setup_sata() to be called for the mx6qp wandboard variant.

---
 board/wandboard/wandboard.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
board/wandboard/wandboard.c +1 -3
index adfcf48..3f12b50 100644
@@ -380,9 +380,7 @@ int board_early_init_f(void)
 	setup_display();
 #endif
 #ifdef CONFIG_SATA
-	/* Only mx6q wandboard has SATA */
-	if (is_cpu_type(MXC_CPU_MX6Q))
-		setup_sata();
+	setup_sata();
 #endif
 
 	return 0;
Signature · 1 line
2.7.4
#1 lore raw

PATCH 2/2 udoo: Remove cpu type check prior to setup_sata()

From: Fabio Estevam <[email protected]>

Inside setup_sata() there is a cpu type check, so there is no need to do this check in the board file.

---
 board/udoo/udoo.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
board/udoo/udoo.c +1 -2
index a359626..562f0d8 100644
@@ -245,8 +245,7 @@ int board_init(void)
 	gd->bd->bi_boot_params = PHYS_SDRAM + 0x100;
 
 #ifdef CONFIG_SATA
-	if (is_cpu_type(MXC_CPU_MX6Q))
-		setup_sata();
+	setup_sata();
 #endif
 	return 0;
 }
Signature · 1 line
2.7.4
#2 lore raw

PATCH 2/2 udoo: Remove cpu type check prior to setup_sata()

Quoted 16 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Inside setup_sata() there is a cpu type check, so there is no need to do this check in the board file.

---
 board/udoo/udoo.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
board/udoo/udoo.c +0 -0
index a359626..562f0d8 100644

board/udoo/udoo.c int board_init(void) · line 251

Quoted 9 lines
board/udoo/udoo.c +1 -2
@@ -245,8 +245,7 @@ int board_init(void)
 	gd->bd->bi_boot_params = PHYS_SDRAM + 0x100;
 
 #ifdef CONFIG_SATA
-	if (is_cpu_type(MXC_CPU_MX6Q))
-		setup_sata();
+	setup_sata();
 #endif
 	return 0;
 }
#3 lore raw

PATCH 1/2 wandboard: Remove cpu type check prior to setup_sata()

In reply to Fabio Estevam
Quoted 19 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Inside setup_sata() there is a cpu type check, so there is no need to do this check in the board file.

This also brings the benefit to allowing setup_sata() to be called for the mx6qp wandboard variant.

---
 board/wandboard/wandboard.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
board/wandboard/wandboard.c +0 -0
index adfcf48..3f12b50 100644

board/wandboard/wandboard.c int board_early_init_f(void) · line 386

Quoted 10 lines
board/wandboard/wandboard.c +1 -3
@@ -380,9 +380,7 @@ int board_early_init_f(void)
 	setup_display();
 #endif
 #ifdef CONFIG_SATA
-	/* Only mx6q wandboard has SATA */
-	if (is_cpu_type(MXC_CPU_MX6Q))
-		setup_sata();
+	setup_sata();
 #endif
 
 	return 0;