Patch "RAS/CEC: Use the right length for "cec_disable"" has been added to the 4.13-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
RAS/CEC: Use the right length for "cec_disable"
to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ras-cec-use-the-right-length-for-cec_disable.patch
and it can be found in the queue-4.13 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
69a330007091ea8a801dd9fcd897ec52f9529586Mon Sep 17 00:00:00 2001
From: Nicolas Iooss <[email protected]>
Date: Mon, 2 Oct 2017 11:28:35 +0200
Subject: RAS/CEC: Use the right length for "cec_disable"
From: Nicolas Iooss <[email protected]>
commit 69a330007091ea8a801dd9fcd897ec52f9529586 upstream.
parse_cec_param() compares a string with "cec_disable" using only 7 characters of the 11-character-long string.
The proper solution for this would be:
#define CEC_DISABLE "cec_disable"
strncmp(str, CEC_DISABLE, strlen(CEC_DISABLE))
but when comparing a string against a string constant strncmp() has no advantage over strcmp() because the comparison is guaranteed to be bound by the string constant. So just replace str strncmp() with strcmp().
[ tglx: Made it use strcmp and updated the changelog ]
--- drivers/ras/cec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ras/cec.c +1 -1
@@ -523,7 +523,7 @@ int __init parse_cec_param(char *str)if (*str =='=' ) str++; -if (!strncmp (str,"cec_disable" ,7 )) +if (!strcmp (str,"cec_disable" )) ce_arr.disabled =1 ;else return 0 ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.13/ras-cec-use-the-right-length-for-cec_disable.patch