Skip to contentSkip to conversation

ARM: dts: imx6q-novena: Use the 'vpcie-supply' property

PATCH New Fabio Estevam 4 participants 5 messages Oct 15, 2017 – Oct 18, 2017 1 message not in the archive

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v2 1/2 ARM: dts: imx6q-novena: Use the 'vpcie-supply' property

From: Fabio Estevam <[email protected]>

Since commit c26ebe98a103 ("PCI: imx6: Add regulator support"), it is possible to pass the 'vpcie-supply' property to describe the PCIE supply.

This way we can remove the 'regulator-always-on' property from the regulator and have a better device tree description.

Cc Marek Vasut <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- None

 arch/arm/boot/dts/imx6q-novena.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6q-novena.dts +1 -1
index d83cfb6..eadc371 100644
@@ -158,7 +158,6 @@
 		regulator-max-microvolt = <1500000>;
 		gpio = <&gpio7 12 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
-		regulator-always-on;
 	};
 
 	reg_sata: regulator-sata {

@@ -447,6 +446,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_pcie_novena>;
 	reset-gpio = <&gpio3 29 GPIO_ACTIVE_LOW>;
+	vpcie-supply = <&reg_pcie>;
 	status = "okay";
 };
Signature · 1 line
2.7.4
author reviewer
#1 lore raw

PATCH v2 2/2 ARM: dts: imx6q-cm-fx6: Use the 'vpcie-supply' property

From: Fabio Estevam <[email protected]>

According to Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt, the property for specifying the PCIe regulator is 'vpcie-supply', so use the correct one.

Also fix the polarity of GPIO2_24 so that the regulator can operate correctly.

Cc Christopher Spinrath <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Also fix the GPIO2_24 polarity. (Christopher)

 arch/arm/boot/dts/imx6q-cm-fx6.dts | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/arm/boot/dts/imx6q-cm-fx6.dts +2 -3
index fe6ab0a..bc7587c 100644
@@ -77,8 +77,7 @@
 		regulator-name = "regulator-pcie-power-on-gpio";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
-		gpio = <&gpio2 24 GPIO_ACTIVE_HIGH>;
-		enable-active-high;
+		gpio = <&gpio2 24 GPIO_ACTIVE_LOW>;
 	};
 
 	reg_usb_h1_vbus: usb_h1_vbus {

@@ -362,7 +361,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_pcie>;
 	reset-gpio = <&gpio1 26 GPIO_ACTIVE_LOW>;
-	vdd-supply = <&reg_pcie_power_on_gpio>;
+	vpcie-supply = <&reg_pcie_power_on_gpio>;
 	status = "okay";
 };
Signature · 1 line
2.7.4

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

PATCH v2 2/2 ARM: dts: imx6q-cm-fx6: Use the 'vpcie-supply' property

Quoted 11 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

According to Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt, the property for specifying the PCIe regulator is 'vpcie-supply', so use the correct one.

Also fix the polarity of GPIO2_24 so that the regulator can operate correctly.

Cc Christopher Spinrath <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
Tested-by Christopher Spinrath <[email protected]>

Thanks!
Christopher

Quoted 31 lines

---
Changes since v1:
- Also fix the GPIO2_24 polarity. (Christopher)

 arch/arm/boot/dts/imx6q-cm-fx6.dts | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/arm/boot/dts/imx6q-cm-fx6.dts +2 -3
index fe6ab0a..bc7587c 100644
@@ -77,8 +77,7 @@
 		regulator-name = "regulator-pcie-power-on-gpio";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
-		gpio = <&gpio2 24 GPIO_ACTIVE_HIGH>;
-		enable-active-high;
+		gpio = <&gpio2 24 GPIO_ACTIVE_LOW>;
 	};
 
 	reg_usb_h1_vbus: usb_h1_vbus {

@@ -362,7 +361,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_pcie>;
 	reset-gpio = <&gpio1 26 GPIO_ACTIVE_LOW>;
-	vdd-supply = <&reg_pcie_power_on_gpio>;
+	vpcie-supply = <&reg_pcie_power_on_gpio>;
 	status = "okay";
 };
#4 lore raw

PATCH v2 1/2 ARM: dts: imx6q-novena: Use the 'vpcie-supply' property

In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Since commit c26ebe98a103 ("PCI: imx6: Add regulator support"), it is possible to pass the 'vpcie-supply' property to describe the PCIE supply.

This way we can remove the 'regulator-always-on' property from the regulator and have a better device tree description.

Cc Marek Vasut <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
Reviewed-by Marek Vasut <[email protected]>
Quoted 28 lines

---
Changes since v1:
- None

 arch/arm/boot/dts/imx6q-novena.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6q-novena.dts +1 -1
index d83cfb6..eadc371 100644
@@ -158,7 +158,6 @@
 		regulator-max-microvolt = <1500000>;
 		gpio = <&gpio7 12 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
-		regulator-always-on;
 	};
 
 	reg_sata: regulator-sata {

@@ -447,6 +446,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_pcie_novena>;
 	reset-gpio = <&gpio3 29 GPIO_ACTIVE_LOW>;
+	vpcie-supply = <&reg_pcie>;
 	status = "okay";
 };
Signature · 2 lines
Best regards,
Marek Vasut
Applied
#5 lore raw

PATCH v2 1/2 ARM: dts: imx6q-novena: Use the 'vpcie-supply' property

In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Since commit c26ebe98a103 ("PCI: imx6: Add regulator support"), it is possible to pass the 'vpcie-supply' property to describe the PCIE supply.

This way we can remove the 'regulator-always-on' property from the regulator and have a better device tree description.

Cc Marek Vasut <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

Applied both, thanks.