make structure field, function arguments and structures const
Subsystems (21)
v2 cover make structure field, function arguments and structures const
Make the ci_type field and some function arguments as const. After this change, make config_item_type structures as const.
* Changes in v2- Combine all the followup patches and the constification patches into a series.
Bhumika Goyal (15):
configfs: make ci_type field, some pointers and function arguments
const
usb: gadget: make config_item_type structures const
target: make config_item_type const
iio: make function argument and some structures const ocfs2/cluster: make config_item_type const
PCI: endpoint: make config_item_type const
usb: gadget: configfs: make config_item_type const
nvmet: make config_item_type const
ACPI: configfs: make config_item_type const
nullb: make config_item_type const
stm class: make config_item_type const
RDMA/cma: make config_item_type const
netconsole: make config_item_type const
dlm: make config_item_type const
configfs: make config_item_type const
drivers/acpi/acpi_configfs.c | 6 ++-- drivers/block/null_blk.c | 4 +-- drivers/hwtracing/stm/policy.c | 10 +++--- drivers/iio/dummy/iio_simple_dummy.c | 2 +- drivers/iio/industrialio-configfs.c | 2 +- drivers/iio/industrialio-sw-device.c | 6 ++-- drivers/iio/industrialio-sw-trigger.c | 6 ++-- drivers/iio/trigger/iio-trig-hrtimer.c | 2 +- drivers/iio/trigger/iio-trig-loop.c | 2 +- drivers/infiniband/core/cma_configfs.c | 8 ++--- drivers/net/netconsole.c | 4 +-- drivers/nvme/target/configfs.c | 30 ++++++++--------- drivers/pci/endpoint/pci-ep-cfs.c | 12 +++---- drivers/target/iscsi/iscsi_target_stat.c | 12 +++---- drivers/target/target_core_configfs.c | 14 ++++---- drivers/target/target_core_stat.c | 16 ++++----- drivers/usb/gadget/configfs.c | 10 +++--- drivers/usb/gadget/function/f_acm.c | 2 +- drivers/usb/gadget/function/f_ecm.c | 2 +- drivers/usb/gadget/function/f_eem.c | 2 +- drivers/usb/gadget/function/f_fs.c | 2 +- drivers/usb/gadget/function/f_hid.c | 2 +- drivers/usb/gadget/function/f_loopback.c | 2 +- drivers/usb/gadget/function/f_mass_storage.c | 4 +-- drivers/usb/gadget/function/f_midi.c | 2 +- drivers/usb/gadget/function/f_ncm.c | 2 +- drivers/usb/gadget/function/f_obex.c | 2 +- drivers/usb/gadget/function/f_phonet.c | 2 +- drivers/usb/gadget/function/f_printer.c | 2 +- drivers/usb/gadget/function/f_rndis.c | 2 +- drivers/usb/gadget/function/f_serial.c | 2 +- drivers/usb/gadget/function/f_sourcesink.c | 2 +- drivers/usb/gadget/function/f_subset.c | 2 +- drivers/usb/gadget/function/f_tcm.c | 2 +- drivers/usb/gadget/function/f_uac1.c | 2 +- drivers/usb/gadget/function/f_uac1_legacy.c | 2 +- drivers/usb/gadget/function/f_uac2.c | 2 +- drivers/usb/gadget/function/uvc_configfs.c | 50 ++++++++++++++-------------- fs/configfs/dir.c | 10 +++--- fs/configfs/item.c | 6 ++-- fs/configfs/symlink.c | 4 +-- fs/dlm/config.c | 16 ++++----- fs/ocfs2/cluster/heartbeat.c | 4 +-- fs/ocfs2/cluster/nodemanager.c | 8 ++--- include/linux/configfs.h | 8 ++--- include/linux/iio/sw_device.h | 2 +- include/linux/iio/sw_trigger.h | 2 +- include/target/iscsi/iscsi_target_stat.h | 12 +++---- samples/configfs/configfs_sample.c | 8 ++--- 49 files changed, 159 insertions(+), 159 deletions(-)
Signature · 1 line
1.9.1
PATCH v2 1/15 configfs: make ci_type field, some pointers and function arguments const
The ci_type field of the config_item structure do not modify the fields of the config_item_type structure it points to. And the other pointers initialized with ci_type do not modify the fields as well. So, make the ci_type field and the pointers initialized with ci_type as const.
Make the struct config_item_type *type function argument of functions config_{item/group}_init_type_name const as the argument in both the functions is only stored in the ci_type field of a config_item structure which is now made const.
Make the argument of configfs_register_default_group const as it is only passed to the argument of the function config_group_init_type_name which is now const.
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
fs/configfs/dir.c | 10 +++++----- fs/configfs/item.c | 6 +++--- fs/configfs/symlink.c | 4 ++-- include/linux/configfs.h | 8 ++++---- 4 files changed, 14 insertions(+), 14 deletions(-)
fs/configfs/dir.c +5 -5
@@ -584,7 +584,7 @@ static void detach_attrs(struct config_item * item)static int populate_attrs (struct config_item *item) { -struct config_item_type *t = item->ci_type; +const struct config_item_type *t = item->ci_type;struct configfs_attribute *attr;struct configfs_bin_attribute *bin_attr;int error =0 ;
@@ -901,7 +901,7 @@ static void configfs_detach_group(struct config_item *item)static void client_disconnect_notify (struct config_item *parent_item,struct config_item *item) { -struct config_item_type *type; +const struct config_item_type *type; type = parent_item->ci_type;BUG_ON (!type);
@@ -920,7 +920,7 @@ static void client_disconnect_notify(struct config_item *parent_item,static void client_drop_item (struct config_item *parent_item,struct config_item *item) { -struct config_item_type *type; +const struct config_item_type *type; type = parent_item->ci_type;BUG_ON (!type);
@@ -1260,7 +1260,7 @@ static int configfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t modestruct config_item *parent_item;struct configfs_subsystem *subsys;struct configfs_dirent *sd; -struct config_item_type *type; +const struct config_item_type *type;struct module *subsys_owner =NULL , *new_item_owner =NULL ;char *name;
@@ -1810,7 +1810,7 @@ void configfs_unregister_group(struct config_group *group)struct config_group *configfs_register_default_group (struct config_group *parent_group,const char *name, -struct config_item_type *item_type) +const struct config_item_type *item_type) {int ret;struct config_group *group;
fs/configfs/item.c +3 -3
@@ -113,7 +113,7 @@ int config_item_set_name(struct config_item *item, const char *fmt, ...)void config_item_init_type_name (struct config_item *item,const char *name, -struct config_item_type *type) +const struct config_item_type *type) {config_item_set_name (item,"%s" , name); item->ci_type = type;
@@ -122,7 +122,7 @@ void config_item_init_type_name(struct config_item *item,EXPORT_SYMBOL (config_item_init_type_name);void config_group_init_type_name (struct config_group *group,const char *name, -struct config_item_type *type) +const struct config_item_type *type) {config_item_set_name (&group->cg_item,"%s" , name); group->cg_item.ci_type = type;
@@ -148,7 +148,7 @@ struct config_item *config_item_get_unless_zero(struct config_item *item)static void config_item_cleanup (struct config_item *item) { -struct config_item_type *t = item->ci_type; +const struct config_item_type *t = item->ci_type;struct config_group *s = item->ci_group;struct config_item *parent = item->ci_parent;
fs/configfs/symlink.c +2 -2
@@ -138,7 +138,7 @@ int configfs_symlink(struct inode *dir, struct dentry *dentry, const char *symnastruct configfs_dirent *sd;struct config_item *parent_item;struct config_item *target_item =NULL ; -struct config_item_type *type; +const struct config_item_type *type; sd = dentry->d_parent->d_fsdata;/*
@@ -186,7 +186,7 @@ int configfs_unlink(struct inode *dir, struct dentry *dentry)struct configfs_dirent *sd = dentry->d_fsdata;struct configfs_symlink *sl;struct config_item *parent_item; -struct config_item_type *type; +const struct config_item_type *type;int ret; ret = -EPERM ;/* What lack-of-symlink returns */
include/linux/configfs.h +4 -4
@@ -58,7 +58,7 @@ struct config_item {struct list_head ci_entry;struct config_item *ci_parent;struct config_group *ci_group; -struct config_item_type *ci_type; +const struct config_item_type *ci_type;struct dentry *ci_dentry; };
@@ -72,7 +72,7 @@ static inline char *config_item_name(struct config_item * item)extern void config_item_init_type_name (struct config_item *item,const char *name, -struct config_item_type *type); +const struct config_item_type *type);extern struct config_item *config_item_get (struct config_item *);extern struct config_item *config_item_get_unless_zero (struct config_item *);
@@ -101,7 +101,7 @@ struct config_group {extern void config_group_init (struct config_group *group);extern void config_group_init_type_name (struct config_group *group,const char *name, -struct config_item_type *type); +const struct config_item_type *type);static inline struct config_group *to_config_group (struct config_item *item) {
@@ -261,7 +261,7 @@ int configfs_register_group(struct config_group *parent_group,struct config_group *configfs_register_default_group (struct config_group *parent_group,const char *name, -struct config_item_type *item_type); +const struct config_item_type *item_type);void configfs_unregister_default_group (struct config_group *group);/* These functions can sleep and can alloc with GFP_KERNEL */
Signature · 1 line
1.9.1
Re: [PATCH v2 01/15] configfs: make ci_type field, some pointers and function arguments const
Quoted 19 lines · Bhumika Goyal
The
ci_typefield of theconfig_itemstructure do not modify the fields of theconfig_item_typestructure it points to. And the other pointers initialized withci_typedo not modify the fields as well. So, make theci_typefield and the pointers initialized withci_typeas const.Make the struct
config_item_type*type function argument of functions config_{item/group}_init_type_name const as the argument in both the functions is only stored in theci_typefield of aconfig_itemstructure which is now made const.
Make the argument ofconfigfs_register_default_groupconst as it is only passed to the argument of the functionconfig_group_init_type_namewhich is now const.Signed-off-by Bhumika Goyal <[email protected]>---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
Quoted 5 lines
fs/configfs/dir.c | 10 +++++----- fs/configfs/item.c | 6 +++--- fs/configfs/symlink.c | 4 ++-- include/linux/configfs.h | 8 ++++---- 4 files changed, 14 insertions(+), 14 deletions(-)
PATCH v2 2/15 usb: gadget: make config_item_type structures const
In reply to Bhumika GoyalMake these structures const as they are only passed to the const argument of the functions config_{group/item}_init_type_name.
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
drivers/usb/gadget/function/f_acm.c | 2 +- drivers/usb/gadget/function/f_ecm.c | 2 +- drivers/usb/gadget/function/f_eem.c | 2 +- drivers/usb/gadget/function/f_fs.c | 2 +- drivers/usb/gadget/function/f_hid.c | 2 +- drivers/usb/gadget/function/f_loopback.c | 2 +- drivers/usb/gadget/function/f_mass_storage.c | 4 +-- drivers/usb/gadget/function/f_midi.c | 2 +- drivers/usb/gadget/function/f_ncm.c | 2 +- drivers/usb/gadget/function/f_obex.c | 2 +- drivers/usb/gadget/function/f_phonet.c | 2 +- drivers/usb/gadget/function/f_printer.c | 2 +- drivers/usb/gadget/function/f_rndis.c | 2 +- drivers/usb/gadget/function/f_serial.c | 2 +- drivers/usb/gadget/function/f_sourcesink.c | 2 +- drivers/usb/gadget/function/f_subset.c | 2 +- drivers/usb/gadget/function/f_tcm.c | 2 +- drivers/usb/gadget/function/f_uac1.c | 2 +- drivers/usb/gadget/function/f_uac1_legacy.c | 2 +- drivers/usb/gadget/function/f_uac2.c | 2 +- drivers/usb/gadget/function/uvc_configfs.c | 50 ++++++++++++++-------------- 21 files changed, 46 insertions(+), 46 deletions(-)
drivers/usb/gadget/function/f_acm.c +1 -1
@@ -786,7 +786,7 @@ static ssize_t f_acm_port_num_show(struct config_item *item, char *page) NULL, }; -static struct config_item_type acm_func_type = { +static const struct config_item_type acm_func_type = { .ct_item_ops = &acm_item_ops, .ct_attrs = acm_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_ecm.c +1 -1
@@ -845,7 +845,7 @@ static inline struct f_ecm_opts *to_f_ecm_opts(struct config_item *item) NULL, }; -static struct config_item_type ecm_func_type = { +static const struct config_item_type ecm_func_type = { .ct_item_ops = &ecm_item_ops, .ct_attrs = ecm_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_eem.c +1 -1
@@ -556,7 +556,7 @@ static inline struct f_eem_opts *to_f_eem_opts(struct config_item *item) NULL, }; -static struct config_item_type eem_func_type = { +static const struct config_item_type eem_func_type = { .ct_item_ops = &eem_item_ops, .ct_attrs = eem_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_fs.c +1 -1
@@ -3385,7 +3385,7 @@ static void ffs_attr_release(struct config_item *item) .release = ffs_attr_release, }; -static struct config_item_type ffs_func_type = { +static const struct config_item_type ffs_func_type = { .ct_item_ops = &ffs_item_ops, .ct_owner =THIS_MODULE , };
drivers/usb/gadget/function/f_hid.c +1 -1
@@ -992,7 +992,7 @@ static ssize_t f_hid_opts_dev_show(struct config_item *item, char *page) NULL, }; -static struct config_item_type hid_func_type = { +static const struct config_item_type hid_func_type = { .ct_item_ops = &hidg_item_ops, .ct_attrs = hid_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_loopback.c +1 -1
@@ -556,7 +556,7 @@ static ssize_t f_lb_opts_bulk_buflen_store(struct config_item *item, NULL, }; -static struct config_item_type lb_func_type = { +static const struct config_item_type lb_func_type = { .ct_item_ops = &lb_item_ops, .ct_attrs = lb_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_mass_storage.c +2 -2
@@ -3140,7 +3140,7 @@ static ssize_t fsg_lun_opts_inquiry_string_store(struct config_item *item, NULL, }; -static struct config_item_type fsg_lun_type = { +static const struct config_item_type fsg_lun_type = { .ct_item_ops = &fsg_lun_item_ops, .ct_attrs = fsg_lun_attrs, .ct_owner =THIS_MODULE ,
@@ -3331,7 +3331,7 @@ static ssize_t fsg_opts_num_buffers_store(struct config_item *item, .drop_item = fsg_lun_drop, }; -static struct config_item_type fsg_func_type = { +static const struct config_item_type fsg_func_type = { .ct_item_ops = &fsg_item_ops, .ct_group_ops = &fsg_group_ops, .ct_attrs = fsg_attrs,
drivers/usb/gadget/function/f_midi.c +1 -1
@@ -1189,7 +1189,7 @@ static ssize_t f_midi_opts_id_store(struct config_item *item, NULL, }; -static struct config_item_type midi_func_type = { +static const struct config_item_type midi_func_type = { .ct_item_ops = &midi_item_ops, .ct_attrs = midi_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_ncm.c +1 -1
@@ -1568,7 +1568,7 @@ static inline struct f_ncm_opts *to_f_ncm_opts(struct config_item *item) NULL, }; -static struct config_item_type ncm_func_type = { +static const struct config_item_type ncm_func_type = { .ct_item_ops = &ncm_item_ops, .ct_attrs = ncm_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_obex.c +1 -1
@@ -411,7 +411,7 @@ static ssize_t f_obex_port_num_show(struct config_item *item, char *page) NULL, }; -static struct config_item_type obex_func_type = { +static const struct config_item_type obex_func_type = { .ct_item_ops = &obex_item_ops, .ct_attrs = acm_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_phonet.c +1 -1
@@ -599,7 +599,7 @@ static ssize_t f_phonet_ifname_show(struct config_item *item, char *page) NULL, }; -static struct config_item_type phonet_func_type = { +static const struct config_item_type phonet_func_type = { .ct_item_ops = &phonet_item_ops, .ct_attrs = phonet_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_printer.c +1 -1
@@ -1261,7 +1261,7 @@ static ssize_t f_printer_opts_q_len_store(struct config_item *item, NULL, }; -static struct config_item_type printer_func_type = { +static const struct config_item_type printer_func_type = { .ct_item_ops = &printer_item_ops, .ct_attrs = printer_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_rndis.c +1 -1
@@ -890,7 +890,7 @@ static inline struct f_rndis_opts *to_f_rndis_opts(struct config_item *item) NULL, }; -static struct config_item_type rndis_func_type = { +static const struct config_item_type rndis_func_type = { .ct_item_ops = &rndis_item_ops, .ct_attrs = rndis_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_serial.c +1 -1
@@ -281,7 +281,7 @@ static ssize_t f_serial_port_num_show(struct config_item *item, char *page) NULL, }; -static struct config_item_type serial_func_type = { +static const struct config_item_type serial_func_type = { .ct_item_ops = &serial_item_ops, .ct_attrs = acm_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_sourcesink.c +1 -1
@@ -1230,7 +1230,7 @@ static ssize_t f_ss_opts_iso_qlen_store(struct config_item *item, NULL, }; -static struct config_item_type ss_func_type = { +static const struct config_item_type ss_func_type = { .ct_item_ops = &ss_item_ops, .ct_attrs = ss_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_subset.c +1 -1
@@ -412,7 +412,7 @@ static inline struct f_gether_opts *to_f_gether_opts(struct config_item *item) NULL, }; -static struct config_item_type gether_func_type = { +static const struct config_item_type gether_func_type = { .ct_item_ops = &gether_item_ops, .ct_attrs = gether_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_tcm.c +1 -1
@@ -2166,7 +2166,7 @@ static void tcm_attr_release(struct config_item *item) .release = tcm_attr_release, }; -static struct config_item_type tcm_func_type = { +static const struct config_item_type tcm_func_type = { .ct_item_ops = &tcm_item_ops, .ct_owner =THIS_MODULE , };
drivers/usb/gadget/function/f_uac1.c +1 -1
@@ -709,7 +709,7 @@ static void f_uac1_attr_release(struct config_item *item) NULL, }; -static struct config_item_type f_uac1_func_type = { +static const struct config_item_type f_uac1_func_type = { .ct_item_ops = &f_uac1_item_ops, .ct_attrs = f_uac1_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_uac1_legacy.c +1 -1
@@ -921,7 +921,7 @@ static void f_uac1_attr_release(struct config_item *item) NULL, }; -static struct config_item_type f_uac1_func_type = { +static const struct config_item_type f_uac1_func_type = { .ct_item_ops = &f_uac1_item_ops, .ct_attrs = f_uac1_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/f_uac2.c +1 -1
@@ -921,7 +921,7 @@ static void f_uac2_attr_release(struct config_item *item) NULL, }; -static struct config_item_type f_uac2_func_type = { +static const struct config_item_type f_uac2_func_type = { .ct_item_ops = &f_uac2_item_ops, .ct_attrs = f_uac2_attrs, .ct_owner =THIS_MODULE ,
drivers/usb/gadget/function/uvc_configfs.c +25 -25
200 lines not on this page · raw message
Signature · 1 line
1.9.1
Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const
Hi,
Quoted 7 lines · Bhumika Goyal
Make these structures const as they are only passed to the const argument of the functions config_{group/item}_init_type_name.
Signed-off-by Bhumika Goyal <[email protected]>---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
I'm assuming this depends on patch 1 of the series. In that case:
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 832 bytes Desc: not available URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20171017/4363b860/attachment.sig>
Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const
In reply to Bhumika GoyalHi Bhumika,
Thank you for the patch.
Quoted 30 lines · On Monday, 16 October 2017 18:18:41 EEST Bhumika Goyal wrote:
Make these structures const as they are only passed to the const argument of the functions config_{group/item}_init_type_name.
Signed-off-by Bhumika Goyal <[email protected]>---
* Changes in v2- Combine all the followup patches and the constification patches into a series.drivers/usb/gadget/function/f_acm.c | 2 +- drivers/usb/gadget/function/f_ecm.c | 2 +- drivers/usb/gadget/function/f_eem.c | 2 +- drivers/usb/gadget/function/f_fs.c | 2 +- drivers/usb/gadget/function/f_hid.c | 2 +- drivers/usb/gadget/function/f_loopback.c | 2 +- drivers/usb/gadget/function/f_mass_storage.c | 4 +-- drivers/usb/gadget/function/f_midi.c | 2 +- drivers/usb/gadget/function/f_ncm.c | 2 +- drivers/usb/gadget/function/f_obex.c | 2 +- drivers/usb/gadget/function/f_phonet.c | 2 +- drivers/usb/gadget/function/f_printer.c | 2 +- drivers/usb/gadget/function/f_rndis.c | 2 +- drivers/usb/gadget/function/f_serial.c | 2 +- drivers/usb/gadget/function/f_sourcesink.c | 2 +- drivers/usb/gadget/function/f_subset.c | 2 +- drivers/usb/gadget/function/f_tcm.c | 2 +- drivers/usb/gadget/function/f_uac1.c | 2 +- drivers/usb/gadget/function/f_uac1_legacy.c | 2 +- drivers/usb/gadget/function/f_uac2.c | 2 +- drivers/usb/gadget/function/uvc_configfs.c | 50 ++++++++++++------------ 21 files changed, 46 insertions(+), 46 deletions(-)
[snip]
Quoted 212 lines
(quoted diff) +0
-0
b/drivers/usb/gadget/function/uvc_configfs.cindex 844cb73..f76619f 100644drivers/usb/gadget/function/uvc_configfs.c +23
-23@@ -127,7 +127,7 @@ static struct uvcg_control_header *to_uvcg_control_header(struct config_item *it NULL, }; -static struct config_item_type uvcg_control_header_type = { +static const struct config_item_type uvcg_control_header_type = { .ct_attrs = uvcg_control_header_attrs, .ct_owner =THIS_MODULE , };@@ -170,7 +170,7 @@ static void uvcg_control_header_drop(struct config_group *group, .drop_item = uvcg_control_header_drop, }; -static struct config_item_type uvcg_control_header_grp_type = { +static const struct config_item_type uvcg_control_header_grp_type = { .ct_group_ops = &uvcg_control_header_grp_ops, .ct_owner =THIS_MODULE , };@@ -265,7 +265,7 @@ static ssize_t uvcg_default_processing_bm_controls_show( NULL, }; -static struct config_item_type uvcg_default_processing_type = { +static const struct config_item_type uvcg_default_processing_type = { .ct_attrs = uvcg_default_processing_attrs, .ct_owner =THIS_MODULE , };@@ -277,7 +277,7 @@ static ssize_t uvcg_default_processing_bm_controls_show(struct config_group group; } uvcg_processing_grp; -static struct config_item_type uvcg_processing_grp_type = { +static const struct config_item_type uvcg_processing_grp_type = { .ct_owner =THIS_MODULE , };@@ -382,7 +382,7 @@ static ssize_t uvcg_default_camera_bm_controls_show( NULL, }; -static struct config_item_type uvcg_default_camera_type = { +static const struct config_item_type uvcg_default_camera_type = { .ct_attrs = uvcg_default_camera_attrs, .ct_owner =THIS_MODULE , };@@ -394,7 +394,7 @@ static ssize_t uvcg_default_camera_bm_controls_show(struct config_group group; } uvcg_camera_grp; -static struct config_item_type uvcg_camera_grp_type = { +static const struct config_item_type uvcg_camera_grp_type = { .ct_owner =THIS_MODULE , };@@ -460,7 +460,7 @@ static ssize_t uvcg_default_camera_bm_controls_show( NULL, }; -static struct config_item_type uvcg_default_output_type = { +static const struct config_item_type uvcg_default_output_type = { .ct_attrs = uvcg_default_output_attrs, .ct_owner =THIS_MODULE , };@@ -472,7 +472,7 @@ static ssize_t uvcg_default_camera_bm_controls_show(struct config_group group; } uvcg_output_grp; -static struct config_item_type uvcg_output_grp_type = { +static const struct config_item_type uvcg_output_grp_type = { .ct_owner =THIS_MODULE , };@@ -481,7 +481,7 @@ static ssize_t uvcg_default_camera_bm_controls_show(struct config_group group; } uvcg_terminal_grp; -static struct config_item_type uvcg_terminal_grp_type = { +static const struct config_item_type uvcg_terminal_grp_type = { .ct_owner =THIS_MODULE , };@@ -586,7 +586,7 @@ static void uvcg_control_class_drop_link(struct config_item *src, .drop_link = uvcg_control_class_drop_link, }; -static struct config_item_type uvcg_control_class_type = { +static const struct config_item_type uvcg_control_class_type = { .ct_item_ops = &uvcg_control_class_item_ops, .ct_owner =THIS_MODULE , };@@ -596,7 +596,7 @@ static void uvcg_control_class_drop_link(struct config_item *src, struct config_group group; } uvcg_control_class_grp; -static struct config_item_type uvcg_control_class_grp_type = { +static const struct config_item_type uvcg_control_class_grp_type = { .ct_owner =THIS_MODULE , };@@ -605,7 +605,7 @@ static void uvcg_control_class_drop_link(struct config_item *src, struct config_group group; } uvcg_control_grp; -static struct config_item_type uvcg_control_grp_type = { +static const struct config_item_type uvcg_control_grp_type = { .ct_owner =THIS_MODULE , };@@ -857,7 +857,7 @@ static void uvcg_streaming_header_drop_link(struct config_item *src, NULL, }; -static struct config_item_type uvcg_streaming_header_type = { +static const struct config_item_type uvcg_streaming_header_type = { .ct_item_ops = &uvcg_streaming_header_item_ops, .ct_attrs = uvcg_streaming_header_attrs, .ct_owner =THIS_MODULE ,@@ -901,7 +901,7 @@ static void uvcg_streaming_header_drop(struct config_group *group, .drop_item = uvcg_streaming_header_drop, }; -static struct config_item_type uvcg_streaming_header_grp_type = { +static const struct config_item_type uvcg_streaming_header_grp_type = { .ct_group_ops = &uvcg_streaming_header_grp_ops, .ct_owner =THIS_MODULE , };@@ -1150,7 +1150,7 @@ static ssize_t uvcg_frame_dw_frame_interval_store(struct config_item *item, NULL, }; -static struct config_item_type uvcg_frame_type = { +static const struct config_item_type uvcg_frame_type = { .ct_attrs = uvcg_frame_attrs, .ct_owner =THIS_MODULE , };@@ -1419,7 +1419,7 @@ static ssize_t uvcg_uncompressed_guid_format_store(struct config_item *item, NULL, }; -static struct config_item_type uvcg_uncompressed_type = { +static const struct config_item_type uvcg_uncompressed_type = { .ct_group_ops = &uvcg_uncompressed_group_ops, .ct_attrs = uvcg_uncompressed_attrs, .ct_owner =THIS_MODULE ,@@ -1469,7 +1469,7 @@ static void uvcg_uncompressed_drop(struct config_group *group, .drop_item = uvcg_uncompressed_drop, }; -static struct config_item_type uvcg_uncompressed_grp_type = { +static const struct config_item_type uvcg_uncompressed_grp_type = { .ct_group_ops = &uvcg_uncompressed_grp_ops, .ct_owner =THIS_MODULE , };@@ -1619,7 +1619,7 @@ static struct uvcg_mjpeg *to_uvcg_mjpeg(struct config_item *item) NULL, }; -static struct config_item_type uvcg_mjpeg_type = { +static const struct config_item_type uvcg_mjpeg_type = { .ct_group_ops = &uvcg_mjpeg_group_ops, .ct_attrs = uvcg_mjpeg_attrs, .ct_owner =THIS_MODULE ,@@ -1663,7 +1663,7 @@ static void uvcg_mjpeg_drop(struct config_group *group, .drop_item = uvcg_mjpeg_drop, }; -static struct config_item_type uvcg_mjpeg_grp_type = { +static const struct config_item_type uvcg_mjpeg_grp_type = { .ct_group_ops = &uvcg_mjpeg_grp_ops, .ct_owner =THIS_MODULE , };@@ -1728,7 +1728,7 @@ static void uvcg_mjpeg_drop(struct config_group *group, NULL, }; -static struct config_item_type uvcg_default_color_matching_type = { +static const struct config_item_type uvcg_default_color_matching_type = { .ct_attrs = uvcg_default_color_matching_attrs, .ct_owner =THIS_MODULE , };@@ -1740,7 +1740,7 @@ static void uvcg_mjpeg_drop(struct config_group *group, struct config_group group; } uvcg_color_matching_grp; -static struct config_item_type uvcg_color_matching_grp_type = { +static const struct config_item_type uvcg_color_matching_grp_type = { .ct_owner =THIS_MODULE , };@@ -2085,7 +2085,7 @@ static void uvcg_streaming_class_drop_link(struct config_item *src, .drop_link = uvcg_streaming_class_drop_link, }; -static struct config_item_type uvcg_streaming_class_type = { +static const struct config_item_type uvcg_streaming_class_type = { .ct_item_ops = &uvcg_streaming_class_item_ops, .ct_owner =THIS_MODULE , };@@ -2095,7 +2095,7 @@ static void uvcg_streaming_class_drop_link(struct config_item *src, struct config_group group; } uvcg_streaming_class_grp; -static struct config_item_type uvcg_streaming_class_grp_type = { +static const struct config_item_type uvcg_streaming_class_grp_type = { .ct_owner =THIS_MODULE , };
drivers/usb/gadget/function/uvc_configfs.c static void uvcg_streaming_class_drop_link(struct · line 2109
Quoted 7 lines
drivers/usb/gadget/function/uvc_configfs.c +1
-1@@ -2104,7 +2104,7 @@ static void uvcg_streaming_class_drop_link(struct config_item *src, struct config_group group; } uvcg_streaming_grp; -static struct config_item_type uvcg_streaming_grp_type = { +static const struct config_item_type uvcg_streaming_grp_type = { .ct_owner =THIS_MODULE , };
Now we have 9 const instances of the config_item_type structure that are identical, with only the .ct_owner field set. Should they be all merged into a single structure ?
Quoted 9 lines
drivers/usb/gadget/function/uvc_configfs.c +1
-1@@ -2190,7 +2190,7 @@ static void uvc_attr_release(struct config_item *item) NULL, }; -static struct config_item_type uvc_func_type = { +static const struct config_item_type uvc_func_type = { .ct_item_ops = &uvc_item_ops, .ct_attrs = uvc_attrs, .ct_owner =THIS_MODULE ,
Signature · 3 lines
Regards, Laurent Pinchart
Christoph Hellwig
maintainerRe: [PATCH v2 02/15] usb: gadget: make config_item_type structures const
Quoted 4 lines
Now we have 9 const instances of the
config_item_typestructure that are identical, with only the .ct_owner field set. Should they be all merged into a single structure ?
I think that's a good idea.
But I'm about to slurp up this whole series into my tree, how about making that an incremental patch?
Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const
Hi Christoph,
Quoted 8 lines · On Thursday, 19 October 2017 17:06:57 EEST Christoph Hellwig wrote:
Quoted 3 lines
Now we have 9 const instances of the
config_item_typestructure that are identical, with only the .ct_owner field set. Should they be all merged into a single structure ?I think that's a good idea.
But I'm about to slurp up this whole series into my tree, how about making that an incremental patch?
I'm fine with that.
Bhumika, would you like to submit an incremental patch, or should I do it ?
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const
Quoted 7 lines · Laurent Pinchart
Hi Christoph,
Quoted 4 lines · On Thursday, 19 October 2017 17:06:57 EEST Christoph Hellwig wrote:
Quoted 3 lines
Now we have 9 const instances of the
config_item_typestructure that are identical, with only the .ct_owner field set. Should they be all merged into a single structure ?
Quoted 8 lines
Quoted 4 lines
I think that's a good idea.
But I'm about to slurp up this whole series into my tree, how about making that an incremental patch?
I'm fine with that.
Bhumika, would you like to submit an incremental patch, or should I do it ?
For various types, there seem to be a few hundred of these, eg:
static const struct hda_pcm_stream alc269_44k_pcm_analog_playback = {
.rates = SNDRV_PCM_RATE_44100, /* fixed rate */
};static const struct hda_pcm_stream alc269_44k_pcm_analog_capture = {
.rates = SNDRV_PCM_RATE_44100, /* fixed rate */
};Would it be desirable to remove them? I guess one would have to check that there are not any pointer equality checks on these values. Would it be useful to put a #define to keep the orignal names?
julia
Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const
In reply to Laurent PinchartQuoted 7 lines · Laurent Pinchart
Hi Christoph,
Quoted 4 lines · On Thursday, 19 October 2017 17:06:57 EEST Christoph Hellwig wrote:
Quoted 3 lines
Now we have 9 const instances of the
config_item_typestructure that are identical, with only the .ct_owner field set. Should they be all merged into a single structure ?
Quoted 9 lines
Quoted 4 lines
I think that's a good idea.
But I'm about to slurp up this whole series into my tree, how about making that an incremental patch?
I'm fine with that.
Bhumika, would you like to submit an incremental patch, or should I do it ?
I will submit a patch for merging these structures.
But should I make a separate patch for this particular change or send a v3 for the whole series?
Thanks,
Bhumika
Quoted 5 lines
--
Regards,Laurent Pinchart
PATCH v2 3/15 target: make config_item_type const
In reply to Bhumika GoyalMake these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure.
Done using Coccinelle.
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
drivers/target/iscsi/iscsi_target_stat.c | 12 ++++++------ drivers/target/target_core_configfs.c | 14 +++++++------- drivers/target/target_core_stat.c | 16 ++++++++-------- include/target/iscsi/iscsi_target_stat.h | 12 ++++++------ 4 files changed, 27 insertions(+), 27 deletions(-)
drivers/target/iscsi/iscsi_target_stat.c +6 -6
@@ -187,7 +187,7 @@ static ssize_t iscsi_stat_instance_version_show(struct config_item *item, NULL, }; -struct config_item_type iscsi_stat_instance_cit = { +const struct config_item_type iscsi_stat_instance_cit = { .ct_attrs = iscsi_stat_instance_attrs, .ct_owner =THIS_MODULE , };
@@ -249,7 +249,7 @@ static ssize_t iscsi_stat_sess_err_format_errors_show(struct config_item *item, NULL, }; -struct config_item_type iscsi_stat_sess_err_cit = { +const struct config_item_type iscsi_stat_sess_err_cit = { .ct_attrs = iscsi_stat_sess_err_attrs, .ct_owner =THIS_MODULE , };
@@ -390,7 +390,7 @@ static ssize_t iscsi_stat_tgt_attr_fail_intr_addr_show(struct config_item *item, NULL, }; -struct config_item_type iscsi_stat_tgt_attr_cit = { +const struct config_item_type iscsi_stat_tgt_attr_cit = { .ct_attrs = iscsi_stat_tgt_attr_attrs, .ct_owner =THIS_MODULE , };
@@ -522,7 +522,7 @@ static ssize_t iscsi_stat_login_negotiate_fails_show(struct config_item *item, NULL, }; -struct config_item_type iscsi_stat_login_cit = { +const struct config_item_type iscsi_stat_login_cit = { .ct_attrs = iscsi_stat_login_stats_attrs, .ct_owner =THIS_MODULE , };
@@ -579,7 +579,7 @@ static ssize_t iscsi_stat_logout_abnormal_logouts_show(struct config_item *item, NULL, }; -struct config_item_type iscsi_stat_logout_cit = { +const struct config_item_type iscsi_stat_logout_cit = { .ct_attrs = iscsi_stat_logout_stats_attrs, .ct_owner =THIS_MODULE , };
@@ -801,7 +801,7 @@ static ssize_t iscsi_stat_sess_conn_timeout_errors_show( NULL, }; -struct config_item_type iscsi_stat_sess_cit = { +const struct config_item_type iscsi_stat_sess_cit = { .ct_attrs = iscsi_stat_sess_stats_attrs, .ct_owner =THIS_MODULE , };
drivers/target/target_core_configfs.c +7 -7
@@ -307,7 +307,7 @@ static void target_core_deregister_fabric(/* * Provides Fabrics Groups and Item Attributes for /sys/kernel/config/target/ */ -static struct config_item_type target_core_fabrics_item = { +static const struct config_item_type target_core_fabrics_item = { .ct_group_ops = &target_core_fabric_group_ops, .ct_attrs = target_core_fabric_item_attrs, .ct_owner =THIS_MODULE ,
@@ -2376,7 +2376,7 @@ static void target_core_alua_lu_gp_release(struct config_item *item) .release = target_core_alua_lu_gp_release, }; -static struct config_item_type target_core_alua_lu_gp_cit = { +static const struct config_item_type target_core_alua_lu_gp_cit = { .ct_item_ops = &target_core_alua_lu_gp_ops, .ct_attrs = target_core_alua_lu_gp_attrs, .ct_owner =THIS_MODULE ,
@@ -2434,7 +2434,7 @@ static void target_core_alua_drop_lu_gp( .drop_item = &target_core_alua_drop_lu_gp, }; -static struct config_item_type target_core_alua_lu_gps_cit = { +static const struct config_item_type target_core_alua_lu_gps_cit = { .ct_item_ops =NULL , .ct_group_ops = &target_core_alua_lu_gps_group_ops, .ct_owner =THIS_MODULE ,
@@ -2813,7 +2813,7 @@ static void target_core_alua_tg_pt_gp_release(struct config_item *item) .release = target_core_alua_tg_pt_gp_release, }; -static struct config_item_type target_core_alua_tg_pt_gp_cit = { +static const struct config_item_type target_core_alua_tg_pt_gp_cit = { .ct_item_ops = &target_core_alua_tg_pt_gp_ops, .ct_attrs = target_core_alua_tg_pt_gp_attrs, .ct_owner =THIS_MODULE ,
@@ -2884,7 +2884,7 @@ static void target_core_alua_drop_tg_pt_gp(* core/alua/lu_gps and core/alua/tg_pt_gps that are attached to * target_core_alua_cit in target_core_init_configfs() below. */ -static struct config_item_type target_core_alua_cit = { +static const struct config_item_type target_core_alua_cit = { .ct_item_ops =NULL , .ct_attrs =NULL , .ct_owner =THIS_MODULE ,
@@ -3105,7 +3105,7 @@ static void target_core_hba_release(struct config_item *item) .release = target_core_hba_release, }; -static struct config_item_type target_core_hba_cit = { +static const struct config_item_type target_core_hba_cit = { .ct_item_ops = &target_core_hba_item_ops, .ct_group_ops = &target_core_hba_group_ops, .ct_attrs = target_core_hba_attrs,
@@ -3188,7 +3188,7 @@ static void target_core_call_delhbafromtarget( .drop_item = target_core_call_delhbafromtarget, }; -static struct config_item_type target_core_cit = { +static const struct config_item_type target_core_cit = { .ct_item_ops =NULL , .ct_group_ops = &target_core_group_ops, .ct_attrs =NULL ,
drivers/target/target_core_stat.c +8 -8
@@ -96,7 +96,7 @@ static ssize_t target_stat_ports_show(struct config_item *item, char *page) NULL, }; -static struct config_item_type target_stat_scsi_dev_cit = { +static const struct config_item_type target_stat_scsi_dev_cit = { .ct_attrs = target_stat_scsi_dev_attrs, .ct_owner =THIS_MODULE , };
@@ -193,7 +193,7 @@ static ssize_t target_stat_tgt_aborts_no_task_show(struct config_item *item, NULL, }; -static struct config_item_type target_stat_scsi_tgt_dev_cit = { +static const struct config_item_type target_stat_scsi_tgt_dev_cit = { .ct_attrs = target_stat_scsi_tgt_dev_attrs, .ct_owner =THIS_MODULE , };
@@ -414,7 +414,7 @@ static ssize_t target_stat_lu_creation_time_show(struct config_item *item, NULL, }; -static struct config_item_type target_stat_scsi_lu_cit = { +static const struct config_item_type target_stat_scsi_lu_cit = { .ct_attrs = target_stat_scsi_lu_attrs, .ct_owner =THIS_MODULE , };
@@ -540,7 +540,7 @@ static ssize_t target_stat_port_busy_count_show(struct config_item *item, NULL, }; -static struct config_item_type target_stat_scsi_port_cit = { +static const struct config_item_type target_stat_scsi_port_cit = { .ct_attrs = target_stat_scsi_port_attrs, .ct_owner =THIS_MODULE , };
@@ -724,7 +724,7 @@ static ssize_t target_stat_tgt_port_hs_in_cmds_show(struct config_item *item, NULL, }; -static struct config_item_type target_stat_scsi_tgt_port_cit = { +static const struct config_item_type target_stat_scsi_tgt_port_cit = { .ct_attrs = target_stat_scsi_tgt_port_attrs, .ct_owner =THIS_MODULE , };
@@ -844,7 +844,7 @@ static ssize_t target_stat_transport_proto_id_show(struct config_item *item, NULL, }; -static struct config_item_type target_stat_scsi_transport_cit = { +static const struct config_item_type target_stat_scsi_transport_cit = { .ct_attrs = target_stat_scsi_transport_attrs, .ct_owner =THIS_MODULE , };
@@ -1206,7 +1206,7 @@ static ssize_t target_stat_auth_row_status_show(struct config_item *item, NULL, }; -static struct config_item_type target_stat_scsi_auth_intr_cit = { +static const struct config_item_type target_stat_scsi_auth_intr_cit = { .ct_attrs = target_stat_scsi_auth_intr_attrs, .ct_owner =THIS_MODULE , };
@@ -1378,7 +1378,7 @@ static ssize_t target_stat_iport_port_ident_show(struct config_item *item, NULL, }; -static struct config_item_type target_stat_scsi_att_intr_port_cit = { +static const struct config_item_type target_stat_scsi_att_intr_port_cit = { .ct_attrs = target_stat_scsi_ath_intr_port_attrs, .ct_owner =THIS_MODULE , };
include/target/iscsi/iscsi_target_stat.h +6 -6
@@ -8,16 +8,16 @@/* * For struct iscsi_tiqn->tiqn_wwn default groups */ -extern struct config_item_type iscsi_stat_instance_cit; -extern struct config_item_type iscsi_stat_sess_err_cit; -extern struct config_item_type iscsi_stat_tgt_attr_cit; -extern struct config_item_type iscsi_stat_login_cit; -extern struct config_item_type iscsi_stat_logout_cit; +extern const struct config_item_type iscsi_stat_instance_cit; +extern const struct config_item_type iscsi_stat_sess_err_cit; +extern const struct config_item_type iscsi_stat_tgt_attr_cit; +extern const struct config_item_type iscsi_stat_login_cit; +extern const struct config_item_type iscsi_stat_logout_cit;/* * For struct iscsi_session->se_sess default groups */ -extern struct config_item_type iscsi_stat_sess_cit; +extern const struct config_item_type iscsi_stat_sess_cit;/* iSCSI session error types */ #define ISCSI_SESS_ERR_UNKNOWN 0
Signature · 1 line
1.9.1
PATCH v2 4/15 iio: make function argument and some structures const
In reply to Bhumika GoyalMake the argument of the functions iio_sw{d/t}_group_init_type_name const as they are only passed to the function config_group_init_type_name having the argument as const.
Make the config_item_type structures const as they are either passed to the functions having the argument as const or they are stored in the const "ci_type" field of a config_item structure.
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
drivers/iio/dummy/iio_simple_dummy.c | 2 +- drivers/iio/industrialio-configfs.c | 2 +- drivers/iio/industrialio-sw-device.c | 6 +++--- drivers/iio/industrialio-sw-trigger.c | 6 +++--- drivers/iio/trigger/iio-trig-hrtimer.c | 2 +- drivers/iio/trigger/iio-trig-loop.c | 2 +- include/linux/iio/sw_device.h | 2 +- include/linux/iio/sw_trigger.h | 2 +- 8 files changed, 12 insertions(+), 12 deletions(-)
drivers/iio/dummy/iio_simple_dummy.c +1 -1
@@ -26,7 +26,7 @@#include <linux/iio/sw_device.h> #include "iio_simple_dummy.h" -static struct config_item_type iio_dummy_type = { +static const struct config_item_type iio_dummy_type = { .ct_owner =THIS_MODULE , };
drivers/iio/industrialio-configfs.c +1 -1
@@ -17,7 +17,7 @@#include <linux/iio/iio.h> #include <linux/iio/configfs.h> -static struct config_item_type iio_root_group_type = { +static const struct config_item_type iio_root_group_type = { .ct_owner =THIS_MODULE , };
drivers/iio/industrialio-sw-device.c +3 -3
@@ -19,9 +19,9 @@#include <linux/configfs.h> static struct config_group *iio_devices_group; -static struct config_item_type iio_device_type_group_type; +static const struct config_item_type iio_device_type_group_type; -static struct config_item_type iio_devices_group_type = { +static const struct config_item_type iio_devices_group_type = { .ct_owner =THIS_MODULE , };
@@ -156,7 +156,7 @@ static void device_drop_group(struct config_group *group, .drop_item = &device_drop_group, }; -static struct config_item_type iio_device_type_group_type = { +static const struct config_item_type iio_device_type_group_type = { .ct_group_ops = &device_ops, .ct_owner =THIS_MODULE , };
drivers/iio/industrialio-sw-trigger.c +3 -3
@@ -19,9 +19,9 @@#include <linux/configfs.h> static struct config_group *iio_triggers_group; -static struct config_item_type iio_trigger_type_group_type; +static const struct config_item_type iio_trigger_type_group_type; -static struct config_item_type iio_triggers_group_type = { +static const struct config_item_type iio_triggers_group_type = { .ct_owner =THIS_MODULE , };
@@ -156,7 +156,7 @@ static void trigger_drop_group(struct config_group *group, .drop_item = &trigger_drop_group, }; -static struct config_item_type iio_trigger_type_group_type = { +static const struct config_item_type iio_trigger_type_group_type = { .ct_group_ops = &trigger_ops, .ct_owner =THIS_MODULE , };
drivers/iio/trigger/iio-trig-hrtimer.c +1 -1
@@ -30,7 +30,7 @@ struct iio_hrtimer_info {ktime_t period; }; -static struct config_item_type iio_hrtimer_type = { +static const struct config_item_type iio_hrtimer_type = { .ct_owner =THIS_MODULE , };
drivers/iio/trigger/iio-trig-loop.c +1 -1
@@ -36,7 +36,7 @@ struct iio_loop_info {struct task_struct *task; }; -static struct config_item_type iio_loop_type = { +static const struct config_item_type iio_loop_type = { .ct_owner =THIS_MODULE , };
include/linux/iio/sw_device.h +1 -1
@@ -60,7 +60,7 @@ struct iio_sw_device *to_iio_sw_device(struct config_item *item)static inline void iio_swd_group_init_type_name (struct iio_sw_device *d,const char *name, -struct config_item_type *type) +const struct config_item_type *type) {#if IS_ENABLED (CONFIG_CONFIGFS_FS )config_group_init_type_name (&d->group, name, type);
include/linux/iio/sw_trigger.h +1 -1
@@ -60,7 +60,7 @@ struct iio_sw_trigger *to_iio_sw_trigger(struct config_item *item)static inline void iio_swt_group_init_type_name (struct iio_sw_trigger *t,const char *name, -struct config_item_type *type) +const struct config_item_type *type) {#if IS_ENABLED (CONFIG_CONFIGFS_FS )config_group_init_type_name (&t->group, name, type);
Signature · 1 line
1.9.1
Re: [PATCH v2 04/15] iio: make function argument and some structures const
Quoted 11 lines · Bhumika Goyal
Make the argument of the functions iio_sw{d/t}_group_init_type_name const
as they are only passed to the functionconfig_group_init_type_namehaving
the argument as const.Make the
config_item_typestructures const as they are either passed to the functions having the argument as const or they are stored in the const "ci_type" field of aconfig_itemstructure.Signed-off-by Bhumika Goyal <[email protected]>
Quoted 155 lines
---
* Changes in v2- Combine all the followup patches and the constification
patches into a series.drivers/iio/dummy/iio_simple_dummy.c | 2 +- drivers/iio/industrialio-configfs.c | 2 +- drivers/iio/industrialio-sw-device.c | 6 +++--- drivers/iio/industrialio-sw-trigger.c | 6 +++--- drivers/iio/trigger/iio-trig-hrtimer.c | 2 +- drivers/iio/trigger/iio-trig-loop.c | 2 +- include/linux/iio/sw_device.h | 2 +- include/linux/iio/sw_trigger.h | 2 +- 8 files changed, 12 insertions(+), 12 deletions(-)drivers/iio/dummy/iio_simple_dummy.c +1
-1@@ -26,7 +26,7 @@#include <linux/iio/sw_device.h> #include "iio_simple_dummy.h" -static struct config_item_type iio_dummy_type = { +static const struct config_item_type iio_dummy_type = { .ct_owner =THIS_MODULE , };drivers/iio/industrialio-configfs.c +1
-1@@ -17,7 +17,7 @@#include <linux/iio/iio.h> #include <linux/iio/configfs.h> -static struct config_item_type iio_root_group_type = { +static const struct config_item_type iio_root_group_type = { .ct_owner =THIS_MODULE , };drivers/iio/industrialio-sw-device.c +3
-3@@ -19,9 +19,9 @@#include <linux/configfs.h> static struct config_group *iio_devices_group; -static struct config_item_type iio_device_type_group_type; +static const struct config_item_type iio_device_type_group_type; -static struct config_item_type iio_devices_group_type = { +static const struct config_item_type iio_devices_group_type = { .ct_owner =THIS_MODULE , };@@ -156,7 +156,7 @@ static void device_drop_group(struct config_group *group, .drop_item = &device_drop_group, }; -static struct config_item_type iio_device_type_group_type = { +static const struct config_item_type iio_device_type_group_type = { .ct_group_ops = &device_ops, .ct_owner =THIS_MODULE ,};
drivers/iio/industrialio-sw-trigger.c +3
-3@@ -19,9 +19,9 @@#include <linux/configfs.h> static struct config_group *iio_triggers_group; -static struct config_item_type iio_trigger_type_group_type; +static const struct config_item_type iio_trigger_type_group_type; -static struct config_item_type iio_triggers_group_type = { +static const struct config_item_type iio_triggers_group_type = { .ct_owner =THIS_MODULE , };@@ -156,7 +156,7 @@ static void trigger_drop_group(struct config_group *group, .drop_item = &trigger_drop_group, }; -static struct config_item_type iio_trigger_type_group_type = { +static const struct config_item_type iio_trigger_type_group_type = { .ct_group_ops = &trigger_ops, .ct_owner =THIS_MODULE ,};
drivers/iio/trigger/iio-trig-hrtimer.c +1
-1@@ -30,7 +30,7 @@ struct iio_hrtimer_info {ktime_t period; }; -static struct config_item_type iio_hrtimer_type = { +static const struct config_item_type iio_hrtimer_type = { .ct_owner =THIS_MODULE , };drivers/iio/trigger/iio-trig-loop.c +1
-1@@ -36,7 +36,7 @@ struct iio_loop_info {struct task_struct *task; }; -static struct config_item_type iio_loop_type = { +static const struct config_item_type iio_loop_type = { .ct_owner =THIS_MODULE , };include/linux/iio/sw_device.h +0
-0@@ -60,7 +60,7 @@ struct iio_sw_device *to_iio_sw_device(struct config_item *item)static inline
void iio_swd_group_init_type_name(structiio_sw_device*d,
const char *name,include/linux/iio/sw_device.h +1
-1- struct config_item_type *type) + const struct config_item_type *type){
#if IS_ENABLED(CONFIG_CONFIGFS_FS) config_group_init_type_name(&d->group, name, type);include/linux/iio/sw_trigger.h +0
-0@@ -60,7 +60,7 @@ struct iio_sw_trigger *to_iio_sw_trigger(struct config_item *item)static inline
void iio_swt_group_init_type_name(structiio_sw_trigger*t,
const char *name,include/linux/iio/sw_trigger.h +1
-1- struct config_item_type *type) + const struct config_item_type *type){
#if IS_ENABLED(CONFIG_CONFIGFS_FS) config_group_init_type_name(&t->group, name, type);
Signature · 1 line
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Re: [PATCH v2 04/15] iio: make function argument and some structures const
In reply to Bhumika GoyalQuoted 11 lines · Bhumika Goyal
Make the argument of the functions iio_sw{d/t}_group_init_type_name const
as they are only passed to the functionconfig_group_init_type_namehaving
the argument as const.Make the
config_item_typestructures const as they are either passed to the functions having the argument as const or they are stored in the const "ci_type" field of aconfig_itemstructure.Signed-off-by Bhumika Goyal <[email protected]>
Quoted 155 lines
---
* Changes in v2- Combine all the followup patches and the constification
patches into a series.drivers/iio/dummy/iio_simple_dummy.c | 2 +- drivers/iio/industrialio-configfs.c | 2 +- drivers/iio/industrialio-sw-device.c | 6 +++--- drivers/iio/industrialio-sw-trigger.c | 6 +++--- drivers/iio/trigger/iio-trig-hrtimer.c | 2 +- drivers/iio/trigger/iio-trig-loop.c | 2 +- include/linux/iio/sw_device.h | 2 +- include/linux/iio/sw_trigger.h | 2 +- 8 files changed, 12 insertions(+), 12 deletions(-)drivers/iio/dummy/iio_simple_dummy.c +1
-1@@ -26,7 +26,7 @@#include <linux/iio/sw_device.h> #include "iio_simple_dummy.h" -static struct config_item_type iio_dummy_type = { +static const struct config_item_type iio_dummy_type = { .ct_owner =THIS_MODULE , };drivers/iio/industrialio-configfs.c +1
-1@@ -17,7 +17,7 @@#include <linux/iio/iio.h> #include <linux/iio/configfs.h> -static struct config_item_type iio_root_group_type = { +static const struct config_item_type iio_root_group_type = { .ct_owner =THIS_MODULE , };drivers/iio/industrialio-sw-device.c +3
-3@@ -19,9 +19,9 @@#include <linux/configfs.h> static struct config_group *iio_devices_group; -static struct config_item_type iio_device_type_group_type; +static const struct config_item_type iio_device_type_group_type; -static struct config_item_type iio_devices_group_type = { +static const struct config_item_type iio_devices_group_type = { .ct_owner =THIS_MODULE , };@@ -156,7 +156,7 @@ static void device_drop_group(struct config_group *group, .drop_item = &device_drop_group, }; -static struct config_item_type iio_device_type_group_type = { +static const struct config_item_type iio_device_type_group_type = { .ct_group_ops = &device_ops, .ct_owner =THIS_MODULE ,};
drivers/iio/industrialio-sw-trigger.c +3
-3@@ -19,9 +19,9 @@#include <linux/configfs.h> static struct config_group *iio_triggers_group; -static struct config_item_type iio_trigger_type_group_type; +static const struct config_item_type iio_trigger_type_group_type; -static struct config_item_type iio_triggers_group_type = { +static const struct config_item_type iio_triggers_group_type = { .ct_owner =THIS_MODULE , };@@ -156,7 +156,7 @@ static void trigger_drop_group(struct config_group *group, .drop_item = &trigger_drop_group, }; -static struct config_item_type iio_trigger_type_group_type = { +static const struct config_item_type iio_trigger_type_group_type = { .ct_group_ops = &trigger_ops, .ct_owner =THIS_MODULE ,};
drivers/iio/trigger/iio-trig-hrtimer.c +1
-1@@ -30,7 +30,7 @@ struct iio_hrtimer_info {ktime_t period; }; -static struct config_item_type iio_hrtimer_type = { +static const struct config_item_type iio_hrtimer_type = { .ct_owner =THIS_MODULE , };drivers/iio/trigger/iio-trig-loop.c +1
-1@@ -36,7 +36,7 @@ struct iio_loop_info {struct task_struct *task; }; -static struct config_item_type iio_loop_type = { +static const struct config_item_type iio_loop_type = { .ct_owner =THIS_MODULE , };include/linux/iio/sw_device.h +0
-0@@ -60,7 +60,7 @@ struct iio_sw_device *to_iio_sw_device(struct config_item *item)static inline
void iio_swd_group_init_type_name(structiio_sw_device*d,
const char *name,include/linux/iio/sw_device.h +1
-1- struct config_item_type *type) + const struct config_item_type *type){
#if IS_ENABLED(CONFIG_CONFIGFS_FS) config_group_init_type_name(&d->group, name, type);include/linux/iio/sw_trigger.h +0
-0@@ -60,7 +60,7 @@ struct iio_sw_trigger *to_iio_sw_trigger(struct config_item *item)static inline
void iio_swt_group_init_type_name(structiio_sw_trigger*t,
const char *name,include/linux/iio/sw_trigger.h +1
-1- struct config_item_type *type) + const struct config_item_type *type){
#if IS_ENABLED(CONFIG_CONFIGFS_FS) config_group_init_type_name(&t->group, name, type);
Signature · 1 line
Sent from my Android device with K-9 Mail. Please excuse my brevity.
PATCH v2 5/15 ocfs2/cluster: make config_item_type const
In reply to Bhumika GoyalMake these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure.
Done using Coccinelle.
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
fs/ocfs2/cluster/heartbeat.c | 4 ++-- fs/ocfs2/cluster/nodemanager.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-)
fs/ocfs2/cluster/heartbeat.c +2 -2
@@ -2025,7 +2025,7 @@ static ssize_t o2hb_region_pid_show(struct config_item *item, char *page) .release = o2hb_region_release, }; -static struct config_item_type o2hb_region_type = { +static const struct config_item_type o2hb_region_type = { .ct_item_ops = &o2hb_region_item_ops, .ct_attrs = o2hb_region_attrs, .ct_owner =THIS_MODULE ,
@@ -2310,7 +2310,7 @@ static ssize_t o2hb_heartbeat_group_mode_store(struct config_item *item, .drop_item = o2hb_heartbeat_group_drop_item, }; -static struct config_item_type o2hb_heartbeat_group_type = { +static const struct config_item_type o2hb_heartbeat_group_type = { .ct_group_ops = &o2hb_heartbeat_group_group_ops, .ct_attrs = o2hb_heartbeat_group_attrs, .ct_owner =THIS_MODULE ,
fs/ocfs2/cluster/nodemanager.c +4 -4
@@ -378,7 +378,7 @@ static ssize_t o2nm_node_local_store(struct config_item *item, const char *page, .release = o2nm_node_release, }; -static struct config_item_type o2nm_node_type = { +static const struct config_item_type o2nm_node_type = { .ct_item_ops = &o2nm_node_item_ops, .ct_attrs = o2nm_node_attrs, .ct_owner =THIS_MODULE ,
@@ -619,7 +619,7 @@ static void o2nm_node_group_drop_item(struct config_group *group, .drop_item = o2nm_node_group_drop_item, }; -static struct config_item_type o2nm_node_group_type = { +static const struct config_item_type o2nm_node_group_type = { .ct_group_ops = &o2nm_node_group_group_ops, .ct_owner =THIS_MODULE , };
@@ -637,7 +637,7 @@ static void o2nm_cluster_release(struct config_item *item) .release = o2nm_cluster_release, }; -static struct config_item_type o2nm_cluster_type = { +static const struct config_item_type o2nm_cluster_type = { .ct_item_ops = &o2nm_cluster_item_ops, .ct_attrs = o2nm_cluster_attrs, .ct_owner =THIS_MODULE ,
@@ -722,7 +722,7 @@ static void o2nm_cluster_group_drop_item(struct config_group *group, struct conf .drop_item = o2nm_cluster_group_drop_item, }; -static struct config_item_type o2nm_cluster_group_type = { +static const struct config_item_type o2nm_cluster_group_type = { .ct_group_ops = &o2nm_cluster_group_group_ops, .ct_owner =THIS_MODULE , };
Signature · 1 line
1.9.1
PATCH v2 6/15 PCI: endpoint: make config_item_type const
In reply to Bhumika GoyalMake config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure.
Done using Coccinelle.
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
drivers/pci/endpoint/pci-ep-cfs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/pci/endpoint/pci-ep-cfs.c +6 -6
@@ -150,7 +150,7 @@ static void pci_epc_epf_unlink(struct config_item *epc_item, .drop_link = pci_epc_epf_unlink, }; -static struct config_item_type pci_epc_type = { +static const struct config_item_type pci_epc_type = { .ct_item_ops = &pci_epc_item_ops, .ct_attrs = pci_epc_attrs, .ct_owner =THIS_MODULE ,
@@ -361,7 +361,7 @@ static void pci_epf_release(struct config_item *item) .release = pci_epf_release, }; -static struct config_item_type pci_epf_type = { +static const struct config_item_type pci_epf_type = { .ct_item_ops = &pci_epf_ops, .ct_attrs = pci_epf_attrs, .ct_owner =THIS_MODULE ,
@@ -400,7 +400,7 @@ static void pci_epf_drop(struct config_group *group, struct config_item *item) .drop_item = &pci_epf_drop, }; -static struct config_item_type pci_epf_group_type = { +static const struct config_item_type pci_epf_group_type = { .ct_group_ops = &pci_epf_group_ops, .ct_owner =THIS_MODULE , };
@@ -428,15 +428,15 @@ void pci_ep_cfs_remove_epf_group(struct config_group *group) }EXPORT_SYMBOL (pci_ep_cfs_remove_epf_group); -static struct config_item_type pci_functions_type = { +static const struct config_item_type pci_functions_type = { .ct_owner =THIS_MODULE , }; -static struct config_item_type pci_controllers_type = { +static const struct config_item_type pci_controllers_type = { .ct_owner =THIS_MODULE , }; -static struct config_item_type pci_ep_type = { +static const struct config_item_type pci_ep_type = { .ct_owner =THIS_MODULE , };
Signature · 1 line
1.9.1
Re: [PATCH v2 06/15] PCI: endpoint: make config_item_type const
Quoted 7 lines · Bhumika Goyal
Make
config_item_typestructures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of aconfig_itemstructure.Done using Coccinelle.
Signed-off-by Bhumika Goyal <[email protected]>
Please apply this along with the rest of the series, since it depends on an earlier patch in the series.
Quoted 60 lines
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.drivers/pci/endpoint/pci-ep-cfs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/pci/endpoint/pci-ep-cfs.c +6
-6@@ -150,7 +150,7 @@ static void pci_epc_epf_unlink(struct config_item *epc_item, .drop_link = pci_epc_epf_unlink, }; -static struct config_item_type pci_epc_type = { +static const struct config_item_type pci_epc_type = { .ct_item_ops = &pci_epc_item_ops, .ct_attrs = pci_epc_attrs, .ct_owner =THIS_MODULE ,@@ -361,7 +361,7 @@ static void pci_epf_release(struct config_item *item) .release = pci_epf_release, }; -static struct config_item_type pci_epf_type = { +static const struct config_item_type pci_epf_type = { .ct_item_ops = &pci_epf_ops, .ct_attrs = pci_epf_attrs, .ct_owner =THIS_MODULE ,@@ -400,7 +400,7 @@ static void pci_epf_drop(struct config_group *group, struct config_item *item) .drop_item = &pci_epf_drop, }; -static struct config_item_type pci_epf_group_type = { +static const struct config_item_type pci_epf_group_type = { .ct_group_ops = &pci_epf_group_ops, .ct_owner =THIS_MODULE , };@@ -428,15 +428,15 @@ void pci_ep_cfs_remove_epf_group(struct config_group *group) }EXPORT_SYMBOL (pci_ep_cfs_remove_epf_group); -static struct config_item_type pci_functions_type = { +static const struct config_item_type pci_functions_type = { .ct_owner =THIS_MODULE , }; -static struct config_item_type pci_controllers_type = { +static const struct config_item_type pci_controllers_type = { .ct_owner =THIS_MODULE , }; -static struct config_item_type pci_ep_type = { +static const struct config_item_type pci_ep_type = { .ct_owner =THIS_MODULE , };Signature · 1 line
1.9.1
PATCH v2 7/15 usb: gadget: configfs: make config_item_type const
In reply to Bhumika GoyalMake config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure.
Done using Coccinelle.
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
drivers/usb/gadget/configfs.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/usb/gadget/configfs.c +5 -5
@@ -505,13 +505,13 @@ static ssize_t gadget_config_desc_bmAttributes_store(struct config_item *item, NULL, }; -static struct config_item_type gadget_config_type = { +static const struct config_item_type gadget_config_type = { .ct_item_ops = &gadget_config_item_ops, .ct_attrs = gadget_config_attrs, .ct_owner =THIS_MODULE , }; -static struct config_item_type gadget_root_type = { +static const struct config_item_type gadget_root_type = { .ct_item_ops = &gadget_root_item_ops, .ct_attrs = gadget_root_attrs, .ct_owner =THIS_MODULE ,
@@ -593,7 +593,7 @@ static void function_drop( .drop_item = &function_drop, }; -static struct config_item_type functions_type = { +static const struct config_item_type functions_type = { .ct_group_ops = &functions_ops, .ct_owner =THIS_MODULE , };
@@ -694,7 +694,7 @@ static void config_desc_drop( .drop_item = &config_desc_drop, }; -static struct config_item_type config_desc_type = { +static const struct config_item_type config_desc_type = { .ct_group_ops = &config_desc_ops, .ct_owner =THIS_MODULE , };
@@ -1476,7 +1476,7 @@ static void gadgets_drop(struct config_group *group, struct config_item *item) .drop_item = &gadgets_drop, }; -static struct config_item_type gadgets_type = { +static const struct config_item_type gadgets_type = { .ct_group_ops = &gadgets_ops, .ct_owner =THIS_MODULE , };
Signature · 1 line
1.9.1
Re: [PATCH v2 07/15] usb: gadget: configfs: make config_item_type const
Quoted 7 lines · Bhumika Goyal
Make
config_item_typestructures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of aconfig_itemstructure.Done using Coccinelle.
Signed-off-by Bhumika Goyal <[email protected]>
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 832 bytes Desc: not available URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20171017/afe86832/attachment.sig>
PATCH v2 8/15 nvmet: make config_item_type const
In reply to Bhumika GoyalMake config_item_type structures const as they are either passed to a function having the argument as const or used inside an if statement or stored in the const "ci_type" field of a config_item structure.
Done using Coccinelle
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
drivers/nvme/target/configfs.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-)
drivers/nvme/target/configfs.c +15 -15
@@ -20,8 +20,8 @@#include "nvmet.h" -static struct config_item_type nvmet_host_type; -static struct config_item_type nvmet_subsys_type; +static const struct config_item_type nvmet_host_type; +static const struct config_item_type nvmet_subsys_type;/* * nvmet_port Generic ConfigFS definitions.
@@ -425,7 +425,7 @@ static void nvmet_ns_release(struct config_item *item) .release = nvmet_ns_release, }; -static struct config_item_type nvmet_ns_type = { +static const struct config_item_type nvmet_ns_type = { .ct_item_ops = &nvmet_ns_item_ops, .ct_attrs = nvmet_ns_attrs, .ct_owner =THIS_MODULE ,
@@ -464,7 +464,7 @@ static struct config_group *nvmet_ns_make(struct config_group *group, .make_group = nvmet_ns_make, }; -static struct config_item_type nvmet_namespaces_type = { +static const struct config_item_type nvmet_namespaces_type = { .ct_group_ops = &nvmet_namespaces_group_ops, .ct_owner =THIS_MODULE , };
@@ -540,7 +540,7 @@ static void nvmet_port_subsys_drop_link(struct config_item *parent, .drop_link = nvmet_port_subsys_drop_link, }; -static struct config_item_type nvmet_port_subsys_type = { +static const struct config_item_type nvmet_port_subsys_type = { .ct_item_ops = &nvmet_port_subsys_item_ops, .ct_owner =THIS_MODULE , };
@@ -613,7 +613,7 @@ static void nvmet_allowed_hosts_drop_link(struct config_item *parent, .drop_link = nvmet_allowed_hosts_drop_link, }; -static struct config_item_type nvmet_allowed_hosts_type = { +static const struct config_item_type nvmet_allowed_hosts_type = { .ct_item_ops = &nvmet_allowed_hosts_item_ops, .ct_owner =THIS_MODULE , };
@@ -729,7 +729,7 @@ static void nvmet_subsys_release(struct config_item *item) .release = nvmet_subsys_release, }; -static struct config_item_type nvmet_subsys_type = { +static const struct config_item_type nvmet_subsys_type = { .ct_item_ops = &nvmet_subsys_item_ops, .ct_attrs = nvmet_subsys_attrs, .ct_owner =THIS_MODULE ,
@@ -767,7 +767,7 @@ static struct config_group *nvmet_subsys_make(struct config_group *group, .make_group = nvmet_subsys_make, }; -static struct config_item_type nvmet_subsystems_type = { +static const struct config_item_type nvmet_subsystems_type = { .ct_group_ops = &nvmet_subsystems_group_ops, .ct_owner =THIS_MODULE , };
@@ -827,7 +827,7 @@ static void nvmet_referral_release(struct config_item *item) .release = nvmet_referral_release, }; -static struct config_item_type nvmet_referral_type = { +static const struct config_item_type nvmet_referral_type = { .ct_owner =THIS_MODULE , .ct_attrs = nvmet_referral_attrs, .ct_item_ops = &nvmet_referral_item_ops,
@@ -852,7 +852,7 @@ static struct config_group *nvmet_referral_make( .make_group = nvmet_referral_make, }; -static struct config_item_type nvmet_referrals_type = { +static const struct config_item_type nvmet_referrals_type = { .ct_owner =THIS_MODULE , .ct_group_ops = &nvmet_referral_group_ops, };
@@ -880,7 +880,7 @@ static void nvmet_port_release(struct config_item *item) .release = nvmet_port_release, }; -static struct config_item_type nvmet_port_type = { +static const struct config_item_type nvmet_port_type = { .ct_attrs = nvmet_port_attrs, .ct_item_ops = &nvmet_port_item_ops, .ct_owner =THIS_MODULE ,
@@ -921,7 +921,7 @@ static struct config_group *nvmet_ports_make(struct config_group *group, .make_group = nvmet_ports_make, }; -static struct config_item_type nvmet_ports_type = { +static const struct config_item_type nvmet_ports_type = { .ct_group_ops = &nvmet_ports_group_ops, .ct_owner =THIS_MODULE , };
@@ -940,7 +940,7 @@ static void nvmet_host_release(struct config_item *item) .release = nvmet_host_release, }; -static struct config_item_type nvmet_host_type = { +static const struct config_item_type nvmet_host_type = { .ct_item_ops = &nvmet_host_item_ops, .ct_owner =THIS_MODULE , };
@@ -963,14 +963,14 @@ static struct config_group *nvmet_hosts_make_group(struct config_group *group, .make_group = nvmet_hosts_make_group, }; -static struct config_item_type nvmet_hosts_type = { +static const struct config_item_type nvmet_hosts_type = { .ct_group_ops = &nvmet_hosts_group_ops, .ct_owner =THIS_MODULE , };static struct config_group nvmet_hosts_group; -static struct config_item_type nvmet_root_type = { +static const struct config_item_type nvmet_root_type = { .ct_owner =THIS_MODULE , };
Signature · 1 line
1.9.1
Re: [PATCH v2 08/15] nvmet: make config_item_type const
PATCH v2 9/15 ACPI: configfs: make config_item_type const
In reply to Bhumika GoyalMake these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure.
Done using Coccienlle.
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
drivers/acpi/acpi_configfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/acpi/acpi_configfs.c +3 -3
@@ -204,7 +204,7 @@ struct configfs_attribute *acpi_table_attrs[] = { NULL, }; -static struct config_item_type acpi_table_type = { +static const struct config_item_type acpi_table_type = { .ct_owner =THIS_MODULE , .ct_bin_attrs = acpi_table_bin_attrs, .ct_attrs = acpi_table_attrs,
@@ -237,12 +237,12 @@ struct configfs_group_operations acpi_table_group_ops = { .drop_item = acpi_table_drop_item, }; -static struct config_item_type acpi_tables_type = { +static const struct config_item_type acpi_tables_type = { .ct_owner =THIS_MODULE , .ct_group_ops = &acpi_table_group_ops, }; -static struct config_item_type acpi_root_group_type = { +static const struct config_item_type acpi_root_group_type = { .ct_owner =THIS_MODULE , };
Signature · 1 line
1.9.1
Re: [PATCH v2 09/15] ACPI: configfs: make config_item_type const
Quoted 33 lines · CEST Bhumika Goyal
Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "
ci_type" const field of aconfig_itemstructure.Done using Coccienlle.
Signed-off-by Bhumika Goyal <[email protected]>---
* Changes in v2- Combine all the followup patches and the constification patches into a series.drivers/acpi/acpi_configfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/acpi/acpi_configfs.c +1
-2@@ -204,7 +204,7 @@ struct configfs_attribute *acpi_table_attrs[] = { NULL, }; -static struct config_item_type acpi_table_type = { +static const struct config_item_type acpi_table_type = { .ct_owner =THIS_MODULE , .ct_bin_attrs = acpi_table_bin_attrs, .ct_attrs = acpi_table_attrs,@@ -237,12 +237,12 @@ struct configfs_group_operations acpi_table_group_ops = { .drop_item = acpi_table_drop_item, }; -static struct config_item_type acpi_tables_type = {
drivers/acpi/acpi_configfs.c struct configfs_group_operations acpi_table_group_ops = { · line 248
Quoted 10 lines
drivers/acpi/acpi_configfs.c +2
-1+static const struct config_item_type acpi_tables_type = { .ct_owner =THIS_MODULE , .ct_group_ops = &acpi_table_group_ops, }; -static struct config_item_type acpi_root_group_type = { +static const struct config_item_type acpi_root_group_type = { .ct_owner =THIS_MODULE , };
PATCH v2 10/15 nullb: make config_item_type const
In reply to Bhumika GoyalMake these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure.
Done using Coccienlle.
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
drivers/block/null_blk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/block/null_blk.c +2 -2
@@ -480,7 +480,7 @@ static void nullb_device_release(struct config_item *item) .release = nullb_device_release, }; -static struct config_item_type nullb_device_type = { +static const struct config_item_type nullb_device_type = { .ct_item_ops = &nullb_device_ops, .ct_attrs = nullb_device_attrs, .ct_owner =THIS_MODULE ,
@@ -532,7 +532,7 @@ static ssize_t memb_group_features_show(struct config_item *item, char *page) .drop_item = nullb_group_drop_item, }; -static struct config_item_type nullb_group_type = { +static const struct config_item_type nullb_group_type = { .ct_group_ops = &nullb_group_ops, .ct_attrs = nullb_group_attrs, .ct_owner =THIS_MODULE ,
Signature · 1 line
1.9.1
PATCH v2 11/15 stm class: make config_item_type const
In reply to Bhumika GoyalMake config_item_type structures const as they are either passed to a function having the argument as const or used inside a if statement or stored in the const "ci_type" field of a config_item structure.
Done using Coccinelle.
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
drivers/hwtracing/stm/policy.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/hwtracing/stm/policy.c +5 -5
@@ -187,8 +187,8 @@ static void stp_policy_node_release(struct config_item *item) NULL, }; -static struct config_item_type stp_policy_type; -static struct config_item_type stp_policy_node_type; +static const struct config_item_type stp_policy_type; +static const struct config_item_type stp_policy_node_type;static struct config_group *stp_policy_node_make (struct config_group *group,const char *name)
@@ -236,7 +236,7 @@ static void stp_policy_node_release(struct config_item *item) .drop_item = stp_policy_node_drop, }; -static struct config_item_type stp_policy_node_type = { +static const struct config_item_type stp_policy_node_type = { .ct_item_ops = &stp_policy_node_item_ops, .ct_group_ops = &stp_policy_node_group_ops, .ct_attrs = stp_policy_node_attrs,
@@ -311,7 +311,7 @@ static void stp_policy_release(struct config_item *item) .make_group = stp_policy_node_make, }; -static struct config_item_type stp_policy_type = { +static const struct config_item_type stp_policy_type = { .ct_item_ops = &stp_policy_item_ops, .ct_group_ops = &stp_policy_group_ops, .ct_attrs = stp_policy_attrs,
@@ -380,7 +380,7 @@ static void stp_policy_release(struct config_item *item) .make_group = stp_policies_make, }; -static struct config_item_type stp_policies_type = { +static const struct config_item_type stp_policies_type = { .ct_group_ops = &stp_policies_group_ops, .ct_owner =THIS_MODULE , };
Signature · 1 line
1.9.1
Re: [PATCH v2 11/15] stm class: make config_item_type const
Quoted 10 lines · Bhumika Goyal
Make
config_item_typestructures const as they are either passed to a function having the argument as const or used inside a if statement or stored in the const "ci_type" field of aconfig_itemstructure.Done using Coccinelle.
Signed-off-by Bhumika Goyal <[email protected]>---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
PATCH v2 12/15 RDMA/cma: make config_item_type const
In reply to Bhumika GoyalMake these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure.
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
drivers/infiniband/core/cma_configfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/infiniband/core/cma_configfs.c +4 -4
@@ -186,7 +186,7 @@ static ssize_t default_roce_tos_store(struct config_item *item, NULL, }; -static struct config_item_type cma_port_group_type = { +static const struct config_item_type cma_port_group_type = { .ct_attrs = cma_configfs_attributes, .ct_owner =THIS_MODULE };
@@ -263,7 +263,7 @@ static void release_cma_ports_group(struct config_item *item) .release = release_cma_ports_group }; -static struct config_item_type cma_ports_group_type = { +static const struct config_item_type cma_ports_group_type = { .ct_item_ops = &cma_ports_item_ops, .ct_owner =THIS_MODULE };
@@ -272,7 +272,7 @@ static void release_cma_ports_group(struct config_item *item) .release = release_cma_dev }; -static struct config_item_type cma_device_group_type = { +static const struct config_item_type cma_device_group_type = { .ct_item_ops = &cma_device_item_ops, .ct_owner =THIS_MODULE };
@@ -323,7 +323,7 @@ static struct config_group *make_cma_dev(struct config_group *group, .make_group = make_cma_dev, }; -static struct config_item_type cma_subsys_type = { +static const struct config_item_type cma_subsys_type = { .ct_group_ops = &cma_subsys_group_ops, .ct_owner =THIS_MODULE , };
Signature · 1 line
1.9.1
Re: [PATCH v2 12/15] RDMA/cma: make config_item_type const
Quoted 4 lines · Bhumika Goyal
Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "
ci_type" const field of aconfig_itemstructure.
Quoted 8 lines
Signed-off-by Bhumika Goyal <[email protected]>---
* Changes in v2- Combine all the followup patches and the constification patches into a series.drivers/infiniband/core/cma_configfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Thanks,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20171017/20f2e44b/attachment.sig>
Re: [PATCH v2 12/15] RDMA/cma: make config_item_type const
In reply to Bhumika GoyalQuoted 7 lines · Bhumika Goyal
Make these structures const as they are either passed to the functions
having the argument as const or stored as a reference in the "ci_type"
const field of aconfig_itemstructure.Signed-off-by Bhumika Goyal <[email protected]>
Signature · 3 lines
Doug Ledford <[email protected]> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
PATCH v2 13/15 netconsole: make config_item_type const
In reply to Bhumika GoyalMake these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure.
Done using Coccienlle.
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
drivers/net/netconsole.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/netconsole.c +2 -2
@@ -616,7 +616,7 @@ static void netconsole_target_release(struct config_item *item) .release = netconsole_target_release, }; -static struct config_item_type netconsole_target_type = { +static const struct config_item_type netconsole_target_type = { .ct_attrs = netconsole_target_attrs, .ct_item_ops = &netconsole_target_item_ops, .ct_owner =THIS_MODULE ,
@@ -682,7 +682,7 @@ static void drop_netconsole_target(struct config_group *group, .drop_item = drop_netconsole_target, }; -static struct config_item_type netconsole_subsys_type = { +static const struct config_item_type netconsole_subsys_type = { .ct_group_ops = &netconsole_subsys_group_ops, .ct_owner =THIS_MODULE , };
Signature · 1 line
1.9.1
PATCH v2 14/15 dlm: make config_item_type const
In reply to Bhumika GoyalMake config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure.
Done using Coccinelle.
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
fs/dlm/config.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
fs/dlm/config.c +8 -8
@@ -282,44 +282,44 @@ struct dlm_node { .release = release_node, }; -static struct config_item_type clusters_type = { +static const struct config_item_type clusters_type = { .ct_group_ops = &clusters_ops, .ct_owner =THIS_MODULE , }; -static struct config_item_type cluster_type = { +static const struct config_item_type cluster_type = { .ct_item_ops = &cluster_ops, .ct_attrs = cluster_attrs, .ct_owner =THIS_MODULE , }; -static struct config_item_type spaces_type = { +static const struct config_item_type spaces_type = { .ct_group_ops = &spaces_ops, .ct_owner =THIS_MODULE , }; -static struct config_item_type space_type = { +static const struct config_item_type space_type = { .ct_item_ops = &space_ops, .ct_owner =THIS_MODULE , }; -static struct config_item_type comms_type = { +static const struct config_item_type comms_type = { .ct_group_ops = &comms_ops, .ct_owner =THIS_MODULE , }; -static struct config_item_type comm_type = { +static const struct config_item_type comm_type = { .ct_item_ops = &comm_ops, .ct_attrs = comm_attrs, .ct_owner =THIS_MODULE , }; -static struct config_item_type nodes_type = { +static const struct config_item_type nodes_type = { .ct_group_ops = &nodes_ops, .ct_owner =THIS_MODULE , }; -static struct config_item_type node_type = { +static const struct config_item_type node_type = { .ct_item_ops = &node_ops, .ct_attrs = node_attrs, .ct_owner =THIS_MODULE ,
Signature · 1 line
1.9.1
PATCH v2 15/15 configfs: make config_item_type const
In reply to Bhumika GoyalMake config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure.
Done using Coccinelle.
---
* Changes in v2- Combine all the followup patches and the constification patches into a series.
samples/configfs/configfs_sample.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
samples/configfs/configfs_sample.c +4 -4
@@ -115,7 +115,7 @@ static ssize_t childless_description_show(struct config_item *item, char *page) NULL, }; -static struct config_item_type childless_type = { +static const struct config_item_type childless_type = { .ct_attrs = childless_attrs, .ct_owner =THIS_MODULE , };
@@ -193,7 +193,7 @@ static void simple_child_release(struct config_item *item) .release = simple_child_release, }; -static struct config_item_type simple_child_type = { +static const struct config_item_type simple_child_type = { .ct_item_ops = &simple_child_item_ops, .ct_attrs = simple_child_attrs, .ct_owner =THIS_MODULE ,
@@ -261,7 +261,7 @@ static void simple_children_release(struct config_item *item) .make_item = simple_children_make_item, }; -static struct config_item_type simple_children_type = { +static const struct config_item_type simple_children_type = { .ct_item_ops = &simple_children_item_ops, .ct_group_ops = &simple_children_group_ops, .ct_attrs = simple_children_attrs,
@@ -331,7 +331,7 @@ static ssize_t group_children_description_show(struct config_item *item, .make_group = group_children_make_group, }; -static struct config_item_type group_children_type = { +static const struct config_item_type group_children_type = { .ct_group_ops = &group_children_group_ops, .ct_attrs = group_children_attrs, .ct_owner =THIS_MODULE ,
Signature · 1 line
1.9.1
Greg KH
maintainerQuoted 5 lines · Bhumika Goyal
Make the
ci_typefield and some function arguments as const. After this change, makeconfig_item_typestructures as const.* Changes in v2- Combine all the followup patches and the constification patches into a series.
Who do you want to take these patches? If you want, I can take them through my driver-core tree, which has done other configfs stuff like this in the past.
thanks,
greg k-h
Quoted 10 lines · Greg KH
Quoted 5 lines · Bhumika Goyal
Make the
ci_typefield and some function arguments as const. After this change, makeconfig_item_typestructures as const.* Changes in v2- Combine all the followup patches and the constification patches into a series.
Who do you want to take these patches? If you want, I can take them through my driver-core tree, which has done other configfs stuff like this in the past.
Christoph Hellwig proposed to take care of it.
julia
Quoted 5 lines
thanks,
greg k-h
Greg KH
maintainerQuoted 8 lines · Julia Lawall
Quoted 4 lines · Greg KH
Quoted 3 lines · Bhumika Goyal
Make the
ci_typefield and some function arguments as const. After this change, makeconfig_item_typestructures as const.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
* Changes in v2- Combine all the followup patches and the constification patches into a series.
Who do you want to take these patches? If you want, I can take them through my driver-core tree, which has done other configfs stuff like this in the past.
Christoph Hellwig proposed to take care of it.
Great! I'll go ack the individual ones that I might need to...
thanks,
greg k-h