Skip to contentSkip to conversation

tcp: Use pI6c in tcp tracepoint

PATCH Applied David Ahern 4 participants 5 messages Oct 16, 2017 – Oct 18, 2017

Subsystems (4)
Networking Network drivers Tracing TCP
lore
Share & tools
lore

David Ahern

author
#0 lore raw

PATCH 1/1 tcp: Use pI6c in tcp tracepoint

The compact form for IPv6 addresses is more user friendly than the full version. For example:
compact: 2001:db8:1::1

      full: 2001:0db8:0001:0000:0000:0000:0000:0004i

Update the tcp tracepoint to show the compact form.

Signed-off-by David Ahern <[email protected]>
---
 include/trace/events/tcp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/trace/events/tcp.h +1 -1
index 3d1cbd072b7e..1ffab6d96e94 100644
@@ -57,7 +57,7 @@ TRACE_EVENT(tcp_retransmit_skb,
 		}
 	),
 
-	TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6 daddrv6=%pI6",
+	TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c",
 		  __entry->sport, __entry->dport, __entry->saddr, __entry->daddr,
 		  __entry->saddr_v6, __entry->daddr_v6)
 );
Signature · 1 line
2.1.4
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · David Ahern

The compact form for IPv6 addresses is more user friendly than the full version. For example:

   compact: 2001:db8:1::1
      full: 2001:0db8:0001:0000:0000:0000:0000:0004i

Update the tcp tracepoint to show the compact form.

Signed-off-by David Ahern <[email protected]>
Acked-by Cong Wang <[email protected]>

I was planning to send a same patch based on your
suggestion, you are faster than me. ;)

author
#2 lore raw
Quoted 3 lines · Cong Wang

I was planning to send a same patch based on your
suggestion, you are faster than me. ;)

I would have sent that patch hours ago, but got hung up on the testing. See the second patch.