Skip to contentSkip to conversation

imx-csi: fix burst size

PATCH In review Russell King 2 participants 3 messages Sep 29, 2017 – Oct 18, 2017

Subsystems (4)
Media (V4L/DVB) Arm i.MX and Layerscape Staging Media drivers for Freescale i.MX
lore
Share & tools
lore

Russell King

author
#0 lore raw

PATCH 1/1 imx-csi: fix burst size

Setting a burst size of "8" doesn't work for IMX219 with 8-bit bayer, but a burst size of "16" does. Fix this.

Signed-off-by Russell King <[email protected]>
---
 drivers/staging/media/imx/imx-media-csi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/imx/imx-media-csi.c +1 -1
index 6d856118c223..e27bcdb63973 100644
@@ -341,7 +341,7 @@ static int csi_idmac_setup_channel(struct csi_priv *priv)
 	case V4L2_PIX_FMT_SGBRG8:
 	case V4L2_PIX_FMT_SGRBG8:
 	case V4L2_PIX_FMT_SRGGB8:
-		burst_size = 8;
+		burst_size = 16;
 		passthrough = true;
 		passthrough_bits = 8;
 		break;
Signature · 1 line
2.7.4
maintainer
#1 lore raw

Hi Russell,

Quoted 2 lines · Russell King

Setting a burst size of "8" doesn't work for IMX219 with 8-bit bayer, but a burst size of "16" does.  Fix this.

Do larger bursts work as well, if the width is divisible by the burst length? Since the Bayer format can't pass through the IC direct path anyway, 32-byte or 64-byte bursts may be possible.

Quoted 17 lines
Signed-off-by Russell King <[email protected]>

---
 drivers/staging/media/imx/imx-media-csi.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/imx/imx-media-csi.c +0 -0
index 6d856118c223..e27bcdb63973 100644
@@ -341,7 +341,7 @@ static int csi_idmac_setup_channel(struct csi_priv
 *priv)

  case V4L2_PIX_FMT_SGBRG8:
  case V4L2_PIX_FMT_SGRBG8:
  case V4L2_PIX_FMT_SRGGB8:

drivers/staging/media/imx/imx-media-csi.c +1 -1
-		burst_size = 8;
+		burst_size = 16;
Quoted 3 lines

  passthrough = true;
  passthrough_bits = 8;
  break;

regards
Philipp

maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Russell King
Quoted 4 lines · Russell King

Setting a burst size of "8" doesn't work for IMX219 with 8-bit bayer, but a burst size of "16" does. Fix this.

Signed-off-by Russell King <[email protected]>

Oh, well, this isn't for me to apply after all.

Acked-by Philipp Zabel <[email protected]>

regards
Philipp

Quoted 17 lines
---
 drivers/staging/media/imx/imx-media-csi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/imx/imx-media-csi.c +1 -1
index 6d856118c223..e27bcdb63973 100644
@@ -341,7 +341,7 @@ static int csi_idmac_setup_channel(struct csi_priv *priv)
 	case V4L2_PIX_FMT_SGBRG8:
 	case V4L2_PIX_FMT_SGRBG8:
 	case V4L2_PIX_FMT_SRGGB8:
-		burst_size = 8;
+		burst_size = 16;
 		passthrough = true;
 		passthrough_bits = 8;
 		break;