Skip to contentSkip to conversation

Patch: add to Documentation/scsi for scsi_dev_flags and command line passing

PATCH Laurence Oberman 3 participants 5 messages Oct 18, 2017 – Oct 19, 2017 1 message not in the archive

Subsystems (2)
Documentation SCSI
lore
Share & tools
lore

Laurence Oberman

author
#0 lore raw

Tired of forgetting about this so documented it for others so they also don't spend unnecessary time figuring this out.

Signed-off-by Laurence Oberman <[email protected]>
(quoted diff) +0 -0

b/Documentation/scsi/scsi-parameters.txt
index 8477655..c9e9ce8 100644

Documentation/scsi/scsi-parameters.txt +0 -0
@@ -116,3 +116,9 @@ parameters may be changed at runtime by the command


  wd33c93= [HW,SCSI]
  See header of drivers/scsi/wd33c93.c. +
+Additional notes on passing parameters on the command line. +Its not intuitively obvious how to pass certain parameters on the boot line.
+For parameters such as scsi_dev_flags, you need to pass to the scsi_mod as follows +scsi_mod.dev_flags=LIO-ORG:thin2:0x80000000
+
--
1.8.3.1

reviewer
#1 lore raw
Quoted 14 lines · Laurence Oberman

Tired of forgetting about this so documented it for others so they also don't spend unnecessary time figuring this out.

Signed-off-by Laurence Oberman <[email protected]>
Documentation/scsi/scsi-parameters.txt +0 -0
index 8477655..c9e9ce8 100644
@@ -116,3 +116,9 @@ parameters may be changed at runtime by the command


  wd33c93= [HW,SCSI]
  See header of drivers/scsi/wd33c93.c.

Documentation/scsi/scsi-parameters.txt

Quoted 2 lines
Documentation/scsi/scsi-parameters.txt +2 -0
+
+Additional notes on passing parameters on the command line.

line:

Quoted 1 line

+Its not intuitively obvious how to pass certain parameters on the boot

It's

Quoted 3 lines

line.
+For parameters such as scsi_dev_flags, you need to pass to the scsi_mod as follows

as follows:

Quoted 4 lines
Documentation/scsi/scsi-parameters.txt +2 -0
+scsi_mod.dev_flags=LIO-ORG:thin2:0x80000000
+

--
1.8.3.1

Also the patch has some weird line breaks.

Signature · 1 line
~Randy

A message that is not in the archive (sent off-list or not yet received): CAFfF4qua-gutNTT+s+HuxrgS_B8sV5J+8x0-VbrYwObd5mN4bQ@mail.gmail.com

reviewer
#3 lore raw
Quoted 4 lines · Laurence Oberman

I just noticed that
Was taken straight out of git after changing the Doc file. Let me see why git did that

It's more likely that Evolution did it.

Quoted 46 lines · On Wed, Oct 18, 2017 at 1:25 PM, Randy Dunlap <[email protected]…

On 10/18/17 10:13, Laurence Oberman wrote:
> Tired of forgetting about this so documented it for others so they also > don't spend unnecessary time figuring this out.
>
> Signed-off-by: Laurence Oberman <[email protected] <mailto:[email protected]>> >
> diff --git a/Documentation/scsi/scsi-parameters.txt
> b/Documentation/scsi/scsi-parameters.txt
> index 8477655..c9e9ce8 100644
> --- a/Documentation/scsi/scsi-parameters.txt
> +++ b/Documentation/scsi/scsi-parameters.txt
> @@ -116,3 +116,9 @@ parameters may be changed at runtime by the command >
>       wd33c93=        [HW,SCSI]
>                       See header of drivers/scsi/wd33c93.c.
> +
> +Additional notes on passing parameters on the command line.

                                                         line:

> +Its not intuitively obvious how to pass certain parameters on the boot

   It's

> line.
> +For parameters such as scsi_dev_flags, you need to pass to the > scsi_mod as follows

           as follows:

> +scsi_mod.dev_flags=LIO-ORG:thin2:0x80000000 > +
> --
> 1.8.3.1

Also the patch has some weird line breaks.

--
~Randy

Signature · 1 line
~Randy
author
#4 lore raw

Indeed it was Evolution and then linux-scsi rejected my fix.

Trying again, for some reason it thought I had html

Signed-off-by Laurence Oberman <[email protected]>
Documentation/scsi/scsi-parameters.txt +8 -0
@@ -116,3 +116,11 @@ parameters may be changed at runtime by the command
 
  wd33c93= [HW,SCSI]
  See header of drivers/scsi/wd33c93.c.
+
+Additional notes on passing parameters on the command line:
+
+It's not intuitively obvious how to pass certain parameters on the boot line.
+For parameters such as scsi_dev_flags, you need to pass to the scsi_mod as
+follows.
+On kernel line add scsi_mod.dev_flags=LIO-ORG:thin2:0x8000000
+
Quoted 58 lines · Randy Dunlap
Quoted 4 lines · Laurence Oberman

I just noticed that
Was taken straight out of git after changing the Doc file. Let me see why git did that

It's more likely that Evolution did it.

Quoted 36 lines · On Wed, Oct 18, 2017 at 1:25 PM, Randy Dunlap <[email protected]…
    On 10/18/17 10:13, Laurence Oberman wrote:
    > Tired of forgetting about this so documented it for others so they also
    > don't spend unnecessary time figuring this out.
    >
    > Signed-off-by: Laurence Oberman <[email protected] <mailto:[email protected]>>
    >
    > diff --git a/Documentation/scsi/scsi-parameters.txt
    > b/Documentation/scsi/scsi-parameters.txt
    > index 8477655..c9e9ce8 100644
    > --- a/Documentation/scsi/scsi-parameters.txt
    > +++ b/Documentation/scsi/scsi-parameters.txt
    > @@ -116,3 +116,9 @@ parameters may be changed at runtime by the command
    >
    >       wd33c93=        [HW,SCSI]
    >                       See header of drivers/scsi/wd33c93.c.
    > +
    > +Additional notes on passing parameters on the command line.

                                                             line:

    > +Its not intuitively obvious how to pass certain parameters on the boot

       It's

    > line.
    > +For parameters such as scsi_dev_flags, you need to pass to the
    > scsi_mod as follows

               as follows:

    > +scsi_mod.dev_flags=LIO-ORG:thin2:0x80000000
    > +
    > --
Quoted 10 lines
    > 1.8.3.1


    Also the patch has some weird line breaks.


    --
    ~Randy

--
~Randy

#5 lore raw

Laurence,

Quoted 1 line

Indeed it was Evolution and then linux-scsi rejected my fix.

Please use git send-email for patch submissions.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering