Skip to contentSkip to conversation

Patch "ceph: fix bogus endianness change in ceph_ioctl_set_layout" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Oct 19, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ceph: fix bogus endianness change in ceph_ioctl_set_layout

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ceph-fix-bogus-endianness-change-in-ceph_ioctl_set_layout.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Thu Oct 19 15:04:02 CEST 2017

From: Jeff Layton <[email protected]>
Date: Thu, 12 Jan 2017 14:42:40 -0500
Subject: ceph: fix bogus endianness change in ceph_ioctl_set_layout

From: Jeff Layton <[email protected]>

[ Upstream commit 24c149ad6914d349d8b64749f20f3f8ea5031fe0 ]

sparse says:

    fs/ceph/ioctl.c:100:28: warning: cast to restricted __le64

preferred_osd is a __s64 so we don't need to do any conversion. Also, just remove the cast in ceph_ioctl_get_layout as it's not needed.

---
 fs/ceph/ioctl.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ceph/ioctl.c +2 -2
@@ -25,7 +25,7 @@ static long ceph_ioctl_get_layout(struct
 		l.stripe_count = ci->i_layout.stripe_count;
 		l.object_size = ci->i_layout.object_size;
 		l.data_pool = ci->i_layout.pool_id;
-		l.preferred_osd = (s32)-1;
+		l.preferred_osd = -1;
 		if (copy_to_user(arg, &l, sizeof(l)))
 			return -EFAULT;
 	}
@@ -97,7 +97,7 @@ static long ceph_ioctl_set_layout(struct
 		nl.data_pool = ci->i_layout.pool_id;
 
 	/* this is obsolete, and always -1 */
-	nl.preferred_osd = le64_to_cpu(-1);
+	nl.preferred_osd = -1;
 
 	err = __validate_layout(mdsc, &nl);
 	if (err)

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/ceph-fix-bogus-endianness-change-in-ceph_ioctl_set_layout.patch queue-4.9/ceph-clean-up-unsafe-d_parent-accesses-in-build_dentry_path.patch queue-4.9/ceph-don-t-update_dentry_lease-unless-we-actually-got-one.patch