Skip to contentSkip to conversation

selftests: ftrace: add more config fragments

PATCH In review [email protected] 3 participants 5 messages Oct 21, 2017 – Nov 3, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests: ftrace: add more config fragments

From: Lei Yang <[email protected]>

We need to enable more configs to make test more
without this patch,we got lots of "UNSUPPORTED"

before the patch:
http://pastebin.ubuntu.com/25784377/
after the patch:
http://pastebin.ubuntu.com/25784387/

---
 tools/testing/selftests/ftrace/config | 4 ++++
 1 file changed, 4 insertions(+)
tools/testing/selftests/ftrace/config +4 -0
index 8a1c9f9..b01924c 100644
@@ -1,2 +1,6 @@
 CONFIG_KPROBES=y
 CONFIG_FTRACE=y
+CONFIG_FUNCTION_PROFILER=y
+CONFIG_TRACER_SNAPSHOT=y
+CONFIG_STACK_TRACER=y
+CONFIG_HIST_TRIGGERS=y
Signature · 1 line
1.9.1
#1 lore raw
Quoted 21 lines · On 10/21/2017 04:17 AM, [email protected] wrote:

From: Lei Yang <[email protected]>

We need to enable more configs to make test more
without this patch,we got lots of "UNSUPPORTED"

before the patch:
http://pastebin.ubuntu.com/25784377/
after the patch:
http://pastebin.ubuntu.com/25784387/

---
 tools/testing/selftests/ftrace/config | 4 ++++
 1 file changed, 4 insertions(+)
tools/testing/selftests/ftrace/config +0 -0
index 8a1c9f9..b01924c 100644

tools/testing/selftests/ftrace/config line 6

Quoted 6 lines
tools/testing/selftests/ftrace/config +4 -0
@@ -1,2 +1,6 @@
 CONFIG_KPROBES=y
 CONFIG_FTRACE=y
+CONFIG_FUNCTION_PROFILER=y
+CONFIG_TRACER_SNAPSHOT=y
+CONFIG_STACK_TRACER=y
+CONFIG_HIST_TRIGGERS=y

Hi Steve/Masami,

Are you good with this change. Please give me an Ack.

thanks,
-- Shuah

author
#2 lore raw
Quoted 30 lines · Shuah Khan
Quoted 21 lines · On 10/21/2017 04:17 AM, [email protected] wrote:

From: Lei Yang <[email protected]>

We need to enable more configs to make test more
without this patch,we got lots of "UNSUPPORTED"

before the patch:
http://pastebin.ubuntu.com/25784377/
after the patch:
http://pastebin.ubuntu.com/25784387/

---
  tools/testing/selftests/ftrace/config | 4 ++++
  1 file changed, 4 insertions(+)
tools/testing/selftests/ftrace/config +0 -0
index 8a1c9f9..b01924c 100644

tools/testing/selftests/ftrace/config line 6

Quoted 6 lines
tools/testing/selftests/ftrace/config +4 -0
@@ -1,2 +1,6 @@
  CONFIG_KPROBES=y
  CONFIG_FTRACE=y
+CONFIG_FUNCTION_PROFILER=y
+CONFIG_TRACER_SNAPSHOT=y
+CONFIG_STACK_TRACER=y
+CONFIG_HIST_TRIGGERS=y

Hi Steve/Masami,

Quoted 1 line

Are you good with this change. Please give me an Ack.

Hi,

any comments ?

Lei

Quoted 2 lines

thanks,
-- Shuah

maintainer Acked-by
#3 lore raw
Quoted 14 lines · On Fri, 3 Nov 2017 15:23:56 +0800 lyang0 <[email protected]> wrote:
Quoted 14 lines

tools/testing/selftests/ftrace/config line 6

Quoted 12 lines
tools/testing/selftests/ftrace/config +4 -0
index 8a1c9f9..b01924c 100644
@@ -1,2 +1,6 @@
  CONFIG_KPROBES=y
  CONFIG_FTRACE=y
+CONFIG_FUNCTION_PROFILER=y
+CONFIG_TRACER_SNAPSHOT=y
+CONFIG_STACK_TRACER=y
+CONFIG_HIST_TRIGGERS=y

Hi Steve/Masami,

Quoted 5 lines
Quoted 1 line

Are you good with this change. Please give me an Ack.

Hi,

any comments ?

You should have Cc'd me in the first email. Thanks to Shuah for pointing it out to us.

Anyway, I'm fine with it.

-- Steve

#4 lore raw
Quoted 22 lines · Steven Rostedt
Quoted 18 lines · On Fri, 3 Nov 2017 15:23:56 +0800 lyang0 <[email protected]> wrote:
Quoted 14 lines

tools/testing/selftests/ftrace/config line 6

Quoted 12 lines
tools/testing/selftests/ftrace/config +4 -0
index 8a1c9f9..b01924c 100644
@@ -1,2 +1,6 @@
  CONFIG_KPROBES=y
  CONFIG_FTRACE=y
+CONFIG_FUNCTION_PROFILER=y
+CONFIG_TRACER_SNAPSHOT=y
+CONFIG_STACK_TRACER=y
+CONFIG_HIST_TRIGGERS=y

Hi Steve/Masami,

Quoted 1 line

Are you good with this change. Please give me an Ack.

Hi,

Quoted 9 lines
Quoted 1 line

any comments ?

You should have Cc'd me in the first email. Thanks to Shuah for pointing it out to us.

Anyway, I'm fine with it.

Thanks Steve. I will get this into linux-kselftest 4.15-rc1

Lei,

Please do the following when you send your future patches:

Not stating the obvious, make sure to test and include what does this patch fix in your commit log.

1. Run scripts/checkpatch.pl
2. Run scripts/get_maintainer.pl
3. Please give us at least a week before pinging us. We have all been traveling all of last week and going through out Inboxes.

Please refer to Documentation/process/submitting-patches.rst for details on how to send patches.

btw for this patch if you ran scripts/get_maintainer.pl, you would have seen the correct list to send the patch to in the first place, which would have made it easier.

Steven Rostedt <[email protected]> (maintainer:TRACING) Ingo Molnar <[email protected]> (maintainer:TRACING)
Shuah Khan <[email protected]> (maintainer:KERNEL SELFTEST FRAMEWORK) [email protected] (open list:KERNEL SELFTEST FRAMEWORK) [email protected] (open list)

thanks,
-- Shuah