Skip to contentSkip to conversation

Patch "ALSA: hda: Remove superfluous '-' added by printk conversion" has been added to the 4.13-stable tree

PATCH [email protected] 1 participant 1 message Oct 24, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ALSA: hda: Remove superfluous '-' added by printk conversion

to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-hda-remove-superfluous-added-by-printk-conversion.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 6bf88a343db2b3c160edf9b82a74966b31cc80bd Mon Sep 17 00:00:00 2001

From: Takashi Iwai <[email protected]>
Date: Tue, 17 Oct 2017 11:58:17 +0200
Subject: ALSA: hda: Remove superfluous '-' added by printk conversion

From: Takashi Iwai <[email protected]>

commit 6bf88a343db2b3c160edf9b82a74966b31cc80bd upstream.

While converting the error messages to the standard macros in the commit 4e76a8833fac ("ALSA: hda - Replace with standard printk"), a superfluous '-' slipped in the code mistakenly. Its influence is almost negligible, merely shows a dB value as negative integer instead of positive integer (or vice versa) in the rare error message. So let's kill this embarrassing byte to show more correct value.

Fixes 4e76a8833fac ("ALSA: hda - Replace with standard printk")
---
 sound/pci/hda/hda_codec.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/hda_codec.c +1 -1
@@ -1824,7 +1824,7 @@ static int get_kctl_0dB_offset(struct hd
 			return -1;
 		if (*step_to_check && *step_to_check != step) {
 			codec_err(codec, "Mismatching dB step for vmaster slave (%d!=%d)\n",
--				   *step_to_check, step);
+				   *step_to_check, step);
 			return -1;
 		}
 		*step_to_check = step;

Patches currently in stable-queue which might be from [email protected] are

queue-4.13/alsa-hda-remove-superfluous-added-by-printk-conversion.patch queue-4.13/alsa-hda-abort-capability-probe-at-invalid-register-read.patch queue-4.13/alsa-usb-audio-add-native-dsd-support-for-pro-ject-pre-box-s2-digital.patch queue-4.13/alsa-seq-enable-use-locking-in-all-configurations.patch