drm/amdgpu/virt: implement wait_reset callbacks for vi/ai
Subsystems (2)
PATCH 6/7 drm/amdgpu/virt: implement wait_reset callbacks for vi/ai
From: pding <[email protected]>
Hi Alex,
Split the wait_reset patch to 2. Part 2.
please review.
---
--- drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c | 1 + drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 6 ++++++ 2 files changed, 7 insertions(+)
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c +1 -0
@@ -353,5 +353,6 @@ const struct amdgpu_virt_ops xgpu_ai_virt_ops = { .req_full_gpu = xgpu_ai_request_full_gpu_access, .rel_full_gpu = xgpu_ai_release_full_gpu_access, .reset_gpu = xgpu_ai_request_reset, + .wait_reset = NULL, .trans_msg = xgpu_ai_mailbox_trans_msg, };
drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c +6 -0
@@ -458,6 +458,11 @@ static int xgpu_vi_request_reset(struct amdgpu_device *adev)return xgpu_vi_send_access_requests (adev,IDH_REQ_GPU_RESET_ACCESS ); } +static int xgpu_vi_wait_reset_cmpl (struct amdgpu_device *adev) +{ +return xgpu_vi_poll_msg (adev,IDH_FLR_NOTIFICATION_CMPL ); +} +static int xgpu_vi_request_full_gpu_access (struct amdgpu_device *adev,bool init) {
@@ -613,5 +618,6 @@ const struct amdgpu_virt_ops xgpu_vi_virt_ops = { .req_full_gpu = xgpu_vi_request_full_gpu_access, .rel_full_gpu = xgpu_vi_release_full_gpu_access, .reset_gpu = xgpu_vi_request_reset, + .wait_reset = xgpu_vi_wait_reset_cmpl, .trans_msg = NULL, /* Does not need to trans VF errors to host. */ };
Signature · 6 lines
2.9.5 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1508897871-22042-1-git-send-email-Pixel.Ding-5C7GfCeVMHo@public.gmane.org
Alex Deucher
Acked-byQuoted 11 lines · Pixel Ding
From: pding <[email protected]>
Hi Alex,
Split the
wait_resetpatch to 2. Part 2.please review.
---
Signed-off-by pding <[email protected]>
Quoted 42 lines
--- drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c | 1 + drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 6 ++++++ 2 files changed, 7 insertions(+)drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c +1
-0@@ -353,5 +353,6 @@ const struct amdgpu_virt_ops xgpu_ai_virt_ops = { .req_full_gpu = xgpu_ai_request_full_gpu_access, .rel_full_gpu = xgpu_ai_release_full_gpu_access, .reset_gpu = xgpu_ai_request_reset, + .wait_reset = NULL, .trans_msg = xgpu_ai_mailbox_trans_msg, };drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c +6
-1@@ -458,6 +458,11 @@ static int xgpu_vi_request_reset(struct amdgpu_device *adev)return xgpu_vi_send_access_requests (adev,IDH_REQ_GPU_RESET_ACCESS ); } +static int xgpu_vi_wait_reset_cmpl (struct amdgpu_device *adev) +{ +return xgpu_vi_poll_msg (adev,IDH_FLR_NOTIFICATION_CMPL ); +} +static int xgpu_vi_request_full_gpu_access (struct amdgpu_device *adev,bool init) {@@ -613,5 +618,6 @@ const struct amdgpu_virt_ops xgpu_vi_virt_ops = { .req_full_gpu = xgpu_vi_request_full_gpu_access, .rel_full_gpu = xgpu_vi_release_full_gpu_access, .reset_gpu = xgpu_vi_request_reset, + .wait_reset = xgpu_vi_wait_reset_cmpl, .trans_msg = NULL, /* Does not need to trans VF errors to host. */ }; --2.9.5
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Hi Alex,
Any concern about this patch? it’s split as suggested. —
Sincerely Yours,
Pixel
Quoted 53 lines · Pixel Ding
From: pding <[email protected]>
Hi Alex,
Split the
wait_resetpatch to 2. Part 2.please review.
---
Signed-off-by pding <[email protected]>---
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c| 1 +drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c| 6 ++++++2 files changed, 7 insertions(+)drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c +1
-0@@ -353,5 +353,6 @@ const struct amdgpu_virt_ops xgpu_ai_virt_ops = { .req_full_gpu = xgpu_ai_request_full_gpu_access, .rel_full_gpu = xgpu_ai_release_full_gpu_access, .reset_gpu = xgpu_ai_request_reset, + .wait_reset = NULL, .trans_msg = xgpu_ai_mailbox_trans_msg, };drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c +6
-0@@ -458,6 +458,11 @@ static int xgpu_vi_request_reset(struct amdgpu_device *adev)return xgpu_vi_send_access_requests (adev,IDH_REQ_GPU_RESET_ACCESS ); } +static int xgpu_vi_wait_reset_cmpl (struct amdgpu_device *adev) +{ +return xgpu_vi_poll_msg (adev,IDH_FLR_NOTIFICATION_CMPL ); +} +static int xgpu_vi_request_full_gpu_access (struct amdgpu_device *adev,bool init) {@@ -613,5 +618,6 @@ const struct amdgpu_virt_ops xgpu_vi_virt_ops = { .req_full_gpu = xgpu_vi_request_full_gpu_access, .rel_full_gpu = xgpu_vi_release_full_gpu_access, .reset_gpu = xgpu_vi_request_reset, + .wait_reset = xgpu_vi_wait_reset_cmpl, .trans_msg = NULL, /* Does not need to trans VF errors to host. */ };Signature · 1 line
2.9.5
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): BEA92957-C3C9-422F-8BE2-DA702C8CB9E5-5C7GfCeVMHo@public.gmane.org
Quoted 11 lines
-----Original Message-----
From: Ding, Pixel
Sent: Wednesday, October 25, 2017 10:20 PM
To: [email protected]; Deucher, Alexander
Cc: Sun, Gary
Subject: Re: [PATCH 6/7] drm/amdgpu/virt: implementwait_resetcallbacks for vi/aiHi Alex,
Any concern about this patch? it’s split as suggested.
I replied with my ack. Did the email not go through?
Alex
Quoted 51 lines
—
Sincerely Yours,
PixelQuoted 10 lines · Pixel Ding
From: pding <[email protected]>
Hi Alex,
Split the
wait_resetpatch to 2. Part 2.please review.
---
Review
Quoted 7 lines
Signed-off-by pding <[email protected]>---
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c| 1 +drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c| 6 ++++++2 files changed, 7 insertions(+)(quoted diff) +0
-0
b/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.cReview
Quoted 11 lines
index b4906d2..f91aab3 100644
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c +1
-0@@ -353,5 +353,6 @@ const struct amdgpu_virt_ops xgpu_ai_virt_ops = { .req_full_gpu = xgpu_ai_request_full_gpu_access, .rel_full_gpu = xgpu_ai_release_full_gpu_access, .reset_gpu = xgpu_ai_request_reset, + .wait_reset = NULL, .trans_msg = xgpu_ai_mailbox_trans_msg, };(quoted diff) +0
-0
b/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.cdrivers/gpu/drm/amd/amdgpu/mxgpu_vi.c static int xgpu_vi_request_reset(struct
Quoted 4 lines
index c25a831..27b03c7 100644
drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c +0
-0@@ -458,6 +458,11 @@ static int xgpu_vi_request_reset(struct
amdgpu_device*adev)drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c static int xgpu_vi_request_reset(struct · line 458
Quoted 1 line
drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c +0
-0return xgpu_vi_send_access_requests(adev,
IDH_REQ_GPU_RESET_ACCESS);Quoted 2 lines
drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c +0
-0}
Quoted 19 lines
Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c +5
-0+static int xgpu_vi_wait_reset_cmpl (struct amdgpu_device *adev) +{ +return xgpu_vi_poll_msg (adev,IDH_FLR_NOTIFICATION_CMPL ); +} +static int xgpu_vi_request_full_gpu_access (struct amdgpu_device *adev,bool init) {drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c const struct amdgpu_virt_ops xgpu_vi_virt_ops = { · line 622
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c +1
-0@@ -613,5 +618,6 @@ const struct amdgpu_virt_ops xgpu_vi_virt_ops = { .req_full_gpu = xgpu_vi_request_full_gpu_access, .rel_full_gpu = xgpu_vi_release_full_gpu_access, .reset_gpu = xgpu_vi_request_reset, + .wait_reset = xgpu_vi_wait_reset_cmpl, .trans_msg = NULL, /* Does not need to trans VF errorsto host. */
Quoted 4 lines
drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c +0
-1}; --2.9.5
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CY4PR12MB1653987E500E4AF0677D074CF7450-rpdhrqHFk06apTa93KjAaQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org
Thanks:) I only got the ack for part 1…
—
Sincerely Yours,
Pixel
Quoted 8 lines · Alexander
Quoted 8 lines
-----Original Message-----
From: Ding, Pixel
Sent: Wednesday, October 25, 2017 10:20 PM
To: [email protected]; Deucher, Alexander
Cc: Sun, Gary
Subject: Re: [PATCH 6/7] drm/amdgpu/virt: implementwait_resetcallbacks for vi/ai
Quoted 78 lines
Quoted 3 lines
Hi Alex,
Any concern about this patch? it’s split as suggested.
I replied with my ack. Did the email not go through?
Alex
Quoted 70 lines
—
Sincerely Yours,
PixelQuoted 10 lines · Pixel Ding
From: pding <[email protected]>
Hi Alex,
Split the
wait_resetpatch to 2. Part 2.please review.
---
Review
Quoted 7 lines
Signed-off-by pding <[email protected]>---
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c| 1 +drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c| 6 ++++++2 files changed, 7 insertions(+)(quoted diff) +0
-0
b/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.cReview
Quoted 11 lines
index b4906d2..f91aab3 100644
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c +1
-0@@ -353,5 +353,6 @@ const struct amdgpu_virt_ops xgpu_ai_virt_ops = { .req_full_gpu = xgpu_ai_request_full_gpu_access, .rel_full_gpu = xgpu_ai_release_full_gpu_access, .reset_gpu = xgpu_ai_request_reset, + .wait_reset = NULL, .trans_msg = xgpu_ai_mailbox_trans_msg, };(quoted diff) +0
-0
b/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.cdrivers/gpu/drm/amd/amdgpu/mxgpu_vi.c static int xgpu_vi_request_reset(struct
Quoted 4 lines
index c25a831..27b03c7 100644
drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c +0
-0@@ -458,6 +458,11 @@ static int xgpu_vi_request_reset(struct
amdgpu_device*adev)drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c static int xgpu_vi_request_reset(struct · line 458
Quoted 1 line
drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c +0
-0return xgpu_vi_send_access_requests(adev,
IDH_REQ_GPU_RESET_ACCESS);Quoted 11 lines
drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c +5
-0} +static int xgpu_vi_wait_reset_cmpl (struct amdgpu_device *adev) +{ +return xgpu_vi_poll_msg (adev,IDH_FLR_NOTIFICATION_CMPL ); +} +static int xgpu_vi_request_full_gpu_access (struct amdgpu_device *adev,bool init) {drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c const struct amdgpu_virt_ops xgpu_vi_virt_ops = { · line 622
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c +1
-0@@ -613,5 +618,6 @@ const struct amdgpu_virt_ops xgpu_vi_virt_ops = { .req_full_gpu = xgpu_vi_request_full_gpu_access, .rel_full_gpu = xgpu_vi_release_full_gpu_access, .reset_gpu = xgpu_vi_request_reset, + .wait_reset = xgpu_vi_wait_reset_cmpl, .trans_msg = NULL, /* Does not need to trans VF errorsto host. */
Quoted 4 lines
drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c +0
-1}; --2.9.5
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx