tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled
PATCH v2 1/1 tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled
The frontbuffer_tracking PSR tests fail if PSR cannot be activated when there is sink support. But, there are several other requirements related to mode timings that have to be satisfied before PSR can be enabled. No reason to fail these tests when PSR cannot be enabled.
v2: Check for Source_OK instead of Enabled (Paulo)
--- tests/kms_frontbuffer_tracking.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
tests/kms_frontbuffer_tracking.c +5 -4
@@ -1548,12 +1548,13 @@ static void teardown_fbc(void) { } -static bool psr_sink_has_support (void ) +static bool psr_has_support (void ) {char buf[256 ];debugfs_read ("i915_edp_psr_status" , buf); -return strstr (buf,"Sink_Support: yes\n" ); +return strstr (buf,"Sink_Support: yes\n" ) && +strstr (buf,"Source_OK: yes\n" ); }static void setup_psr (void )
@@ -1564,8 +1565,8 @@ static void setup_psr(void)return ; } -if (!psr_sink_has_support ()) { -igt_info ("Can't test PSR: not supported by sink.\n" ); +if (!psr_has_support ()) { +igt_info ("Can't test PSR: not supported.\n" );return ; } psr.can_test = true;
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · Dhinakaran Pandiyan
The
frontbuffer_trackingPSR tests fail if PSR cannot be activated when there is sink support. But, there are several other requirements related to mode timings that have to be satisfied before PSR can be enabled. No reason to fail these tests when PSR cannot be enabled.v2: Check for
Source_OKinstead of Enabled (Paulo)
Checking for Source_OK is as good as checking for Enabled as we don't bail out on enabling PSR after conditions are met. But checking Source_OK seems slight better in case the enable_sink(), enable_source() functions in intel_psr_enable() return errors in the future.
Quoted 28 lines
Cc Paulo Zanoni <[email protected]>Cc Rodrigo Vivi <[email protected]>Signed-off-by Dhinakaran Pandiyan <[email protected]>--- tests/kms_frontbuffer_tracking.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)tests/kms_frontbuffer_tracking.c +3
-2@@ -1548,12 +1548,13 @@ static void teardown_fbc(void) { } -static bool psr_sink_has_support (void ) +static bool psr_has_support (void ) {char buf[256 ];debugfs_read ("i915_edp_psr_status" , buf); -return strstr (buf,"Sink_Support: yes\n" ); +return strstr (buf,"Sink_Support: yes\n" ) && +strstr (buf,"Source_OK: yes\n" ); }static void setup_psr (void )
tests/kms_frontbuffer_tracking.c static void setup_psr(void) · line 1572
Quoted 10 lines
tests/kms_frontbuffer_tracking.c +2
-2@@ -1564,8 +1565,8 @@ static void setup_psr(void)return ; } -if (!psr_sink_has_support ()) { -igt_info ("Can't test PSR: not supported by sink.\n" ); +if (!psr_has_support ()) { +igt_info ("Can't test PSR: not supported.\n" );return ; } psr.can_test = true;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled (rev2)
In reply to Dhinakaran Pandiyan== Series Details ==
== Series Details ==
Series: tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled (rev2)
URL : https://patchwork.freedesktop.org/series/32667/
State : success
== Summary ==
IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_exec_latency: Wire up an interloper for preemption
with latest DRM-Tip kernel build CI_DRM_3288ab2f06448939 drm-tip: 2017y-10m-26d-22h-25m-08s UTC integration manifest
No testlist changes.
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:442s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:454s fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:379s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:530s fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:265s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:498s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:497s fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:498s fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:478s fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:553s fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:611s fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:427s fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:254s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:580s fi-glk-dsi total:289 pass:258 dwarn:0 dfail:0 fail:1 skip:30 time:492s fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:430s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:433s fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:435s fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:492s fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:462s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:501s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:582s fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:479s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:588s fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:555s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:450s fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:596s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:644s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:527s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:498s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:466s fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:567s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:420s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_429/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled (rev2)
In reply to Dhinakaran Pandiyan== Series Details ==
== Series Details ==
Series: tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled (rev2)
URL : https://patchwork.freedesktop.org/series/32667/
State : success
== Summary ==
Test kms_flip:
Subgroup modeset-vs-vblank-race-interruptible:
pass -> FAIL (shard-hsw) fdo#103060
Test kms_sysfs_edid_timing:
pass -> WARN (shard-hsw) fdo#100047
Test kms_busy:
Subgroup extended-modeset-hang-oldfb-with-reset-render-C:
dmesg-warn -> PASS (shard-hsw) fdo#102249 +1
Test drv_module_reload:
Subgroup basic-no-display:
pass -> DMESG-WARN (shard-hsw) fdo#102707
Test perf:
Subgroup blocking:
fail -> PASS (shard-hsw) fdo#102252fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#102249 https://bugs.freedesktop.org/show_bug.cgi?id=102249
fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
shard-hsw total:2539 pass:1430 dwarn:2 dfail:0 fail:9 skip:1097 time:9226s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_429/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx