videomode: provide dummy of_get_display_timing helper
PATCH 1/1 videomode: provide dummy of_get_display_timing helper
If CONFIG_OF is disabled but we build any driver that tries to use of_get_display_timing, we get this link error:
ERROR: "of_get_display_timing" [drivers/gpu/drm/rcar-du/rcar-du-drm.ko] undefined!
This adds an empty inline function as an alternative, to avoid changing each driver using this function when we want to build them without CONFIG_OF.
include/video/of_display_timing.h +9 -0
@@ -15,8 +15,17 @@ struct display_timings;#define OF_USE_NATIVE_MODE -1 +#ifdef CONFIG_OF int of_get_display_timing (struct device_node *np,const char *name,struct display_timing *dt); +#else +static inline int of_get_display_timing (struct device_node *np,const char *name, +struct display_timing *dt) +{ +return -ENOSYS ; +} + +#endif struct display_timings *of_get_display_timings (struct device_node *np);int of_display_timings_exist (struct device_node *np);
Hi Arnd,
Thank you for the patch.
Quoted 11 lines · On Monday 29 September 2014 18:00:33 Arnd Bergmann wrote:
If
CONFIG_OFis disabled but we build any driver that tries to useof_get_display_timing, we get this link error:ERROR: "
of_get_display_timing" [drivers/gpu/drm/rcar-du/rcar-du-drm.ko] undefined!This adds an empty inline function as an alternative, to avoid changing each driver using this function when we want to build them without
CONFIG_OF.Signed-off-by Arnd Bergmann <[email protected]>
Shouldn't empty functions also be defined for of_get_display_timings and of_display_timings_exist ?
Quoted 22 lines
(quoted diff) +0
-0
b/include/video/of_display_timing.hindex79e6697af6cf..02b6eb7c3ded100644include/video/of_display_timing.h +9
-0@@ -15,8 +15,17 @@ struct display_timings;#define OF_USE_NATIVE_MODE -1 +#ifdef CONFIG_OF int of_get_display_timing (struct device_node *np,const char *name,struct display_timing *dt); +#else +static inline int of_get_display_timing (struct device_node *np,const char *name, +struct display_timing *dt) +{ +return -ENOSYS ; +} + +#endif struct display_timings *of_get_display_timings (struct device_node *np);int of_display_timings_exist (struct device_node *np);
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 11 lines · Laurent Pinchart
Hi Arnd,
Thank you for the patch.
Quoted 6 lines · On Monday 29 September 2014 18:00:33 Arnd Bergmann wrote:
If
CONFIG_OFis disabled but we build any driver that tries to useof_get_display_timing, we get this link error:ERROR: "
of_get_display_timing" [drivers/gpu/drm/rcar-du/rcar-du-drm.ko] undefined!
Quoted 8 lines
Quoted 5 lines
This adds an empty inline function as an alternative, to avoid changing each driver using this function when we want to build them without
CONFIG_OF.Signed-off-by Arnd Bergmann <[email protected]>Shouldn't empty functions also be defined for
of_get_display_timingsandof_display_timings_exist?
I took the liberty of updating the patch.
Btw, if I just select "Renesas ARM SoCs (non-multiplatform)", without any of the "Renesas ARM SoCs System Type" items, I get compile prints like "warning:
"__LINUX_ARM_ARCH__" is not defined".
And if I select only "ARCH_SH7372", I get "arm-linux-gnueabihf-ld: no machine record defined".
In any case, I was able to compile the drivers/gpu/drm/rcar-du/rcar-du-drm.ko, so I believe the patch is ok.
Tomi
From bd1815e4bff50b5569d1989aaf9096d14ce71d12 Mon Sep 17 00:00:00 2001
From: Tomi Valkeinen <[email protected]>
Date: Mon, 6 Oct 2014 15:03:57 +0300
Subject: [PATCH] videomode: provide dummy inline functions for !CONFIG_OF
If CONFIG_OF is disabled but we build any driver that tries to use of_get_display_timing, we get this link error:
ERROR: "of_get_display_timing" [drivers/gpu/drm/rcar-du/rcar-du-drm.ko] undefined!
This adds an empty inline function as an alternative, to avoid changing each driver using this function when we want to build them without CONFIG_OF.
--- include/video/of_display_timing.h | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
include/video/of_display_timing.h +17 -0
@@ -15,9 +15,26 @@ struct display_timings;#define OF_USE_NATIVE_MODE -1 +#ifdef CONFIG_OF int of_get_display_timing (struct device_node *np,const char *name,struct display_timing *dt);struct display_timings *of_get_display_timings (struct device_node *np);int of_display_timings_exist (struct device_node *np); +#else +static inline int of_get_display_timing (struct device_node *np,const char *name, +struct display_timing *dt) +{ +return -ENOSYS ; +} +static inline struct display_timings *of_get_display_timings (struct device_node *np) +{ +return NULL ; +} +static inline int of_display_timings_exist (struct device_node *np) +{ +return -ENOSYS ; +} + +#endif #endif
Signature · 1 line
2.1.1