armv8: ls1088ardb: Add SCSI related configs in header file for RDB
PATCH v2 1/2 armv8: ls1088ardb: Add SCSI related configs in header file for RDB
--- include/configs/ls1088ardb.h | 13 +++++++++++++ 1 file changed, 13 insertions(+)
include/configs/ls1088ardb.h +13 -0
@@ -293,6 +293,19 @@#define CONFIG_PHY_GIGE #endif +/* SATA */ +#define CONFIG_LIBATA +#define CONFIG_SCSI_AHCI +#define CONFIG_SCSI_AHCI_PLAT +#define CONFIG_CMD_SCSI +#define CONFIG_SCSI +#define CONFIG_SYS_SATA1 AHCI_BASE_ADDR1 + +#define CONFIG_SYS_SCSI_MAX_SCSI_ID 1 +#define CONFIG_SYS_SCSI_MAX_LUN 1 +#define CONFIG_SYS_SCSI_MAX_DEVICE (CONFIG_SYS_SCSI_MAX_SCSI_ID * \ + CONFIG_SYS_SCSI_MAX_LUN) +/* MMC */ #ifdef CONFIG_MMC #define CONFIG_FSL_ESDHC
Signature · 1 line
2.7.4
PATCH v2 2/2 armv8: ls1088aqds: Add SCSI related configs in header file for QDS
--- include/configs/ls1088aqds.h | 13 +++++++++++++ 1 file changed, 13 insertions(+)
include/configs/ls1088aqds.h +13 -0
@@ -360,6 +360,19 @@ unsigned long get_board_ddr_clk(void); "mcmemsize=0x70000000 \0"#endif +/* SATA */ +#define CONFIG_LIBATA +#define CONFIG_SCSI_AHCI +#define CONFIG_SCSI_AHCI_PLAT +#define CONFIG_CMD_SCSI +#define CONFIG_SCSI +#define CONFIG_SYS_SATA1 AHCI_BASE_ADDR1 + +#define CONFIG_SYS_SCSI_MAX_SCSI_ID 1 +#define CONFIG_SYS_SCSI_MAX_LUN 1 +#define CONFIG_SYS_SCSI_MAX_DEVICE (CONFIG_SYS_SCSI_MAX_SCSI_ID * \ + CONFIG_SYS_SCSI_MAX_LUN) +#ifdef CONFIG_FSL_MC_ENET #define CONFIG_FSL_MEMAC #define CONFIG_PHYLIB
Signature · 1 line
2.7.4
PATCH v2 1/2 armv8: ls1088ardb: Add SCSI related configs in header file for RDB
In reply to Ashish KumarQuoted 3 lines · Ashish Kumar
Signed-off-by Amrita Kumari <[email protected]>Signed-off-by Ashish Kumar <[email protected]>---
Change log?
Quoted 18 lines
include/configs/ls1088ardb.h | 13 +++++++++++++ 1 file changed, 13 insertions(+)include/configs/ls1088ardb.h +6
-0@@ -293,6 +293,19 @@#define CONFIG_PHY_GIGE #endif +/* SATA */ +#define CONFIG_LIBATA +#define CONFIG_SCSI_AHCI +#define CONFIG_SCSI_AHCI_PLAT +#define CONFIG_CMD_SCSI +#define CONFIG_SCSI
include/configs/ls1088ardb.h line 311
Quoted 10 lines
include/configs/ls1088ardb.h +7
-0+#define CONFIG_SYS_SATA1 AHCI_BASE_ADDR1 + +#define CONFIG_SYS_SCSI_MAX_SCSI_ID 1 +#define CONFIG_SYS_SCSI_MAX_LUN 1 +#define CONFIG_SYS_SCSI_MAX_DEVICE (CONFIG_SYS_SCSI_MAX_SCSI_ID * \ + CONFIG_SYS_SCSI_MAX_LUN) +/* MMC */ #ifdef CONFIG_MMC #define CONFIG_FSL_ESDHC
Please check my comments to your first version. It still applied.
York
PATCH v2 1/2 armv8: ls1088ardb: Add SCSI related configs in header file for RDB
Quoted 29 lines · York Sun
Quoted 3 lines · Ashish Kumar
Signed-off-by Amrita Kumari <[email protected]>Signed-off-by Ashish Kumar <[email protected]>---
Change log?
Quoted 22 lines
include/configs/ls1088ardb.h | 13 +++++++++++++ 1 file changed, 13 insertions(+)include/configs/ls1088ardb.h +11
-0@@ -293,6 +293,19 @@#define CONFIG_PHY_GIGE #endif +/* SATA */ +#define CONFIG_LIBATA +#define CONFIG_SCSI_AHCI +#define CONFIG_SCSI_AHCI_PLAT +#define CONFIG_CMD_SCSI +#define CONFIG_SCSI +#define CONFIG_SYS_SATA1 AHCI_BASE_ADDR1 + +#define CONFIG_SYS_SCSI_MAX_SCSI_ID 1 +#define CONFIG_SYS_SCSI_MAX_LUN 1 +#define CONFIG_SYS_SCSI_MAX_DEVICE (CONFIG_SYS_SCSI_MAX_SCSI_ID * \
Quoted 8 lines
include/configs/ls1088ardb.h line 311
Quoted 6 lines
include/configs/ls1088ardb.h +2
-0+ CONFIG_SYS_SCSI_MAX_LUN) +/* MMC */ #ifdef CONFIG_MMC #define CONFIG_FSL_ESDHC Please check my comments to your first version. It still applied.
Sorry, my bad. My comment was on the patch submitted by Andy Tang. You both changed the same. Please work together to update the patches.
York
PATCH v2 1/2 armv8: ls1088ardb: Add SCSI related configs in header file for RDB
-----Original Message-----
From: York Sun
Sent: Tuesday, October 31, 2017 12:37 AM
To: Ashish Kumar <[email protected]>; u-boot at lists.denx.de
Cc: Amrita Kumari <[email protected]>
Subject: Re: [Patch V2 1/2] armv8: ls1088ardb: Add SCSI related configs in header file for RDB
Quoted 29 lines · York Sun
Quoted 3 lines · Ashish Kumar
Signed-off-by Amrita Kumari <[email protected]>Signed-off-by Ashish Kumar <[email protected]>---
Change log?
Quoted 22 lines
include/configs/ls1088ardb.h | 13 +++++++++++++ 1 file changed, 13 insertions(+)(quoted diff) +0
-0
b/include/configs/ls1088ardb.hindex 958d472..8fdc576 100644include/configs/ls1088ardb.h +11
-0@@ -293,6 +293,19 @@#define CONFIG_PHY_GIGE #endif +/* SATA */ +#define CONFIG_LIBATA +#define CONFIG_SCSI_AHCI +#define CONFIG_SCSI_AHCI_PLAT +#define CONFIG_CMD_SCSI +#define CONFIG_SCSI +#define CONFIG_SYS_SATA1 AHCI_BASE_ADDR1 + +#define CONFIG_SYS_SCSI_MAX_SCSI_ID 1 +#define CONFIG_SYS_SCSI_MAX_LUN 1 +#define CONFIG_SYS_SCSI_MAX_DEVICE (CONFIG_SYS_SCSI_MAX_SCSI_ID * \
Quoted 8 lines
include/configs/ls1088ardb.h line 311
Quoted 6 lines
include/configs/ls1088ardb.h +2
-0+ CONFIG_SYS_SCSI_MAX_LUN) +/* MMC */ #ifdef CONFIG_MMC #define CONFIG_FSL_ESDHC Please check my comments to your first version. It still applied.
Sorry, my bad. My comment was on the patch submitted by Andy Tang. You both changed the same. Please work together to update the patches.
As discussed with Andy, I will send next version. Andy to supersede his patch set.
Regards
Ashish
York