Skip to contentSkip to conversation

Patch "ovl: handle ENOENT on index lookup" has been added to the 4.13-stable tree

PATCH [email protected] 1 participant 1 message Oct 30, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ovl: handle ENOENT on index lookup

to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ovl-handle-enoent-on-index-lookup.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 7937a56fdf0b064c2ffa33025210f725a4ebc822 Mon Sep 17 00:00:00 2001

From: Amir Goldstein <[email protected]>
Date: Fri, 20 Oct 2017 17:19:06 +0300
Subject: ovl: handle ENOENT on index lookup

From: Amir Goldstein <[email protected]>

commit 7937a56fdf0b064c2ffa33025210f725a4ebc822 upstream.

Treat ENOENT from index entry lookup the same way as treating a returned negative dentry. Apparently, either could be returned if file is not found, depending on the underlying file system.

Fixes 359f392ca53e ("ovl: lookup index entry for copy up origin")
---
 fs/overlayfs/namei.c |    4 ++++
 1 file changed, 4 insertions(+)
fs/overlayfs/namei.c +4 -0
@@ -507,6 +507,10 @@ static struct dentry *ovl_lookup_index(s
 	index = lookup_one_len_unlocked(name.name, ofs->indexdir, name.len);
 	if (IS_ERR(index)) {
 		err = PTR_ERR(index);
+		if (err == -ENOENT) {
+			index = NULL;
+			goto out;
+		}
 		pr_warn_ratelimited("overlayfs: failed inode index lookup (ino=%lu, key=%*s, err=%i);\n"
 				    "overlayfs: mount with '-o index=off' to disable inodes index.\n",
 				    d_inode(origin)->i_ino, name.len, name.name,

Patches currently in stable-queue which might be from [email protected] are

queue-4.13/ovl-handle-enoent-on-index-lookup.patch queue-4.13/ovl-fix-eio-from-lookup-of-non-indexed-upper.patch queue-4.13/ovl-do-not-cleanup-unsupported-index-entries.patch