Patch "can: kvaser_usb: Ignore CMD_FLUSH_QUEUE_REPLY messages" has been added to the 4.9-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
can: kvaser_usb: Ignore CMD_FLUSH_QUEUE_REPLY messages
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
can-kvaser_usb-ignore-cmd_flush_queue_reply-messages.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
e1d2d1329a5722dbecc9c278303fcc4aa01f8790Mon Sep 17 00:00:00 2001
From: Jimmy Assarsson <[email protected]>
Date: Tue, 24 Oct 2017 12:23:29 +0200
Subject: can: kvaser_usb: Ignore CMD_FLUSH_QUEUE_REPLY messages
From: Jimmy Assarsson <[email protected]>
commit e1d2d1329a5722dbecc9c278303fcc4aa01f8790 upstream.
To avoid kernel warning "Unhandled message (68)", ignore the CMD_FLUSH_QUEUE_REPLY message for now.
As of Leaf v2 firmware version v4.1.844 (2017-02-15), flush tx queue is synchronous. There is a capability bit indicating whether flushing tx queue is synchronous or asynchronous.
A proper solution would be to query the device for capabilities. If the synchronous tx flush capability bit is set, we should wait for CMD_FLUSH_QUEUE_REPLY message, while flushing the tx queue.
--- drivers/net/can/usb/kvaser_usb.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/net/can/usb/kvaser_usb.c +6 -0
@@ -137,6 +137,7 @@ static inline bool kvaser_is_usbcan(cons#define CMD_RESET_ERROR_COUNTER 49#define CMD_TX_ACKNOWLEDGE 50#define CMD_CAN_ERROR_EVENT 51 +#define CMD_FLUSH_QUEUE_REPLY 68#define CMD_LEAF_USB_THROTTLE 77#define CMD_LEAF_LOG_MESSAGE 106
@@ -1301,6 +1302,11 @@ static void kvaser_usb_handle_message(co goto warn;break ; +case CMD_FLUSH_QUEUE_REPLY : +if (dev->family !=KVASER_LEAF ) + goto warn; +break ; +default : warn:dev_warn (dev->udev->dev.parent,"Unhandled message (%d)\n" , msg->id);
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/can-kvaser_usb-correct-return-value-in-printout.patch queue-4.9/can-kvaser_usb-ignore-cmd_flush_queue_reply-messages.patch