usb: dwc2: add optional usb ecc reset bit
Subsystems (2)
PATCH 1/1 usb: dwc2: add optional usb ecc reset bit
The dwc2 USB controller in Stratix10 has an additional ECC reset bit that needs to get de-asserted in order for the controller to work properly.
Signed-off-by Dinh Nguyen <[email protected]>
--- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/platform.c | 10 ++++++++++ 2 files changed, 11 insertions(+)
drivers/usb/dwc2/core.h +1 -0
@@ -920,6 +920,7 @@ struct dwc2_hsotg {int irq;struct clk *clk;struct reset_control *reset; +struct reset_control *reset_ecc; unsigned int queuing_high_bandwidth:1; unsigned int srp_success:1;
drivers/usb/dwc2/platform.c +10 -0
@@ -220,6 +220,15 @@ static int dwc2_lowlevel_hw_init(struct dwc2_hsotg *hsotg)reset_control_deassert (hsotg->reset); + hsotg->reset_ecc =devm_reset_control_get_optional (hsotg->dev,"dwc2-ecc" ); +if (IS_ERR (hsotg->reset_ecc)) { + ret =PTR_ERR (hsotg->reset_ecc); +dev_err (hsotg->dev,"error getting reset control for ecc %d\n" , ret); +return ret; + } + +reset_control_deassert (hsotg->reset_ecc); +/* Set default UTMI width */ hsotg->phyif =GUSBCFG_PHYIF16 ;
@@ -318,6 +327,7 @@ static int dwc2_driver_remove(struct platform_device *dev)dwc2_lowlevel_hw_disable (hsotg);reset_control_assert (hsotg->reset); +reset_control_assert (hsotg->reset_ecc);return 0 ; }
Signature · 1 line
2.7.4
Hi John,
was wondering if you have gotten a chance to review this?
Thank,
Dinh
Quoted 50 lines · Dinh Nguyen
The dwc2 USB controller in Stratix10 has an additional ECC reset bit that needs to get de-asserted in order for the controller to work properly.
Signed-off-by Dinh Nguyen <[email protected]>--- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/platform.c | 10 ++++++++++ 2 files changed, 11 insertions(+)drivers/usb/dwc2/core.h +1
-0@@ -920,6 +920,7 @@ struct dwc2_hsotg {int irq;struct clk *clk;struct reset_control *reset; +struct reset_control *reset_ecc; unsigned int queuing_high_bandwidth:1; unsigned int srp_success:1;drivers/usb/dwc2/platform.c +10
-0@@ -220,6 +220,15 @@ static int dwc2_lowlevel_hw_init(struct dwc2_hsotg *hsotg)reset_control_deassert (hsotg->reset); + hsotg->reset_ecc =devm_reset_control_get_optional (hsotg->dev,"dwc2-ecc" ); +if (IS_ERR (hsotg->reset_ecc)) { + ret =PTR_ERR (hsotg->reset_ecc); +dev_err (hsotg->dev,"error getting reset control for ecc %d\n" , ret); +return ret; + } + +reset_control_deassert (hsotg->reset_ecc); +/* Set default UTMI width */ hsotg->phyif =GUSBCFG_PHYIF16 ;@@ -318,6 +327,7 @@ static int dwc2_driver_remove(struct platform_device *dev)dwc2_lowlevel_hw_disable (hsotg);reset_control_assert (hsotg->reset); +reset_control_assert (hsotg->reset_ecc);return 0 ; }
Quoted 43 lines · Dinh Nguyen
The dwc2 USB controller in Stratix10 has an additional ECC reset bit that needs to get de-asserted in order for the controller to work properly.
Signed-off-by Dinh Nguyen <[email protected]>--- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/platform.c | 10 ++++++++++ 2 files changed, 11 insertions(+)drivers/usb/dwc2/core.h +1
-0@@ -920,6 +920,7 @@ struct dwc2_hsotg {int irq;struct clk *clk;struct reset_control *reset; +struct reset_control *reset_ecc; unsigned int queuing_high_bandwidth:1; unsigned int srp_success:1;drivers/usb/dwc2/platform.c +9
-0@@ -220,6 +220,15 @@ static int dwc2_lowlevel_hw_init(struct dwc2_hsotg *hsotg)reset_control_deassert (hsotg->reset); + hsotg->reset_ecc =devm_reset_control_get_optional (hsotg->dev,"dwc2-ecc" ); +if (IS_ERR (hsotg->reset_ecc)) { + ret =PTR_ERR (hsotg->reset_ecc); +dev_err (hsotg->dev,"error getting reset control for ecc %d\n" , ret); +return ret; + } + +reset_control_deassert (hsotg->reset_ecc); +/* Set default UTMI width */ hsotg->phyif =GUSBCFG_PHYIF16 ;
drivers/usb/dwc2/platform.c static int dwc2_driver_remove(struct platform_device *dev) · line 333
Quoted 7 lines
drivers/usb/dwc2/platform.c +1
-0@@ -318,6 +327,7 @@ static int dwc2_driver_remove(struct platform_device *dev)dwc2_lowlevel_hw_disable (hsotg);reset_control_assert (hsotg->reset); +reset_control_assert (hsotg->reset_ecc);return 0 ; }
Acked-by John Youn <[email protected]>
John