stmmac: use of_property_read_u32 instead of read_u8
Subsystems (4)
PATCH 1/1 stmmac: use of_property_read_u32 instead of read_u8
Numbers in DT are stored in “cells” which are 32-bits in size. of_property_read_u8 does not work properly because of endianness problem.
This causes it to always return 0 with little-endian architectures.
Fix it by using of_property_read_u32() OF API.
Signed-off-by Bhadram Varka <[email protected]>
--- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 16 ++++++++-------- include/linux/stmmac.h | 8 ++++---- 2 files changed, 12 insertions(+), 12 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +8 -8
@@ -161,8 +161,8 @@ static void stmmac_mtl_setup(struct platform_device *pdev, }/* Processing RX queues common config */ -if (of_property_read_u8 (rx_node,"snps,rx-queues-to-use" , - &plat->rx_queues_to_use)) +if (of_property_read_u32 (rx_node,"snps,rx-queues-to-use" , + &plat->rx_queues_to_use)) plat->rx_queues_to_use =1 ;if (of_property_read_bool (rx_node,"snps,rx-sched-sp" ))
@@ -184,8 +184,8 @@ static void stmmac_mtl_setup(struct platform_device *pdev,else plat->rx_queues_cfg[queue].mode_to_use =MTL_QUEUE_DCB ; -if (of_property_read_u8 (q_node,"snps,map-to-dma-channel" , - &plat->rx_queues_cfg[queue].chan)) +if (of_property_read_u32 (q_node,"snps,map-to-dma-channel" , + &plat->rx_queues_cfg[queue].chan)) plat->rx_queues_cfg[queue].chan = queue;/* TODO: Dynamic mapping to be included in the future */
@@ -215,8 +215,8 @@ static void stmmac_mtl_setup(struct platform_device *pdev, }/* Processing TX queues common config */ -if (of_property_read_u8 (tx_node,"snps,tx-queues-to-use" , - &plat->tx_queues_to_use)) +if (of_property_read_u32 (tx_node,"snps,tx-queues-to-use" , + &plat->tx_queues_to_use)) plat->tx_queues_to_use =1 ;if (of_property_read_bool (tx_node,"snps,tx-sched-wrr" ))
@@ -237,8 +237,8 @@ static void stmmac_mtl_setup(struct platform_device *pdev,if (queue >= plat->tx_queues_to_use)break ; -if (of_property_read_u8 (q_node,"snps,weight" , - &plat->tx_queues_cfg[queue].weight)) +if (of_property_read_u32 (q_node,"snps,weight" , + &plat->tx_queues_cfg[queue].weight)) plat->tx_queues_cfg[queue].weight =0x10 + queue;if (of_property_read_bool (q_node,"snps,dcb-algorithm" )) {
include/linux/stmmac.h +4 -4
@@ -126,14 +126,14 @@ struct stmmac_axi {struct stmmac_rxq_cfg {u8 mode_to_use; -u8 chan; +u32 chan;u8 pkt_route;bool use_prio;u32 prio; };struct stmmac_txq_cfg { -u8 weight; +u32 weight;u8 mode_to_use;/* Credit Base Shaper parameters */ u32 send_slope;
@@ -168,8 +168,8 @@ struct plat_stmmacenet_data {int unicast_filter_entries;int tx_fifo_size;int rx_fifo_size; -u8 rx_queues_to_use; -u8 tx_queues_to_use; +u32 rx_queues_to_use; +u32 tx_queues_to_use;u8 rx_sched_algorithm;u8 tx_sched_algorithm;struct stmmac_rxq_cfg rx_queues_cfg[MTL_MAX_RX_QUEUES ];
Signature · 1 line
2.7.4
From: Bhadram Varka <[email protected]>
Date: Thu, 2 Nov 2017 12:52:13 +0530
Quoted 10 lines
Numbers in DT are stored in “cells” which are 32-bits in size.
of_property_read_u8does not work properly because of endianness problem.This causes it to always return 0 with little-endian architectures.
Fix it by using
of_property_read_u32()OF API.Signed-off-by Bhadram Varka <[email protected]>
Applied, thank you.