Skip to contentSkip to conversation

USB: dummy-hcd: don't set gadget.speed in dummy_hub_control()

PATCH In review Roger Quadros 2 participants 2 messages Nov 3, 2017 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB: dummy-hcd: don't set gadget.speed in dummy_hub_control()

There will never be a case when gadget.speed isn't already USB_SPEED_FULL if connection is not USB-3 and gadget.speed is not USB_SPEED_HIGH or USB_SPEED_LOW.

Remove the unnecessary code.

---
 drivers/usb/gadget/udc/dummy_hcd.c | 2 --
 1 file changed, 2 deletions(-)
drivers/usb/gadget/udc/dummy_hcd.c +0 -2
index c42ca8e..41cefc5 100644
@@ -2166,8 +2166,6 @@ static int dummy_hub_control(
 							USB_PORT_STAT_LOW_SPEED;
 						break;
 					default:
-						dum_hcd->dum->gadget.speed =
-							USB_SPEED_FULL;
 						break;
 					}
 				}
Signature · 4 lines
cheers,
-roger

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Acked-by on v1 1/1
#1 lore raw
Quoted 16 lines · Roger Quadros

There will never be a case when gadget.speed isn't already USB_SPEED_FULL if connection is not USB-3 and gadget.speed is not USB_SPEED_HIGH or USB_SPEED_LOW.

Remove the unnecessary code.

---
 drivers/usb/gadget/udc/dummy_hcd.c | 2 --
 1 file changed, 2 deletions(-)
drivers/usb/gadget/udc/dummy_hcd.c +0 -0
index c42ca8e..41cefc5 100644

drivers/usb/gadget/udc/dummy_hcd.c static int dummy_hub_control( · line 2171

Quoted 8 lines
drivers/usb/gadget/udc/dummy_hcd.c +0 -2
@@ -2166,8 +2166,6 @@ static int dummy_hub_control(
 							USB_PORT_STAT_LOW_SPEED;
 						break;
 					default:
-						dum_hcd->dum->gadget.speed =
-							USB_SPEED_FULL;
 						break;
 					}
 				}