Skip to contentSkip to conversation

Add support for ORISE OTM3225A LCD SoC

PATCH In review Felix Brack 2 participants 4 messages Nov 3, 2017 – Dec 20, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add support for ORISE OTM3225A LCD SoC

This patch adds a LCD driver supporting the OTM3225A LCD SoC from ORISE Technology. This device can drive TFT LC panels having a resolution of 240x320 pixels. After initializing the OTM3225A using it's SPI interface it switches to use 16-bib RGB as external display interface.

---
 drivers/video/backlight/Kconfig    |   7 ++
 drivers/video/backlight/Makefile   |   1 +
 drivers/video/backlight/otm3225a.c | 210 +++++++++++++++++++++++++++++++++++++
 3 files changed, 218 insertions(+)
 create mode 100644 drivers/video/backlight/otm3225a.c
drivers/video/backlight/Kconfig +7 -0
index 4e1d2ad..06e187b 100644
@@ -150,6 +150,13 @@ config LCD_HX8357
 	  If you have a HX-8357 LCD panel, say Y to enable its LCD control
 	  driver.
 
+  config LCD_OTM3225A
+  	tristate "ORISE Technology OTM3225A support"
+  	depends on SPI
+  	help
+  	  If you have a panel based on the OTM3225A controller
+  	  chip then say y to include a driver for it.
+
 endif # LCD_CLASS_DEVICE
 
 #
drivers/video/backlight/Makefile +1 -0
index 8905129..b177b91 100644
@@ -17,6 +17,7 @@ obj-$(CONFIG_LCD_S6E63M0)		+= s6e63m0.o
 obj-$(CONFIG_LCD_TDO24M)		+= tdo24m.o
 obj-$(CONFIG_LCD_TOSA)			+= tosa_lcd.o
 obj-$(CONFIG_LCD_VGG2432A4)		+= vgg2432a4.o
+obj-$(CONFIG_LCD_OTM3225A)		+= otm3225a.o
 
 obj-$(CONFIG_BACKLIGHT_88PM860X)	+= 88pm860x_bl.o
 obj-$(CONFIG_BACKLIGHT_AAT2870)		+= aat2870_bl.o
drivers/video/backlight/otm3225a.c new file +210 -0

210 lines not on this page · raw message

Signature · 1 line
2.7.4
#1 lore raw

Just a gentle echo request ;-)
Is there something completely wrong with this patch or am I just too impatient?

regards Felix

Quoted 8 lines · Felix Brack

This patch adds a LCD driver supporting the OTM3225A LCD SoC from ORISE Technology. This device can drive TFT LC panels having a resolution of 240x320 pixels. After initializing the OTM3225A using it's SPI interface it switches to use 16-bib RGB as external display interface.

---

#2 lore raw
Quoted 4 lines · Felix Brack

Just a gentle echo request ;-)
Is there something completely wrong with this patch or am I just too impatient?

Quoted 8 lines

regards Felix

Quoted 5 lines · Felix Brack

This patch adds a LCD driver supporting the OTM3225A LCD SoC from ORISE Technology. This device can drive TFT LC panels having a resolution of 240x320 pixels. After initializing the OTM3225A using it's SPI interface it switches to use 16-bib RGB as external display interface.

Was this a backlight driver? I've just noticed all the backlight maintainers on Cc: but the subject doesn't make this obvious and even with you quoting the patch header I still can't be entirely sure!

As a result I think its very likely the patch simply got overlooked because it didn't look much like a backlight driver when filtering e-mail. Patches that can't be easily categorized from the subject line will often get overlooked.

So, asssuming this was a backlight driver, could you resend the patch with an updated description and a subject line commenting:
[PATCH] backlight: otm3225a:

Daniel.

#3 lore raw

Hi Daniel,

Quoted 14 lines · Daniel Thompson
Quoted 4 lines · Felix Brack

Just a gentle echo request ;-)
Is there something completely wrong with this patch or am I just too impatient?

Quoted 8 lines

regards Felix

Quoted 5 lines · Felix Brack

This patch adds a LCD driver supporting the OTM3225A LCD SoC from ORISE Technology. This device can drive TFT LC panels having a resolution of 240x320 pixels. After initializing the OTM3225A using it's SPI interface it switches to use 16-bib RGB as external display interface.

Quoted 4 lines

Was this a backlight driver? I've just noticed all the backlight maintainers on Cc: but the subject doesn't make this obvious and even with you quoting the patch header I still can't be entirely sure!

Yes it is a backlight driver. Sorry for not quoting the entire message.

Quoted 9 lines

As a result I think its very likely the patch simply got overlooked because it didn't look much like a backlight driver when filtering e-mail. Patches that can't be easily categorized from the subject line will often get overlooked.

So, asssuming this was a backlight driver, could you resend the patch with an updated description and a subject line commenting:
[PATCH] backlight: otm3225a:

Okay, I will.

Quoted 3 lines

Daniel.

regards Felix