Skip to contentSkip to conversation

libevdev: add libcheck dependency

PATCH In review Andre McCurdy 1 participant 2 messages Nov 3, 2017 – Nov 7, 2017

lore
Share & tools
lore

Andre McCurdy

author
#0 lore raw

PATCH 1/1 libevdev: add libcheck dependency

The libevdev configure script contains an unconditional check for libcheck. If libcheck is found, libevdev unit tests will be built.

Without a dependency, the presence of libcheck in sysroot is non deterministic (in morty and earlier) and builds can fail if libcheck is available during do_configure but not during do_compile.

(In pyro and later, the libcheck dependency is not required to make libevdev builds deterministic due to recipe specific sysroots).

Signed-off-by Andre McCurdy <[email protected]>
---
 meta/recipes-support/libevdev/libevdev_1.5.2.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-support/libevdev/libevdev_1.5.2.bb +2 -0
index c76e1d7..381d252 100644
@@ -6,6 +6,8 @@ LICENSE = "MIT-X"
 LIC_FILES_CHKSUM = "file://COPYING;md5=75aae0d38feea6fda97ca381cb9132eb \
                     file://libevdev/libevdev.h;endline=21;md5=7ff4f0b5113252c2f1a828e0bbad98d1"
 
+DEPENDS = "libcheck"
+
 SRC_URI = "http://www.freedesktop.org/software/libevdev/${BP}.tar.xz"
 
 SRC_URI[md5sum] = "96ad6edb5ce5c4428f1b183cc180ff8c"
Signature · 1 line
1.9.1
author
#1 lore raw
Quoted 9 lines · Andre McCurdy

The libevdev configure script contains an unconditional check for libcheck. If libcheck is found, libevdev unit tests will be built.

Without a dependency, the presence of libcheck in sysroot is non deterministic (in morty and earlier) and builds can fail if libcheck is available during do_configure but not during do_compile.

(In pyro and later, the libcheck dependency is not required to make libevdev builds deterministic due to recipe specific sysroots).

Ping. CCing Armin.

Quoted 21 lines
Signed-off-by Andre McCurdy <[email protected]>
---
 meta/recipes-support/libevdev/libevdev_1.5.2.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-support/libevdev/libevdev_1.5.2.bb +2 -1
index c76e1d7..381d252 100644
@@ -6,6 +6,8 @@ LICENSE = "MIT-X"
 LIC_FILES_CHKSUM = "file://COPYING;md5=75aae0d38feea6fda97ca381cb9132eb \
                     file://libevdev/libevdev.h;endline=21;md5=7ff4f0b5113252c2f1a828e0bbad98d1"
 
+DEPENDS = "libcheck"
+
 SRC_URI = "http://www.freedesktop.org/software/libevdev/${BP}.tar.xz"
 
 SRC_URI[md5sum] = "96ad6edb5ce5c4428f1b183cc180ff8c"
--

1.9.1