Skip to contentSkip to conversation

Patch "PM / QoS: Fix default runtime_pm device resume latency" has been added to the 4.13-stable tree

PATCH [email protected] 2 participants 3 messages Nov 5, 2017 – Nov 7, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

PM / QoS: Fix default runtime_pm device resume latency

to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
pm-qos-fix-default-runtime_pm-device-resume-latency.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 2a9a86d5c81389cd9afe6a4fea42c585733cd705 Mon Sep 17 00:00:00 2001

From: Tero Kristo <[email protected]>
Date: Mon, 30 Oct 2017 09:10:46 +0200
Subject: PM / QoS: Fix default runtime_pm device resume latency

From: Tero Kristo <[email protected]>

commit 2a9a86d5c81389cd9afe6a4fea42c585733cd705 upstream.

The recent change to the PM QoS framework to introduce a proper no constraint value overlooked to handle the devices which don't implement PM QoS OPS. Runtime PM is one of the more severely impacted subsystems, failing every attempt to runtime suspend a device. This leads into some nasty second level issues like probe failures and increased power consumption among other things.

Fix this by adding a proper return value for devices that don't implement PM QoS.

Fixes 0cc2b4e5a020 (PM / QoS: Fix device resume latency PM QoS)
---
 include/linux/pm_qos.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/linux/pm_qos.h +2 -1
@@ -175,7 +175,8 @@ static inline s32 dev_pm_qos_requested_f
 static inline s32 dev_pm_qos_raw_read_value(struct device *dev)
 {
 	return IS_ERR_OR_NULL(dev->power.qos) ?
-		0 : pm_qos_read_value(&dev->power.qos->resume_latency);
+		PM_QOS_RESUME_LATENCY_NO_CONSTRAINT :
+		pm_qos_read_value(&dev->power.qos->resume_latency);
 }
 #else
 static inline enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev,

Patches currently in stable-queue which might be from [email protected] are

queue-4.13/pm-qos-fix-default-runtime_pm-device-resume-latency.patch

#1 lore raw
Quoted 58 lines · On 11/5/2017 3:44 PM, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

PM / QoS: Fix default runtime_pm device resume latency

to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
pm-qos-fix-default-runtime_pm-device-resume-latency.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From 2a9a86d5c81389cd9afe6a4fea42c585733cd705 Mon Sep 17 00:00:00 2001
From: Tero Kristo <[email protected]>
Date: Mon, 30 Oct 2017 09:10:46 +0200
Subject: PM / QoS: Fix default runtime_pm device resume latency

From: Tero Kristo <[email protected]>

commit 2a9a86d5c81389cd9afe6a4fea42c585733cd705 upstream.

The recent change to the PM QoS framework to introduce a proper no constraint value overlooked to handle the devices which don't implement PM QoS OPS. Runtime PM is one of the more severely impacted subsystems, failing every attempt to runtime suspend a device. This leads into some nasty second level issues like probe failures and increased power consumption among other things.

Fix this by adding a proper return value for devices that don't implement PM QoS.

Fixes 0cc2b4e5a020 (PM / QoS: Fix device resume latency PM QoS)
---
  include/linux/pm_qos.h |    3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
include/linux/pm_qos.h +2 -1
@@ -175,7 +175,8 @@ static inline s32 dev_pm_qos_requested_f
  static inline s32 dev_pm_qos_raw_read_value(struct device *dev)
  {
  	return IS_ERR_OR_NULL(dev->power.qos) ?
-		0 : pm_qos_read_value(&dev->power.qos->resume_latency);
+		PM_QOS_RESUME_LATENCY_NO_CONSTRAINT :
+		pm_qos_read_value(&dev->power.qos->resume_latency);
  }
  #else
  static inline enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev,
Quoted 3 lines

Patches currently in stable-queue which might be from [email protected] are

queue-4.13/pm-qos-fix-default-runtime_pm-device-resume-latency.patch

Please drop this from the -stable queue, it has been reverted from the mainline.

Thanks,

Rafael

author maintainer
#2 lore raw
Quoted 59 lines · Rafael J. Wysocki
Quoted 58 lines · On 11/5/2017 3:44 PM, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

PM / QoS: Fix default runtime_pm device resume latency

to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
pm-qos-fix-default-runtime_pm-device-resume-latency.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From 2a9a86d5c81389cd9afe6a4fea42c585733cd705 Mon Sep 17 00:00:00 2001
From: Tero Kristo <[email protected]>
Date: Mon, 30 Oct 2017 09:10:46 +0200
Subject: PM / QoS: Fix default runtime_pm device resume latency

From: Tero Kristo <[email protected]>

commit 2a9a86d5c81389cd9afe6a4fea42c585733cd705 upstream.

The recent change to the PM QoS framework to introduce a proper no constraint value overlooked to handle the devices which don't implement PM QoS OPS. Runtime PM is one of the more severely impacted subsystems, failing every attempt to runtime suspend a device. This leads into some nasty second level issues like probe failures and increased power consumption among other things.

Fix this by adding a proper return value for devices that don't implement PM QoS.

Fixes 0cc2b4e5a020 (PM / QoS: Fix device resume latency PM QoS)
---
  include/linux/pm_qos.h |    3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
include/linux/pm_qos.h +2 -1
@@ -175,7 +175,8 @@ static inline s32 dev_pm_qos_requested_f
  static inline s32 dev_pm_qos_raw_read_value(struct device *dev)
  {
  	return IS_ERR_OR_NULL(dev->power.qos) ?
-		0 : pm_qos_read_value(&dev->power.qos->resume_latency);
+		PM_QOS_RESUME_LATENCY_NO_CONSTRAINT :
+		pm_qos_read_value(&dev->power.qos->resume_latency);
  }
  #else
  static inline enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev,
Quoted 6 lines
Quoted 3 lines

Patches currently in stable-queue which might be from [email protected] are

queue-4.13/pm-qos-fix-default-runtime_pm-device-resume-latency.patch

Please drop this from the -stable queue, it has been reverted from the mainline.

Ah, thanks for letting me know, now dropped.

greg k-h