Source code compatibility in Stable series????
Hi,
It seems that in 2.4.4 suddenly the function "skb_cow" no longer returns the modified skb, but it retuns and integer for succes/failure.
This means that for networking modules requiring this function, there is no source code compatibilty between 2.4.3 and 2.4.4.
Roger.
Signature · 4 lines
** [email protected] ** http://www.BitWizard.nl/ ** +31-15-2137555 ** *-- BitWizard writes Linux device drivers for any device you may have! --* * There are old pilots, and there are bold pilots. * There are also old, bald pilots.
Quoted 6 lines · Rogier Wolff
It seems that in 2.4.4 suddenly the function "
skb_cow" no longer returns the modified skb, but it retuns and integer for succes/failure.This means that for networking modules requiring this function, there is no source code compatibilty between 2.4.3 and 2.4.4.
And skb_datarefp went away too, in fact a ton of things changes.
Just deal with it.
Later,
David S. Miller
[email protected]
Quoted 6 lines · David S. Miller
Quoted 4 lines · Rogier Wolff
It seems that in 2.4.4 suddenly the function "
skb_cow" no longer returns the modified skb, but it retuns and integer for succes/failure.
Quoted 6 lines
Quoted 2 lines
This means that for networking modules requiring this function, there is no source code compatibilty between 2.4.3 and 2.4.4.
And
skb_datarefpwent away too, in fact a ton of things changes.Just deal with it.
I guess it would be possible to add a HAVE_ZEROCOPY to skbuff.h to make it a bit easier for single source drivers.
linux/skbuff.h renamed from linux/skbuff.h-o +1 -0
@@ -29,6 +29,7 @@#define HAVE_ALLOC_SKB /* For the drivers to know */ #define HAVE_ALIGNABLE_SKB /* Ditto 8) */ #define SLAB_SKB /* Slabified skbuffs */ +#define HAVE_ZEROCOPY /* Zerocopy stack */ #define CHECKSUM_NONE 0#define CHECKSUM_HW 1
-Andi
Quoted 2 lines · Andi Kleen
I guess it would be possible to add a
HAVE_ZEROCOPYtoskbuff.hto make it a bit easier for single source drivers.
Try MAX_SKB_FRAG, the drivers use that already.
Later,
David S. Miller
[email protected]