Skip to contentSkip to conversation

ref-manual: Removed misleading paragraph in siteinfo section

PATCH In review Yevgeny Popovych 3 participants 4 messages Nov 5, 2017 – Aug 14, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ref-manual: Removed misleading paragraph in siteinfo section

..on the inclusion of siteinfo.bbclass in base.bbclass. This is not true since 2010.

---
 documentation/ref-manual/ref-classes.xml | 6 ------
 1 file changed, 6 deletions(-)
documentation/ref-manual/ref-classes.xml +0 -6
index 5961d3e..fe41f9e 100644
@@ -3134,12 +3134,6 @@ This check was removed for YP 2.3 release
         and <filename><link linkend='var-SITEINFO_BITS'>SITEINFO_BITS</link></filename>
         that can be used elsewhere in the metadata.
     </para>
-
-    <para>
-        Because the
-        <link linkend='ref-classes-base'><filename>base</filename></link> class
-        includes the <filename>siteinfo</filename> class, it is always active.
-    </para>
 </section>
 
 <section id='ref-classes-spdx'>
Signature · 1 line
2.7.4
#1 lore raw

Hello Scott.

siteinfo was removed from base.bbclass by Richard Purdie in 2010 (commit 185cb38f1319856b4bdaaf4d9a73b5056be53d54 in openembedded-core).

Richard, can you confirm/reject this change?

Thanks!

Quoted 26 lines · Yevgeny Popovych

..on the inclusion of siteinfo.bbclass in base.bbclass. This is not true since 2010.

---
 documentation/ref-manual/ref-classes.xml | 6 ------
 1 file changed, 6 deletions(-)
documentation/ref-manual/ref-classes.xml +0 -6
index 5961d3e..fe41f9e 100644
@@ -3134,12 +3134,6 @@ This check was removed for YP 2.3 release
         and <filename><link linkend='var-SITEINFO_BITS'>SITEINFO_BITS</link></filename>
         that can be used elsewhere in the metadata.
     </para>
-
-    <para>
-        Because the
-        <link linkend='ref-classes-base'><filename>base</filename></link> class
-        includes the <filename>siteinfo</filename> class, it is always active.
-    </para>
 </section>
 
 <section id='ref-classes-spdx'>
Signature · 2 lines
Sincerely,
Yevgeny Popovych
#2 lore raw

Yevgeny and Richard,

See the siteinfo.bbclass section here -
https://yoctoproject.org/docs/2.6/ref-manual/ref-manual.html#ref-classes-siteinfo
.

Paragraph removed.

Thanks,
Scott

Quoted 46 lines · Yevgeny Popovych

Hello Scott.

siteinfo was removed from base.bbclass by Richard Purdie in 2010 (commit 185cb38f1319856b4bdaaf4d9a73b5056be53d54 in openembedded-core).

Richard, can you confirm/reject this change?

Thanks!

Review

Quoted 9 lines · Yevgeny Popovych

..on the inclusion of siteinfo.bbclass in base.bbclass. This is not true since 2010.

---
 documentation/ref-manual/ref-classes.xml | 6 ------
 1 file changed, 6 deletions(-)
(quoted diff) +0 -0

b/documentation/ref-manual/ref-classes.xml

documentation/ref-manual/ref-classes.xml This check was removed for YP 2.3 release · line 3134

Quoted 5 lines

index 5961d3e..fe41f9e 100644

documentation/ref-manual/ref-classes.xml +0 -0
@@ -3134,12 +3134,6 @@ This check was removed for YP 2.3 release
         and <filename><link

linkend='var-SITEINFO_BITS'>SITEINFO_BITS</link></filename>

documentation/ref-manual/ref-classes.xml This check was removed for YP 2.3 release

Quoted 6 lines
documentation/ref-manual/ref-classes.xml +0 -4
         that can be used elsewhere in the metadata.
     </para>
-
-    <para>
-        Because the
-        <link

linkend='ref-classes-base'><filename>base</filename></link> class

documentation/ref-manual/ref-classes.xml This check was removed for YP 2.3 release · line 3141

Quoted 1 line
documentation/ref-manual/ref-classes.xml +0 -1
-        includes the <filename>siteinfo</filename> class, it is always

active.

documentation/ref-manual/ref-classes.xml This check was removed for YP 2.3 release · line 3139

Quoted 5 lines
documentation/ref-manual/ref-classes.xml +0 -1
-    </para>
 </section>
 
 <section id='ref-classes-spdx'>

--
Sincerely,
Yevgeny Popovych

#3 lore raw
Quoted 6 lines · Scott Rifenbark

Yevgeny and Richard,

See the siteinfo.bbclass section here - https://yoctoproject.org/docs
/2.6/ref-manual/ref-manual.html#ref-classes-siteinfo.

Paragraph removed.

Looks good thanks.

Cheers,

Richard