Patch "drm/msm: Fix potential buffer overflow issue" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
drm/msm: Fix potential buffer overflow issue
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-msm-fix-potential-buffer-overflow-issue.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
4a630fadbb29d9efaedb525f1a8f7449ad107641Mon Sep 17 00:00:00 2001
From: Kasin Li <[email protected]>
Date: Mon, 19 Jun 2017 15:36:53 -0600
Subject: drm/msm: Fix potential buffer overflow issue
From: Kasin Li <[email protected]>
commit 4a630fadbb29d9efaedb525f1a8f7449ad107641 upstream.
In function submit_create, if nr_cmds or nr_bos is assigned with negative value, the allocated buffer may be small than intended. Using this buffer will lead to buffer overflow issue.
--- drivers/gpu/drm/msm/msm_gem_submit.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/gpu/drm/msm/msm_gem_submit.c +6 -3
@@ -31,11 +31,14 @@#define BO_PINNED 0x2000static struct msm_gem_submit *submit_create (struct drm_device *dev, -struct msm_gpu *gpu,int nr_bos,int nr_cmds) +struct msm_gpu *gpu,uint32_t nr_bos,uint32_t nr_cmds) {struct msm_gem_submit *submit; -int sz =sizeof (*submit) + (nr_bos *sizeof (submit->bos[0 ])) + - (nr_cmds *sizeof (*submit->cmd)); +uint64_t sz =sizeof (*submit) + (nr_bos *sizeof (submit->bos[0 ])) + + (nr_cmds *sizeof (submit->cmd[0 ])); + +if (sz >SIZE_MAX ) +return NULL ; submit =kmalloc (sz,GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);if (!submit)
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/drm-msm-fix-potential-buffer-overflow-issue.patch