release ex mode after hw_init
Subsystems (2)
Hi Felix,
Please review.
[PATCH 1/2] drm/amdkfd: initialise kfd inside amdgpu_device_init As you suggested, move kfd init/fini inside amdgpu_device_init. Other changes for KFD interfaces are dropped.
[PATCH 2/2] drm/amdgpu: release exclusive mode after hw_init
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1509956320-10208-1-git-send-email-Pixel.Ding-5C7GfCeVMHo@public.gmane.org
PATCH 1/2 drm/amdkfd: initialise kfd inside amdgpu_device_init
From: pding <[email protected]>
Also finalize kfd inside amdgpu_device_fini. kfd device_init needs SRIOV exclusive accessing. Try to gather exclusive accessing to reduce time consuming.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++++ drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 5 ----- 2 files changed, 4 insertions(+), 5 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +4 -0
@@ -1693,6 +1693,8 @@ static int amdgpu_early_init(struct amdgpu_device *adev)if (r)return r; +amdgpu_amdkfd_device_probe (adev); +if (amdgpu_sriov_vf (adev)) { r =amdgpu_virt_request_full_gpu (adev, true);if (r)
@@ -1787,6 +1789,7 @@ static int amdgpu_init(struct amdgpu_device *adev) adev->ip_blocks[i].status.hw = true; } +amdgpu_amdkfd_device_init (adev);return 0 ; }
@@ -1854,6 +1857,7 @@ static int amdgpu_fini(struct amdgpu_device *adev) {int i, r; +amdgpu_amdkfd_device_fini (adev);/* need to disable SMC first */ for (i =0 ; i < adev->num_ip_blocks; i++) {if (!adev->ip_blocks[i].status.hw)
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0 -5
@@ -63,8 +63,6 @@ void amdgpu_driver_unload_kms(struct drm_device *dev)pm_runtime_forbid (dev->dev); } -amdgpu_amdkfd_device_fini (adev); -amdgpu_acpi_fini (adev);amdgpu_device_fini (adev);
@@ -170,9 +168,6 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags) "Error during ACPI methods call\n"); } -amdgpu_amdkfd_device_probe (adev); -amdgpu_amdkfd_device_init (adev); -if (amdgpu_device_is_px (dev)) {pm_runtime_use_autosuspend (dev->dev);pm_runtime_set_autosuspend_delay (dev->dev,5000 );
Signature · 6 lines
2.9.5 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 2/2 drm/amdgpu: release exclusive mode after hw_init
In reply to a message not in the archiveFrom: pding <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++++ drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +4 -0
@@ -1790,6 +1790,10 @@ static int amdgpu_init(struct amdgpu_device *adev) }amdgpu_amdkfd_device_init (adev); + +if (amdgpu_sriov_vf (adev)) +amdgpu_virt_release_full_gpu (adev, true); +return 0 ; }
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0 -3
@@ -177,9 +177,6 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)pm_runtime_put_autosuspend (dev->dev); } -if (amdgpu_sriov_vf (adev)) -amdgpu_virt_release_full_gpu (adev, true); - out:if (r) {/* balance pm_runtime_get_sync in amdgpu_driver_unload_kms */
Signature · 6 lines
2.9.5 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[+Oded]
Hi Pixel,
Thanks, this looks a lot cleaner. The series is Reviewed-by: Felix Kuehling <[email protected]>. Oded, are you OK with this as well?
Regards,
Felix
Quoted 10 lines · Pixel Ding
Hi Felix,
Please review.
[PATCH 1/2] drm/amdkfd: initialise kfd inside
amdgpu_device_initAs you suggested, move kfd init/fini insideamdgpu_device_init. Other changes for KFD interfaces are dropped.[PATCH 2/2] drm/amdgpu: release exclusive mode after
hw_init
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 85376f85-7407-53a1-e10a-5095e888de27-5C7GfCeVMHo@public.gmane.org
Yes, that's fine now
Quoted 4 lines · Felix Kuehling
[+Oded]
Hi Pixel,
Quoted 19 lines
Thanks, this looks a lot cleaner. The series is Reviewed-by: Felix Kuehling <[email protected]>. Oded, are you OK with this as well?
Regards,
FelixQuoted 10 lines · Pixel Ding
Hi Felix,
Please review.
[PATCH 1/2] drm/amdkfd: initialise kfd inside
amdgpu_device_initAs you suggested, move kfd init/fini insideamdgpu_device_init. Other changes for KFD interfaces are dropped.[PATCH 2/2] drm/amdgpu: release exclusive mode after
hw_init
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx