Skip to contentSkip to conversation

Patch "mfd: axp20x: Fix axp288 PEK_DBR and PEK_DBF irqs being swapped" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Nov 6, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

    mfd: axp20x: Fix axp288 PEK_DBR and PEK_DBF irqs being swapped

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     mfd-axp20x-fix-axp288-pek_dbr-and-pek_dbf-irqs-being-swapped.patch

and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Nov 6 10:22:56 CET 2017

From: Hans de Goede <[email protected]>
Date: Sat, 7 Oct 2017 22:37:44 +0000
Subject: mfd: axp20x: Fix axp288 PEK_DBR and PEK_DBF irqs being swapped

From: Hans de Goede <[email protected]>

[ Upstream commit 1af468ebe45591651ec3bafc2e9ddc6fdef70ae0 ]

The R in PEK_DBR stands for rising, so it should be mapped to AXP288_IRQ_POKP where the last P stands for positive edge.

Likewise PEK_DBF should be mapped to the falling edge, aka the _N_egative edge, so it should be mapped to AXP288_IRQ_POKN.

This fixes the inverted powerbutton status reporting by the axp20x-pek driver.

---
 drivers/mfd/axp20x.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/mfd/axp20x.c +4 -4
@@ -164,14 +164,14 @@ static struct resource axp22x_pek_resour
 static struct resource axp288_power_button_resources[] = {
 	{
 		.name	= "PEK_DBR",
-		.start	= AXP288_IRQ_POKN,
-		.end	= AXP288_IRQ_POKN,
+		.start	= AXP288_IRQ_POKP,
+		.end	= AXP288_IRQ_POKP,
 		.flags	= IORESOURCE_IRQ,
 	},
 	{
 		.name	= "PEK_DBF",
-		.start	= AXP288_IRQ_POKP,
-		.end	= AXP288_IRQ_POKP,
+		.start	= AXP288_IRQ_POKN,
+		.end	= AXP288_IRQ_POKN,
 		.flags	= IORESOURCE_IRQ,
 	},
 };

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/mfd-axp20x-fix-axp288-pek_dbr-and-pek_dbf-irqs-being-swapped.patch